Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove domain/async #3813

Merged
merged 6 commits into from
Oct 18, 2022
Merged

Remove domain/async #3813

merged 6 commits into from
Oct 18, 2022

Conversation

NelsonVides
Copy link
Collaborator

Most often, tenant deletion can incur in many many DB operations, which can introduce very long delays and timeout any HTTP connection. And when the HTTP connection times out, the cowboy process running the tenant deletion hook will timeout, and could potentially leave the DB in an inconsistent state.

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 82.99% // Head: 83.00% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (aa6e24d) compared to base (a9ee17f).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3813   +/-   ##
=======================================
  Coverage   82.99%   83.00%           
=======================================
  Files         529      529           
  Lines       33834    33856   +22     
=======================================
+ Hits        28081    28102   +21     
- Misses       5753     5754    +1     
Impacted Files Coverage Δ
src/domain/mongoose_domain_db_cleaner.erl 67.56% <71.42%> (+0.90%) ⬆️
...l/admin/mongoose_graphql_domain_admin_mutation.erl 90.00% <75.00%> (-2.31%) ⬇️
src/domain/mongoose_domain_api.erl 95.83% <100.00%> (+0.18%) ⬆️
src/domain/mongoose_domain_sql.erl 93.95% <100.00%> (+0.04%) ⬆️
...c/mongoose_admin_api/mongoose_admin_api_domain.erl 100.00% <100.00%> (ø)
src/mongoose_cleaner.erl 60.00% <0.00%> (-10.00%) ⬇️
src/pubsub/node_pep.erl 77.77% <0.00%> (-1.86%) ⬇️
src/mod_roster_riak.erl 96.92% <0.00%> (-1.54%) ⬇️
src/inbox/mod_inbox_rdbms_async.erl 72.05% <0.00%> (-1.48%) ⬇️
src/mod_roster.erl 78.70% <0.00%> (-0.48%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 17, 2022

small_tests_24 / small_tests / 6e3fc6d
Reports root / small


small_tests_25 / small_tests / 6e3fc6d
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 6e3fc6d
Reports root/ big
OK: 2096 / Failed: 0 / User-skipped: 780 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6e3fc6d
Reports root/ big
OK: 3983 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 6e3fc6d
Reports root/ big
OK: 2096 / Failed: 0 / User-skipped: 780 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6e3fc6d
Reports root/ big
OK: 3983 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 6e3fc6d
Reports root/ big
OK: 3957 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 6e3fc6d
Reports root/ big
OK: 2232 / Failed: 0 / User-skipped: 644 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 6e3fc6d
Reports root/ big
OK: 4357 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6e3fc6d
Reports root/ big
OK: 2572 / Failed: 0 / User-skipped: 639 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6e3fc6d
Reports root/ big
OK: 3983 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 6e3fc6d
Reports root/ big
OK: 4357 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 6e3fc6d
Reports root/ big
OK: 4343 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 6e3fc6d
Reports root/ big
OK: 2418 / Failed: 0 / User-skipped: 625 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 6e3fc6d
Reports root/ big
OK: 4367 / Failed: 2 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:delayed_receive_with_sm
{error,{{badmatch,[]},
    [{pep_SUITE,'-delayed_receive_with_sm/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
           {line,295}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,{{assertion_failed,assert_many,false,
              [is_roster_set,is_presence,is_presence],
              [{xmlel,<<"presence">>,
                  [{<<"from">>,
                  <<"alice_unsubscribe_after_presence_unsubscription_2582@localhost/res1">>},
                   {<<"to">>,
                  <<"bob_unsubscribe_after_presence_unsubscription_2582@localhost/res1">>},
                   {<<"xml:lang">>,<<"en">>}],
                  []}],
              "   <presence from='alice_unsubscribe_after_presence_unsubscription_2582@localhost/res1' to='bob_unsubscribe_after_presence_unsubscription_2582@localhost/res1' xml:lang='en'/>"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
     {escalus_utils,'-each_with_index/3-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,87}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {escalus_utils,distinct_pairs,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
             {line,60}]},
     {escalus_story,mak...

Report log

big_tests/tests/graphql_domain_SUITE.erl Outdated Show resolved Hide resolved
big_tests/tests/service_domain_db_SUITE.erl Outdated Show resolved Hide resolved
priv/graphql/schemas/admin/domain.gql Outdated Show resolved Hide resolved
src/domain/mongoose_domain_api.erl Show resolved Hide resolved
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 18, 2022

small_tests_24 / small_tests / aa6e24d
Reports root / small


small_tests_25 / small_tests / aa6e24d
Reports root / small


ldap_mnesia_24 / ldap_mnesia / aa6e24d
Reports root/ big
OK: 2096 / Failed: 0 / User-skipped: 780 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / aa6e24d
Reports root/ big
OK: 3982 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log


dynamic_domains_mysql_redis_25 / mysql_redis / aa6e24d
Reports root/ big
OK: 3957 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / aa6e24d
Reports root/ big
OK: 2096 / Failed: 0 / User-skipped: 780 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / aa6e24d
Reports root/ big
OK: 3983 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / aa6e24d
Reports root/ big
OK: 2232 / Failed: 0 / User-skipped: 644 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / aa6e24d
Reports root/ big
OK: 4357 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / aa6e24d
Reports root/ big
OK: 3983 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / aa6e24d
Reports root/ big
OK: 2572 / Failed: 0 / User-skipped: 639 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / aa6e24d
Reports root/ big
OK: 4357 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / aa6e24d
Reports root/ big
OK: 4343 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / aa6e24d
Reports root/ big
OK: 2418 / Failed: 0 / User-skipped: 625 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / aa6e24d
Reports root/ big
OK: 4357 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / aa6e24d
Reports root/ big
OK: 3983 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

@kamilwaz kamilwaz merged commit 85cd6ef into master Oct 18, 2022
@kamilwaz kamilwaz deleted the remove_domain/async branch October 18, 2022 13:47
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants