Convert mod_vcard to gen_hook #3833
Conversation
|
small_tests_24 / small_tests / ff5d269 small_tests_25 / small_tests / ff5d269 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ff5d269 ldap_mnesia_24 / ldap_mnesia / ff5d269 ldap_mnesia_25 / ldap_mnesia / ff5d269 dynamic_domains_mysql_redis_25 / mysql_redis / ff5d269 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ff5d269 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ff5d269 internal_mnesia_25 / internal_mnesia / ff5d269 pgsql_mnesia_24 / pgsql_mnesia / ff5d269 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ff5d269 riak_mnesia_24 / riak_mnesia / ff5d269 pgsql_mnesia_25 / pgsql_mnesia / ff5d269 mysql_redis_25 / mysql_redis / ff5d269 mssql_mnesia_25 / odbc_mssql_mnesia / ff5d269 dynamic_domains_mysql_redis_25 / mysql_redis / ff5d269 |
Codecov ReportBase: 80.57% // Head: 83.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3833 +/- ##
==========================================
+ Coverage 80.57% 83.05% +2.48%
==========================================
Files 528 528
Lines 33910 33911 +1
==========================================
+ Hits 27322 28164 +842
+ Misses 6588 5747 -841
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/vcard/mod_vcard.erl
Outdated
| Acc :: mongoose_acc:t(), | ||
| Params :: map(), | ||
| Extra :: map(). | ||
| remove_user(Acc, #{jid := #jid{luser = User, lserver = Server}}, #{host_type := HostType}) -> | ||
| HostType = mongoose_acc:host_type(Acc), |
There was a problem hiding this comment.
I think we can remove this line since HostType is already bound in function's head.
|
small_tests_24 / small_tests / 5d4df61 small_tests_25 / small_tests / 5d4df61 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5d4df61 ldap_mnesia_24 / ldap_mnesia / 5d4df61 ldap_mnesia_25 / ldap_mnesia / 5d4df61 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 5d4df61 dynamic_domains_mysql_redis_25 / mysql_redis / 5d4df61 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5d4df61 bosh_SUITE:essential:accept_higher_hold_value{error,
{{assertEqual,
[{module,bosh_SUITE},
{line,251},
{expression,"get_bosh_sessions ( )"},
{expected,[]},
{value,
[{bosh_session,<<"9bdacbec18c36fe47f625f7a2600aea431f23a40">>,
<9146.5994.0>}]}]},
[{bosh_SUITE,accept_higher_hold_value,1,
[{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
{line,251}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}internal_mnesia_25 / internal_mnesia / 5d4df61 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 5d4df61 pgsql_mnesia_24 / pgsql_mnesia / 5d4df61 riak_mnesia_24 / riak_mnesia / 5d4df61 pgsql_mnesia_25 / pgsql_mnesia / 5d4df61 mysql_redis_25 / mysql_redis / 5d4df61 mssql_mnesia_25 / odbc_mssql_mnesia / 5d4df61 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5d4df61 rest_client_SUITE:roster:add_and_remove_some_contacts_with_nonexisting{error,{{badmatch,{{<<"500">>,<<"Internal Server Error">>},<<>>}},
[{rest_client_SUITE,add_contact_check_roster_push,2,
[{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,1423}]},
{lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
{rest_client_SUITE,'-add_and_remove_some_contacts_with_nonexisting/1-fun-1-',
4,
[{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,1391}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{rest_client_SUITE,add_and_remove_some_contacts_with_nonexisting,1,
[{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,1386}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5d4df61 |
Convert mod_vcard to gen_hook