Inbox/full pagination xep #3844
Conversation
NelsonVides
changed the base branch from
inbox_total_count_unread
to
inbox/unique_pagination_ids
NelsonVides
force-pushed
the
inbox/full_pagination_xep
branch
from
f96c5f1
to
b663a02
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 83.02% // Head: 83.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## inbox/unique_pagination_ids #3844 +/- ##
===============================================================
+ Coverage 83.02% 83.07% +0.05%
===============================================================
Files 529 529
Lines 33919 33920 +1
===============================================================
+ Hits 28161 28180 +19
+ Misses 5758 5740 -18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
NelsonVides
force-pushed
the
inbox/unique_pagination_ids
branch
from
7144a40
to
7d84d79
Compare
NelsonVides
force-pushed
the
inbox/full_pagination_xep
branch
from
b663a02
to
7b0cacb
Compare
|
small_tests_24 / small_tests / 7b0cacb small_tests_25 / small_tests / 7b0cacb dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7b0cacb ldap_mnesia_24 / ldap_mnesia / 7b0cacb dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 7b0cacb ldap_mnesia_25 / ldap_mnesia / 7b0cacb pgsql_mnesia_24 / pgsql_mnesia / 7b0cacb internal_mnesia_25 / internal_mnesia / 7b0cacb dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 7b0cacb elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 7b0cacb dynamic_domains_mysql_redis_25 / mysql_redis / 7b0cacb metrics_api_SUITE:global:session_counters{error,{{assertEqual,[{module,metrics_api_SUITE},
{line,404},
{comment,[{counter,totalSessionCount}]},
{expression,"ValueList"},
{expected,2},
{value,3}]},
[{metrics_api_SUITE,fetch_global_gauge_value,2,
[{file,"/home/circleci/project/big_tests/tests/metrics_api_SUITE.erl"},
{line,404}]},
{metrics_api_SUITE,'-session_counters/1-fun-3-',4,
[{file,"/home/circleci/project/big_tests/tests/metrics_api_SUITE.erl"},
{line,226}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}riak_mnesia_24 / riak_mnesia / 7b0cacb pgsql_mnesia_25 / pgsql_mnesia / 7b0cacb mysql_redis_25 / mysql_redis / 7b0cacb mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted{error,
{{assertMatch,
[{module,mod_event_pusher_rabbit_SUITE},
{line,422},
{expression,
"get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
{pattern,
"# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
{value,
#{<<"from_user_id">> => <<"muc_publish@muc.localhost">>,
<<"message">> => <<>>,
<<"to_user_id">> =>
<<"alice_unnamed_2172@localhost/res1">>}}]},
[{mod_event_pusher_rabbit_SUITE,
'-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
[{file,
"/home/circleci/project/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
{line,422}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mssql_mnesia_25 / odbc_mssql_mnesia / 7b0cacb dynamic_domains_mysql_redis_25 / mysql_redis / 7b0cacb muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}dynamic_domains_mysql_redis_25 / mysql_redis / 7b0cacb |
We simply choose to omit exposing total counts and pagination by index, it would complicate code too much, it is not that useful, and also MAM already showed that that doesn't scale.