Improve error handling in API module last

[jacekwegr]

This PR changes some of the returned values from "last" module's functions to be more consistent with the whole GraphQL API

[codecov]

Codecov Report

Base: 83.11% // Head: 83.09% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (0d804a7) compared to base (c5cd29b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3850      +/-   ##
==========================================
- Coverage   83.11%   83.09%   -0.03%     
==========================================
  Files         534      534              
  Lines       34096    34097       +1     
==========================================
- Hits        28339    28333       -6     
- Misses       5757     5764       +7     

Impacted Files	Coverage Δ
src/admin_extra/service_admin_extra_accounts.erl	90.00% <100.00%> (ø)
...hql/admin/mongoose_graphql_last_admin_mutation.erl	100.00% <100.00%> (ø)
...raphql/admin/mongoose_graphql_last_admin_query.erl	100.00% <100.00%> (ø)
src/mod_last_api.erl	100.00% <100.00%> (ø)
src/event_pusher/mod_event_pusher_sns.erl	82.19% <0.00%> (-12.33%)	⬇️
src/domain/service_domain_db.erl	83.33% <0.00%> (-2.09%)	⬇️
src/pubsub/node_pep.erl	77.77% <0.00%> (-1.86%)	⬇️
src/inbox/mod_inbox_rdbms_async.erl	72.05% <0.00%> (-1.48%)	⬇️
src/mod_roster.erl	78.70% <0.00%> (-0.24%)	⬇️
src/ejabberd_c2s.erl	88.95% <0.00%> (-0.08%)	⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mongoose-im]

small_tests_24 / small_tests / 0d804a7
Reports root / small

---

small_tests_25 / small_tests / 0d804a7
Reports root / small

---

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0d804a7
Reports root/ big
OK: 4033 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

---

ldap_mnesia_24 / ldap_mnesia / 0d804a7
Reports root/ big
OK: 2126 / Failed: 0 / User-skipped: 792 / Auto-skipped: 0

---

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 0d804a7
Reports root/ big
OK: 4033 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

---

dynamic_domains_mysql_redis_25 / mysql_redis / 0d804a7
Reports root/ big
OK: 4007 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

---

ldap_mnesia_25 / ldap_mnesia / 0d804a7
Reports root/ big
OK: 2126 / Failed: 0 / User-skipped: 792 / Auto-skipped: 0

---

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 0d804a7
Reports root/ big
OK: 4033 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

---

internal_mnesia_25 / internal_mnesia / 0d804a7
Reports root/ big
OK: 2266 / Failed: 0 / User-skipped: 652 / Auto-skipped: 0

---

pgsql_mnesia_24 / pgsql_mnesia / 0d804a7
Reports root/ big
OK: 4407 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

---

pgsql_mnesia_25 / pgsql_mnesia / 0d804a7
Reports root/ big
OK: 4418 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2605@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2605@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"OxetMZD3ls6KdmGWmv5e0Q==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

---

riak_mnesia_24 / riak_mnesia / 0d804a7
Reports root/ big
OK: 2454 / Failed: 0 / User-skipped: 631 / Auto-skipped: 0

---

mysql_redis_25 / mysql_redis / 0d804a7
Reports root/ big
OK: 4393 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

---

mssql_mnesia_25 / odbc_mssql_mnesia / 0d804a7
Reports root/ big
OK: 4407 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

[chrzaszcz]

Looks good 👍