Merge c2s_preprocessing_hook into user_send_packet #3852
Conversation
|
small_tests_24 / small_tests / 2c099c2 small_tests_25 / small_tests / 2c099c2 ldap_mnesia_24 / ldap_mnesia / 2c099c2 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 2c099c2 ldap_mnesia_25 / ldap_mnesia / 2c099c2 pgsql_mnesia_24 / pgsql_mnesia / 2c099c2 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 2c099c2 dynamic_domains_mysql_redis_25 / mysql_redis / 2c099c2 internal_mnesia_25 / internal_mnesia / 2c099c2 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 2c099c2 mysql_redis_25 / mysql_redis / 2c099c2 mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted{error,
{{assertMatch,
[{module,mod_event_pusher_rabbit_SUITE},
{line,422},
{expression,
"get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
{pattern,
"# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
{value,
#{<<"from_user_id">> =>
<<"muc_publish@muc.localhost/bob_unnamed_2040">>,
<<"message">> => <<"Hi there!">>,
<<"to_user_id">> =>
<<"alice_unnamed_2041@localhost/res1">>}}]},
[{mod_event_pusher_rabbit_SUITE,
'-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
[{file,
"/home/circleci/project/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
{line,422}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted{error,
{{assertMatch,
[{module,mod_event_pusher_rabbit_SUITE},
{line,422},
{expression,
"get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
{pattern,
"# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
{value,
#{<<"from_user_id">> =>
<<"muc_publish@muc.localhost/bob_unnamed_2042">>,
<<"message">> => <<"Hi there!">>,
<<"to_user_id">> =>
<<"alice_unnamed_2045@localhost/res1">>}}]},
[{mod_event_pusher_rabbit_SUITE,
'-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
[{file,
"/home/circleci/project/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
{line,422}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}riak_mnesia_24 / riak_mnesia / 2c099c2 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 2c099c2 pgsql_mnesia_25 / pgsql_mnesia / 2c099c2 mssql_mnesia_25 / odbc_mssql_mnesia / 2c099c2 mysql_redis_25 / mysql_redis / 2c099c2 |
Codecov ReportBase: 72.14% // Head: 72.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feature/mongoose_c2s #3852 +/- ##
========================================================
+ Coverage 72.14% 72.18% +0.04%
========================================================
Files 534 534
Lines 34032 34012 -20
========================================================
Hits 24551 24551
+ Misses 9481 9461 -20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/jingle_sip/mod_jingle_sip.erl
Outdated
| maybe_iq_stanza(Acc) -> | ||
| -spec user_send_packet(mongoose_acc:t(), mongoose_c2s_hooks:hook_params(), gen_hook:extra()) -> | ||
| gen_hook:hook_fn_ret(mongoose_acc:t()). | ||
| user_send_packet(Acc, _, _) -> |
There was a problem hiding this comment.
Not better to use user_send_iq here?
src/mod_amp.erl
Outdated
| gen_hook:hook_fn_ret(mongoose_acc:t()). | ||
| run_initial_check(Acc, _, _) -> | ||
| user_send_packet(Acc, _, _) -> |
There was a problem hiding this comment.
And user_send_message here.
|
small_tests_24 / small_tests / 4e2cb5c small_tests_25 / small_tests / 4e2cb5c ldap_mnesia_24 / ldap_mnesia / 4e2cb5c ldap_mnesia_25 / ldap_mnesia / 4e2cb5c dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 4e2cb5c pgsql_mnesia_24 / pgsql_mnesia / 4e2cb5c dynamic_domains_mysql_redis_25 / mysql_redis / 4e2cb5c internal_mnesia_25 / internal_mnesia / 4e2cb5c dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 4e2cb5c pgsql_mnesia_25 / pgsql_mnesia / 4e2cb5c riak_mnesia_24 / riak_mnesia / 4e2cb5c elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 4e2cb5c pubsub_SUITE:tree+basic:retract_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,491}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,481}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,471}]},
{pubsub_SUITE,'-retract_test/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,648}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}pubsub_SUITE:tree+basic:subscribe_options_separate_request_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,491}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,481}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,471}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mysql_redis_25 / mysql_redis / 4e2cb5c dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 4e2cb5c mssql_mnesia_25 / odbc_mssql_mnesia / 4e2cb5c |
No description provided.