Improve error handling in stat #3870

kamilwaz · 2022-11-22T11:58:21Z

Improve error handling in stat

mongoose-im · 2022-11-22T12:06:30Z

small_tests_24 / small_tests / bc20e0c
Reports root / small

small_tests_25 / small_tests / bc20e0c
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / bc20e0c
Reports root/ big
OK: 4090 / Failed: 1 / User-skipped: 88 / Auto-skipped: 1

mongooseimctl_SUITE:stats:stats_global

{error,
  {badarg,
    [{erlang,list_to_integer,
       ["{ok,660}"],
       [{error_info,#{module => erl_erts_errors}}]},
     {mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
       [{file,
          "/home/circleci/project/big_tests/tests/mongooseimctl_SUITE.erl"},
        {line,1118}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1224}]}]}}

Report log

ldap_mnesia_24 / ldap_mnesia / bc20e0c
Reports root/ big
OK: 2155 / Failed: 0 / User-skipped: 806 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / bc20e0c
Reports root/ big
OK: 4090 / Failed: 1 / User-skipped: 88 / Auto-skipped: 1

mongooseimctl_SUITE:stats:stats_global

{error,
  {badarg,
    [{erlang,list_to_integer,
       ["{ok,652}"],
       [{error_info,#{module => erl_erts_errors}}]},
     {mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
       [{file,
          "/home/circleci/project/big_tests/tests/mongooseimctl_SUITE.erl"},
        {line,1118}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mysql_redis_25 / mysql_redis / bc20e0c
Reports root/ big
OK: 4064 / Failed: 1 / User-skipped: 114 / Auto-skipped: 1

mongooseimctl_SUITE:stats:stats_global

{error,
  {badarg,
    [{erlang,list_to_integer,
       ["{ok,666}"],
       [{error_info,#{module => erl_erts_errors}}]},
     {mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
       [{file,
          "/home/circleci/project/big_tests/tests/mongooseimctl_SUITE.erl"},
        {line,1118}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

ldap_mnesia_25 / ldap_mnesia / bc20e0c
Reports root/ big
OK: 2155 / Failed: 0 / User-skipped: 806 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / bc20e0c
Reports root/ big
OK: 4090 / Failed: 1 / User-skipped: 88 / Auto-skipped: 1

mongooseimctl_SUITE:stats:stats_global

{error,
  {badarg,
    [{erlang,list_to_integer,
       ["{ok,714}"],
       [{error_info,#{module => erl_erts_errors}}]},
     {mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
       [{file,
          "/home/circleci/project/big_tests/tests/mongooseimctl_SUITE.erl"},
        {line,1118}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pgsql_mnesia_24 / pgsql_mnesia / bc20e0c
Reports root/ big
OK: 4475 / Failed: 2 / User-skipped: 97 / Auto-skipped: 1

mongooseimctl_SUITE:stats:stats_global

{error,
  {badarg,
    [{erlang,list_to_integer,
       ["{ok,722}"],
       [{error_info,#{module => erl_erts_errors}}]},
     {mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
       [{file,
          "/home/circleci/project/big_tests/tests/mongooseimctl_SUITE.erl"},
        {line,1118}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2606@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2606@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"tVVFik85fQTm0hEsp453dg==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

internal_mnesia_25 / internal_mnesia / bc20e0c
Reports root/ big
OK: 2295 / Failed: 1 / User-skipped: 664 / Auto-skipped: 1

mongooseimctl_SUITE:stats:stats_global

{error,
  {badarg,
    [{erlang,list_to_integer,
       ["{ok,715}"],
       [{error_info,#{module => erl_erts_errors}}]},
     {mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
       [{file,
          "/home/circleci/project/big_tests/tests/mongooseimctl_SUITE.erl"},
        {line,1118}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / bc20e0c
Reports root/ big
OK: 2641 / Failed: 1 / User-skipped: 657 / Auto-skipped: 1

mongooseimctl_SUITE:stats:stats_global

{error,
  {badarg,
    [{erlang,list_to_integer,
       ["{ok,707}"],
       [{error_info,#{module => erl_erts_errors}}]},
     {mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
       [{file,
          "/home/circleci/project/big_tests/tests/mongooseimctl_SUITE.erl"},
        {line,1118}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / bc20e0c
Reports root/ big
OK: 2485 / Failed: 1 / User-skipped: 643 / Auto-skipped: 1

mongooseimctl_SUITE:stats:stats_global

{error,
  {badarg,
    [{erlang,list_to_integer,
       ["{ok,837}"],
       [{error_info,#{module => erl_erts_errors}}]},
     {mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
       [{file,
          "/home/circleci/project/big_tests/tests/mongooseimctl_SUITE.erl"},
        {line,1118}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / bc20e0c
Reports root/ big
OK: 4464 / Failed: 1 / User-skipped: 97 / Auto-skipped: 1

mongooseimctl_SUITE:stats:stats_global

{error,
  {badarg,
    [{erlang,list_to_integer,
       ["{ok,749}"],
       [{error_info,#{module => erl_erts_errors}}]},
     {mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
       [{file,
          "/home/circleci/project/big_tests/tests/mongooseimctl_SUITE.erl"},
        {line,1118}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / bc20e0c
Reports root/ big
OK: 4450 / Failed: 1 / User-skipped: 111 / Auto-skipped: 1

mongooseimctl_SUITE:stats:stats_global

{error,
  {badarg,
    [{erlang,list_to_integer,
       ["{ok,798}"],
       [{error_info,#{module => erl_erts_errors}}]},
     {mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
       [{file,
          "/home/circleci/project/big_tests/tests/mongooseimctl_SUITE.erl"},
        {line,1118}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / bc20e0c
Reports root/ big
OK: 4464 / Failed: 1 / User-skipped: 97 / Auto-skipped: 1

mongooseimctl_SUITE:stats:stats_global

{error,
  {badarg,
    [{erlang,list_to_integer,
       ["{ok,870}"],
       [{error_info,#{module => erl_erts_errors}}]},
     {mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
       [{file,
          "/home/circleci/project/big_tests/tests/mongooseimctl_SUITE.erl"},
        {line,1118}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

codecov · 2022-11-22T12:07:44Z

Codecov Report

Base: 83.12% // Head: 83.14% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (453fc74) compared to base (89d1b2b).
Patch coverage: 80.64% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3870      +/-   ##
==========================================
+ Coverage   83.12%   83.14%   +0.01%     
==========================================
  Files         535      535              
  Lines       34164    34174      +10     
==========================================
+ Hits        28400    28413      +13     
+ Misses       5764     5761       -3

Impacted Files	Coverage Δ
src/admin_extra/service_admin_extra_stats.erl	`100.00% <ø> (ø)`
src/stats_api.erl	`76.47% <76.47%> (-8.15%)`	⬇️
...rc/graphql/admin/mongoose_graphql_stats_domain.erl	`80.00% <80.00%> (-20.00%)`	⬇️
...rc/graphql/admin/mongoose_graphql_stats_global.erl	`88.88% <88.88%> (-11.12%)`	⬇️
src/muc_light/mod_muc_light_db_mnesia.erl	`91.57% <0.00%> (-1.06%)`	⬇️
src/ejabberd_c2s.erl	`88.73% <0.00%> (-0.23%)`	⬇️
src/pubsub/mod_pubsub.erl	`73.04% <0.00%> (-0.19%)`	⬇️
src/mod_muc_log.erl	`62.82% <0.00%> (ø)`
src/pubsub/mod_pubsub_db_rdbms.erl	`95.34% <0.00%> (+0.25%)`	⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl	`68.88% <0.00%> (+2.22%)`	⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mongoose-im · 2022-11-23T10:24:17Z

small_tests_24 / small_tests / afb5249
Reports root / small

small_tests_25 / small_tests / afb5249
Reports root / small

ldap_mnesia_24 / ldap_mnesia / afb5249
Reports root/ big
OK: 2155 / Failed: 0 / User-skipped: 806 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / afb5249
Reports root/ big
OK: 4092 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / afb5249
Reports root/ big
OK: 4092 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / afb5249
Reports root/ big
OK: 4065 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive

{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

ldap_mnesia_25 / ldap_mnesia / afb5249
Reports root/ big
OK: 2155 / Failed: 0 / User-skipped: 806 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / afb5249
Reports root/ big
OK: 4092 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / afb5249
Reports root/ big
OK: 2297 / Failed: 0 / User-skipped: 664 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / afb5249
Reports root/ big
OK: 4466 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / afb5249
Reports root/ big
OK: 2643 / Failed: 0 / User-skipped: 657 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / afb5249
Reports root/ big
OK: 2487 / Failed: 0 / User-skipped: 643 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / afb5249
Reports root/ big
OK: 4452 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / afb5249
Reports root/ big
OK: 4466 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / afb5249
Reports root/ big
OK: 4466 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / afb5249
Reports root/ big
OK: 4066 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

JanuszJakubiec · 2022-11-24T10:23:49Z

src/graphql/admin/mongoose_graphql_stats_domain.erl

@@ -12,6 +12,12 @@
 -include("jlib.hrl").

 execute(_Ctx, Domain, <<"registeredUsers">>, _Args) ->
-    {ok, stats_api:stats(<<"registeredusers">>, Domain)};
+    globalStats(<<"registeredusers">>, Domain);


Suggested change

globalStats(<<"registeredusers">>, Domain);

domainStats(<<"registeredusers">>, Domain);

I think the function name "globalStats" here is a bit misleading, because the stats called here are domain stats.

JanuszJakubiec · 2022-11-24T10:25:03Z

src/graphql/admin/mongoose_graphql_stats_domain.erl

 execute(_Ctx, Domain, <<"onlineUsers">>, _Args) ->
-    {ok, stats_api:stats(<<"onlineusers">>, Domain)}.
+    globalStats(<<"onlineusers">>, Domain).


Suggested change

globalStats(<<"onlineusers">>, Domain).

domainStats(<<"onlineusers">>, Domain).

JanuszJakubiec · 2022-11-24T10:25:16Z

src/graphql/admin/mongoose_graphql_stats_domain.erl

-    {ok, stats_api:stats(<<"onlineusers">>, Domain)}.
+    globalStats(<<"onlineusers">>, Domain).
+
+globalStats(Name, Domain) ->


Suggested change

globalStats(Name, Domain) ->

domainStats(Name, Domain) ->

JanuszJakubiec

Looks good, I've added one minor suggestion.

mongoose-im · 2022-11-24T11:05:06Z

small_tests_24 / small_tests / 453fc74
Reports root / small

small_tests_25 / small_tests / 453fc74
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 453fc74
Reports root/ big
OK: 4092 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 453fc74
Reports root/ big
OK: 2155 / Failed: 0 / User-skipped: 806 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 453fc74
Reports root/ big
OK: 2155 / Failed: 0 / User-skipped: 806 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 453fc74
Reports root/ big
OK: 4092 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 453fc74
Reports root/ big
OK: 4066 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 453fc74
Reports root/ big
OK: 4466 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 453fc74
Reports root/ big
OK: 4092 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 453fc74
Reports root/ big
OK: 2643 / Failed: 0 / User-skipped: 657 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 453fc74
Reports root/ big
OK: 4477 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2656@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2656@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"3+XVxjjMWLKVWqgmbOHtqQ==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / 453fc74
Reports root/ big
OK: 4452 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 453fc74
Reports root/ big
OK: 4466 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 453fc74
Reports root/ big
OK: 2487 / Failed: 0 / User-skipped: 643 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 453fc74
Reports root/ big
OK: 2297 / Failed: 0 / User-skipped: 664 / Auto-skipped: 0

kamilwaz force-pushed the api-modules/stat branch from bc20e0c to afb5249 Compare November 23, 2022 10:16

kamilwaz marked this pull request as ready for review November 23, 2022 13:38

JanuszJakubiec reviewed Nov 24, 2022

View reviewed changes

JanuszJakubiec requested changes Nov 24, 2022

View reviewed changes

Improve error handling in stat

453fc74

kamilwaz force-pushed the api-modules/stat branch from afb5249 to 453fc74 Compare November 24, 2022 10:56

kamilwaz requested a review from JanuszJakubiec November 24, 2022 13:43

JanuszJakubiec approved these changes Nov 24, 2022

View reviewed changes

JanuszJakubiec merged commit 5bdda43 into master Nov 24, 2022

JanuszJakubiec deleted the api-modules/stat branch November 24, 2022 16:04

chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve error handling in stat #3870

Improve error handling in stat #3870

kamilwaz commented Nov 22, 2022

mongoose-im commented Nov 22, 2022 •

edited

codecov bot commented Nov 22, 2022 •

edited

mongoose-im commented Nov 23, 2022 •

edited

JanuszJakubiec Nov 24, 2022

JanuszJakubiec Nov 24, 2022

JanuszJakubiec Nov 24, 2022

JanuszJakubiec Nov 24, 2022

JanuszJakubiec left a comment •

edited

mongoose-im commented Nov 24, 2022 •

edited

	globalStats(<<"registeredusers">>, Domain);
	domainStats(<<"registeredusers">>, Domain);

	globalStats(<<"onlineusers">>, Domain).
	domainStats(<<"onlineusers">>, Domain).

Improve error handling in stat #3870

Improve error handling in stat #3870

Conversation

kamilwaz commented Nov 22, 2022

mongoose-im commented Nov 22, 2022 • edited

codecov bot commented Nov 22, 2022 • edited

Codecov Report

mongoose-im commented Nov 23, 2022 • edited

JanuszJakubiec Nov 24, 2022

Choose a reason for hiding this comment

JanuszJakubiec Nov 24, 2022

Choose a reason for hiding this comment

JanuszJakubiec Nov 24, 2022

Choose a reason for hiding this comment

JanuszJakubiec Nov 24, 2022

Choose a reason for hiding this comment

JanuszJakubiec left a comment • edited

Choose a reason for hiding this comment

mongoose-im commented Nov 24, 2022 • edited

mongoose-im commented Nov 22, 2022 •

edited

codecov bot commented Nov 22, 2022 •

edited

mongoose-im commented Nov 23, 2022 •

edited

JanuszJakubiec left a comment •

edited

mongoose-im commented Nov 24, 2022 •

edited