Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored hook handlers in mod_privacy #3876

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Conversation

pawlooss1
Copy link
Member

This PR changes all hook handlers in mod_privacy module to gen_hook format.

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 83.13% // Head: 83.13% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (773749e) compared to base (caab05d).
Patch coverage: 95.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3876      +/-   ##
==========================================
- Coverage   83.13%   83.13%   -0.01%     
==========================================
  Files         535      535              
  Lines       34199    34197       -2     
==========================================
- Hits        28432    28428       -4     
- Misses       5767     5769       +2     
Impacted Files Coverage Δ
src/privacy/mod_privacy.erl 85.47% <92.85%> (-0.49%) ⬇️
src/mongoose_hooks.erl 96.02% <100.00%> (+0.05%) ⬆️
src/mam/mod_mam_muc_rdbms_arch_async.erl 82.85% <0.00%> (-2.86%) ⬇️
src/rdbms/mongoose_rdbms.erl 65.26% <0.00%> (-1.06%) ⬇️
src/muc_light/mod_muc_light_db_mnesia.erl 91.57% <0.00%> (-1.06%) ⬇️
src/mod_roster.erl 78.70% <0.00%> (-0.48%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/pubsub/mod_pubsub_db_rdbms.erl 95.34% <0.00%> (+0.25%) ⬆️
src/inbox/mod_inbox_rdbms_async.erl 73.52% <0.00%> (+1.47%) ⬆️
src/pubsub/node_pep.erl 79.62% <0.00%> (+1.85%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 28, 2022

small_tests_24 / small_tests / 773749e
Reports root / small


small_tests_25 / small_tests / 773749e
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 773749e
Reports root/ big
OK: 2167 / Failed: 0 / User-skipped: 818 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 773749e
Reports root/ big
OK: 4116 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 773749e
Reports root/ big
OK: 4090 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 773749e
Reports root/ big
OK: 2167 / Failed: 0 / User-skipped: 818 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 773749e
Reports root/ big
OK: 4116 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 773749e
Reports root/ big
OK: 4116 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 773749e
Reports root/ big
OK: 4490 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 773749e
Reports root/ big
OK: 2309 / Failed: 0 / User-skipped: 676 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 773749e
Reports root/ big
OK: 2662 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 773749e
Reports root/ big
OK: 4476 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 773749e
Reports root/ big
OK: 2503 / Failed: 0 / User-skipped: 651 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 773749e
Reports root/ big
OK: 4501 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2826@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2826@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"dxfgfTXMwe62L1mNAbEMwg==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


mssql_mnesia_25 / odbc_mssql_mnesia / 773749e
Reports root/ big
OK: 4490 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@pawlooss1 pawlooss1 marked this pull request as ready for review November 28, 2022 12:18
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The types are a bit verbose but I guess it's better to be precise with hooks because of how they are executed.

@NelsonVides NelsonVides merged commit 2827383 into master Nov 28, 2022
@NelsonVides NelsonVides deleted the hooks/mod_privacy branch November 28, 2022 13:29
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants