C2s/login_suite #3882

NelsonVides · 2022-11-30T18:39:50Z

No description provided.

codecov · 2022-11-30T18:49:14Z

Codecov Report

Base: 72.67% // Head: 73.14% // Increases project coverage by +0.47% 🎉

Coverage data is based on head (670c038) compared to base (29c7bdc).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files

@@                   Coverage Diff                    @@
##           feature/mongoose_c2s    #3882      +/-   ##
========================================================
+ Coverage                 72.67%   73.14%   +0.47%     
========================================================
  Files                       540      540              
  Lines                     34142    34148       +6     
========================================================
+ Hits                      24811    24976     +165     
+ Misses                     9331     9172     -159

Impacted Files	Coverage Δ
src/ejabberd_socket.erl	`33.33% <ø> (+0.45%)`	⬆️
src/mod_bosh_socket.erl	`75.89% <0.00%> (-0.23%)`	⬇️
src/mod_websockets.erl	`80.86% <0.00%> (-0.51%)`	⬇️
src/mongoose_tls.erl	`2.77% <ø> (+0.27%)`	⬆️
src/c2s/mongoose_c2s_ranch.erl	`76.92% <50.00%> (-1.08%)`	⬇️
src/c2s/mongoose_c2s.erl	`85.48% <83.33%> (+3.53%)`	⬆️
src/c2s/mongoose_c2s_socket.erl	`80.00% <100.00%> (+0.58%)`	⬆️
src/sasl/cyrsasl_scram.erl	`95.65% <100.00%> (+95.65%)`	⬆️
src/async_pools/mongoose_aggregator_worker.erl	`63.33% <0.00%> (-5.01%)`	⬇️
src/ejabberd.erl	`50.00% <0.00%> (-5.00%)`	⬇️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mongoose-im · 2022-12-02T00:18:34Z

small_tests_24 / small_tests / 6c4b276
Reports root / small

small_tests_25 / small_tests / 6c4b276
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 6c4b276
Reports root/ big
OK: 1667 / Failed: 1 / User-skipped: 772 / Auto-skipped: 0

service_mongoose_system_metrics_SUITE:system_metrics_are_reported_to_configurable_google_analytics

{error,
  {{assertEqual,
     [{module,service_mongoose_system_metrics_SUITE},
      {line,470},
      {expression,"ActualTrackingIds"},
      {expected,[<<"UA-151671255-1">>,<<"UA-EXTRA-TRACKING-ID">>]},
      {value,[<<"UA-151671255-1">>]}]},
   [{service_mongoose_system_metrics_SUITE,
      events_are_reported_to_tracking_ids,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
       {line,470}]},
    {service_mongoose_system_metrics_SUITE,
      system_metrics_are_reported_to_configurable_google_analytics,1,
      [{file,
         "/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
       {line,204}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

ldap_mnesia_25 / ldap_mnesia / 6c4b276
Reports root/ big
OK: 1668 / Failed: 0 / User-skipped: 772 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6c4b276
Reports root/ big
OK: 3761 / Failed: 0 / User-skipped: 78 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 6c4b276
Reports root/ big
OK: 3937 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6c4b276
Reports root/ big
OK: 3761 / Failed: 0 / User-skipped: 78 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 6c4b276
Reports root/ big
OK: 1818 / Failed: 0 / User-skipped: 622 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 6c4b276
Reports root/ big
OK: 3735 / Failed: 0 / User-skipped: 104 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 6c4b276
Reports root/ big
OK: 3937 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 6c4b276
Reports root/ big
OK: 3923 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6c4b276
Reports root/ big
OK: 3761 / Failed: 0 / User-skipped: 78 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 6c4b276
Reports root/ big
OK: 2018 / Failed: 1 / User-skipped: 607 / Auto-skipped: 0

pubsub_SUITE:dag+basic:publish_with_max_items_test

{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,491}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,481}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,471}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6c4b276
Reports root/ big
OK: 2154 / Failed: 0 / User-skipped: 621 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 6c4b276
Reports root/ big
OK: 3937 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 6c4b276
Reports root/ big
OK: 1668 / Failed: 0 / User-skipped: 772 / Auto-skipped: 0

src/c2s/mongoose_c2s.erl

src/mod_bosh_socket.erl

src/mod_websockets.erl

mongoose-im · 2022-12-02T11:33:50Z

small_tests_24 / small_tests / 670c038
Reports root / small

small_tests_25 / small_tests / 670c038
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 670c038
Reports root/ big
OK: 1668 / Failed: 0 / User-skipped: 772 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 670c038
Reports root/ big
OK: 1668 / Failed: 0 / User-skipped: 772 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 670c038
Reports root/ big
OK: 3761 / Failed: 0 / User-skipped: 78 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 670c038
Reports root/ big
OK: 3761 / Failed: 0 / User-skipped: 78 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 670c038
Reports root/ big
OK: 1818 / Failed: 0 / User-skipped: 622 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 670c038
Reports root/ big
OK: 3735 / Failed: 0 / User-skipped: 104 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 670c038
Reports root/ big
OK: 3761 / Failed: 0 / User-skipped: 78 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 670c038
Reports root/ big
OK: 2154 / Failed: 0 / User-skipped: 621 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 670c038
Reports root/ big
OK: 3922 / Failed: 1 / User-skipped: 103 / Auto-skipped: 0

rest_SUITE:admin:session_can_be_kicked

{error,{test_case_failed,[70,97,105,108,58,32,
              [60,60,
               "\"alice_session_can_be_kicked_2399@localhost/res1\"",
               62,62],
              32,105,110,32,
              [91,
               [[60,60,
               "\"alice_session_can_be_kicked_2399@localhost/res1\"",
               62,62],
              44,10,
              [32,32,
               [32,
                [32,[32,"   ",32,32,32],32,"   ",32,32,32],
                32,
                [32,"   ",32,32,32],
                32,"   ",32,32,32],
               32,
               [32,[32,"   ",32,32,32],32,"   ",32,32,32],
               32,
               [32,"   ",32,32,32],
               32,"   ",32,32,32],
              [60,60,
               "\"alice_messages_are_archived_2404@localhost/res1\"",
               62,62],
              44,10,
              [32,32,
               [32,
                [32,[32,"   ",32,32,32],32,"   ",32,32,32],
                32,
                [32,"   ",32,32,32],
                32,"   ",32,32,32],
               32,
               [32,[32,"   ",32,32,32],32,"   ",32,32,32],
               32,
               [32,"   ",32,32,32],
               32,"   ",32,32,32],
              [60,60,
               "\"alice_stanzas_are_sent_and_received_2402@localhost/res1\"",
               62,62],
              44,10,
              [32,32,
               [32,
                [32,[32,"   ",32,32,32],32,"   ",32,32,32],
                32,
                [32,"   ...

Report log

pgsql_mnesia_25 / pgsql_mnesia / 670c038
Reports root/ big
OK: 3937 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 670c038
Reports root/ big
OK: 2000 / Failed: 0 / User-skipped: 607 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 670c038
Reports root/ big
OK: 3937 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 670c038
Reports root/ big
OK: 3923 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0

NelsonVides added 3 commits November 30, 2022 19:39

Enable login tests

e22b9a4

Implement channel binding in the new socket

10b7bbe

Fix suite listener and remove zlib test

b6fc75b

This comment was marked as outdated.

Sign in to view

NelsonVides force-pushed the c2s/login_SUITE branch from 32b1f40 to 8d70340 Compare December 1, 2022 23:26

This comment was marked as outdated.

Sign in to view

NelsonVides force-pushed the c2s/login_SUITE branch from 8d70340 to 64dfee6 Compare December 1, 2022 23:59

This comment was marked as outdated.

Sign in to view

NelsonVides added the mongoose_c2s label Dec 2, 2022

Fix closing session only if it had been opened before

6c4b276

NelsonVides force-pushed the c2s/login_SUITE branch from 64dfee6 to 6c4b276 Compare December 2, 2022 00:10

NelsonVides marked this pull request as ready for review December 2, 2022 08:26

kamilwaz requested changes Dec 2, 2022

View reviewed changes

src/c2s/mongoose_c2s.erl Show resolved Hide resolved

src/mod_bosh_socket.erl Outdated Show resolved Hide resolved

src/mod_websockets.erl Outdated Show resolved Hide resolved

Return better errors for bosh and websockets tls last message

670c038

NelsonVides requested a review from kamilwaz December 2, 2022 12:45

kamilwaz approved these changes Dec 2, 2022

View reviewed changes

kamilwaz merged commit 22ebb0b into feature/mongoose_c2s Dec 2, 2022

kamilwaz deleted the c2s/login_SUITE branch December 2, 2022 14:32

jacekwegr added this to the 6.1.0 milestone Apr 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

C2s/login_suite #3882

C2s/login_suite #3882

NelsonVides commented Nov 30, 2022

This comment was marked as outdated.

codecov bot commented Nov 30, 2022 •

edited

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Dec 2, 2022 •

edited

mongoose-im commented Dec 2, 2022 •

edited

C2s/login_suite #3882

C2s/login_suite #3882

Conversation

NelsonVides commented Nov 30, 2022

This comment was marked as outdated.

codecov bot commented Nov 30, 2022 • edited

Codecov Report

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Dec 2, 2022 • edited

mongoose-im commented Dec 2, 2022 • edited

codecov bot commented Nov 30, 2022 •

edited

mongoose-im commented Dec 2, 2022 •

edited

mongoose-im commented Dec 2, 2022 •

edited