Improve logging so that stacktrace does not mess into reason #3885
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 83.13% // Head: 83.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3885 +/- ##
=======================================
Coverage 83.13% 83.13%
=======================================
Files 535 535
Lines 34199 34195 -4
=======================================
- Hits 28432 28429 -3
+ Misses 5767 5766 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
NelsonVides
force-pushed
the
safely/better_logging
branch
from
b4a9c4d
to
e593a1e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
NelsonVides
force-pushed
the
safely/better_logging
branch
from
e593a1e
to
b708a60
Compare
|
small_tests_24 / small_tests / b708a60 small_tests_25 / small_tests / b708a60 ldap_mnesia_24 / ldap_mnesia / b708a60 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b708a60 dynamic_domains_mysql_redis_25 / mysql_redis / b708a60 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b708a60 ldap_mnesia_25 / ldap_mnesia / b708a60 internal_mnesia_25 / internal_mnesia / b708a60 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b708a60 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b708a60 pgsql_mnesia_24 / pgsql_mnesia / b708a60 pgsql_mnesia_25 / pgsql_mnesia / b708a60 mysql_redis_25 / mysql_redis / b708a60 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}riak_mnesia_24 / riak_mnesia / b708a60 mssql_mnesia_25 / odbc_mssql_mnesia / b708a60 inbox_extensions_SUITE:async_pools:one_to_one:mute_muted_entry_gets_unmuted{error,
{{assert,
[{module,inbox_extensions_SUITE},
{line,882},
{expression,"escalus_pred : is_message ( Message )"},
{expected,true},
{value,false}]},
[{inbox_extensions_SUITE,check_message_with_properties,4,
[{file,
"/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
{line,882}]},
{inbox_extensions_SUITE,set_inbox_properties,4,
[{file,
"/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
{line,876}]},
{inbox_extensions_SUITE,'-mute_muted_entry_gets_unmuted/1-fun-2-',2,
[{file,
"/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
{line,575}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mysql_redis_25 / mysql_redis / b708a60 mssql_mnesia_25 / odbc_mssql_mnesia / b708a60 |
Considering that the errors go to the logger, currently reason and stacktrace will get cramped into a single tuple containing reason and stacktrace, and it won't get formatted nicely.