Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert history order #3893

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Revert history order #3893

merged 1 commit into from
Dec 12, 2022

Conversation

arcusfelis
Copy link
Contributor

This PR addresses MIM-1711

Proposed changes include:

  • Also added links to the releases (to be consistent).
  • Bullet points are more easy to read.
  • Added more info, for example, for years 2018-2019.
  • Removed Next, Next, Next sentences, because the order is in reverse.

Still could be refactored a bit, because 2011 and 2012-2015 blocks have a lot of common items (could be even merged).
Probably could add inbox introduction.

Also added links to the releases (to be consistent).
Bullet points are more easy to read.
Added more info, for example, for years 2018-2019.
Removed Next, Next, Next sentences, because the order is in reverse.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 7, 2022

small_tests_24 / small_tests / 31431f0
Reports root / small


small_tests_25 / small_tests / 31431f0
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 31431f0
Reports root/ big
OK: 2202 / Failed: 0 / User-skipped: 823 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 31431f0
Reports root/ big
OK: 4156 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 31431f0
Reports root/ big
OK: 2202 / Failed: 0 / User-skipped: 823 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 31431f0
Reports root/ big
OK: 4156 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 31431f0
Reports root/ big
OK: 4130 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 31431f0
Reports root/ big
OK: 4156 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 31431f0
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 31431f0
Reports root/ big
OK: 2344 / Failed: 0 / User-skipped: 681 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 31431f0
Reports root/ big
OK: 4530 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 31431f0
Reports root/ big
OK: 4530 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 31431f0
Reports root/ big
OK: 2540 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 31431f0
Reports root/ big
OK: 4516 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 31431f0
Reports root/ big
OK: 4530 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 81.29% // Head: 83.19% // Increases project coverage by +1.90% 🎉

Coverage data is based on head (31431f0) compared to base (64edde9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3893      +/-   ##
==========================================
+ Coverage   81.29%   83.19%   +1.90%     
==========================================
  Files         535      535              
  Lines       34264    34264              
==========================================
+ Hits        27854    28506     +652     
+ Misses       6410     5758     -652     
Impacted Files Coverage Δ
src/ejabberd.erl 45.00% <0.00%> (-10.00%) ⬇️
src/rdbms/mongoose_rdbms.erl 65.26% <0.00%> (ø)
src/mod_muc_room.erl 78.68% <0.00%> (+0.22%) ⬆️
src/pubsub/mod_pubsub_db_rdbms.erl 95.34% <0.00%> (+0.25%) ⬆️
src/pubsub/mod_pubsub_db_mnesia.erl 92.82% <0.00%> (+0.42%) ⬆️
src/mam/mod_mam_utils.erl 89.93% <0.00%> (+0.91%) ⬆️
src/metrics/mongoose_metrics.erl 92.47% <0.00%> (+1.07%) ⬆️
src/global_distrib/mod_global_distrib_receiver.erl 80.72% <0.00%> (+1.20%) ⬆️
src/inbox/mod_inbox_rdbms_async.erl 73.52% <0.00%> (+1.47%) ⬆️
src/pubsub/node_pep.erl 79.62% <0.00%> (+1.85%) ⬆️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe we could expand on GraphQL? Say something about the new CLI?

@chrzaszcz chrzaszcz merged commit 093154b into master Dec 12, 2022
@chrzaszcz chrzaszcz deleted the mu-reverse-history-order branch December 12, 2022 17:33
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants