Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'egrep' with 'grep -E' #3897

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Replace 'egrep' with 'grep -E' #3897

merged 1 commit into from
Dec 9, 2022

Conversation

chrzaszcz
Copy link
Member

GNU grep 3.8 prints the following warning when you call egrep:

egrep: warning: egrep is obsolescent; using grep -E

That warning would be visible every time you use mongooseimctl - checked on a Linux machine

@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 8, 2022

small_tests_24 / small_tests / 9e9caef
Reports root / small


small_tests_25 / small_tests / 9e9caef
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 9e9caef
Reports root/ big
OK: 4156 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 9e9caef
Reports root/ big
OK: 2202 / Failed: 0 / User-skipped: 823 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 9e9caef
Reports root/ big
OK: 4156 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 9e9caef
Reports root/ big
OK: 2202 / Failed: 0 / User-skipped: 823 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 9e9caef
Reports root/ big
OK: 4130 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 9e9caef
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 9e9caef
Reports root/ big
OK: 2540 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 9e9caef
Reports root/ big
OK: 4530 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 9e9caef
Reports root/ big
OK: 4156 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 9e9caef
Reports root/ big
OK: 2344 / Failed: 0 / User-skipped: 681 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 9e9caef
Reports root/ big
OK: 4516 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 9e9caef
Reports root/ big
OK: 4541 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2676@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2676@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"d4uq3azTWrTMq/l4oAsbwA==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


mssql_mnesia_25 / odbc_mssql_mnesia / 9e9caef
Reports root/ big
OK: 4530 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 83.21% // Head: 83.21% // No change to project coverage 👍

Coverage data is based on head (2afb39b) compared to base (0239653).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           update-npm-for-docs    #3897   +/-   ##
====================================================
  Coverage                83.21%   83.21%           
====================================================
  Files                      535      535           
  Lines                    34269    34269           
====================================================
  Hits                     28516    28516           
  Misses                    5753     5753           
Impacted Files Coverage Δ
src/mongoose_cleaner.erl 60.00% <0.00%> (-10.00%) ⬇️
src/async_pools/mongoose_aggregator_worker.erl 63.33% <0.00%> (-5.01%) ⬇️
src/mam/mod_mam_muc_rdbms_arch_async.erl 82.85% <0.00%> (-2.86%) ⬇️
src/domain/service_domain_db.erl 83.33% <0.00%> (-2.09%) ⬇️
src/pubsub/node_pep.erl 77.77% <0.00%> (-1.86%) ⬇️
src/ejabberd_c2s.erl 88.95% <0.00%> (-0.08%) ⬇️
src/mod_roster.erl 78.89% <0.00%> (+0.23%) ⬆️
src/rdbms/mongoose_rdbms.erl 67.01% <0.00%> (+0.70%) ⬆️
src/auth/ejabberd_auth_ldap.erl 70.21% <0.00%> (+0.70%) ⬆️
src/inbox/mod_inbox_rdbms_async.erl 73.52% <0.00%> (+1.47%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

The latest version of 'egrep' prints the following warning:

egrep: warning: egrep is obsolescent; using grep -E

Also: don't use the '-e' option when not necessary.
@chrzaszcz chrzaszcz changed the base branch from master to update-npm-for-docs December 8, 2022 16:27
@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 8, 2022

small_tests_24 / small_tests / 2afb39b
Reports root / small


small_tests_25 / small_tests / 2afb39b
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 2afb39b
Reports root/ big
OK: 4156 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 2afb39b
Reports root/ big
OK: 2202 / Failed: 0 / User-skipped: 823 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 2afb39b
Reports root/ big
OK: 2202 / Failed: 0 / User-skipped: 823 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 2afb39b
Reports root/ big
OK: 4156 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 2afb39b
Reports root/ big
OK: 4130 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 2afb39b
Reports root/ big
OK: 4156 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 2afb39b
Reports root/ big
OK: 2344 / Failed: 0 / User-skipped: 681 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 2afb39b
Reports root/ big
OK: 4530 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 2afb39b
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 2afb39b
Reports root/ big
OK: 4530 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 2afb39b
Reports root/ big
OK: 2540 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 2afb39b
Reports root/ big
OK: 4516 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 2afb39b
Reports root/ big
OK: 4529 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

smart_markers_SUITE:regular:one2one:marker_after_timestamp_for_threadid_can_be_fetched
{error,
  {{fetch_marker,ok,
     [{times,50,
        {error,
          {badmatch,[]},
          [{smart_markers_SUITE,'-verify_marker_fetch/4-fun-6-',3,
             [{file,
              "/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
            {line,405}]},
           {mongoose_helper,do_wait_until,2,
             [{file,
              "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
            {line,374}]},
           {escalus_story,story,4,
             [{file,
              "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
            {line,72}]},
           {test_server,ts_tc,3,
             [{file,"test_server.erl"},{line,1782}]},
           {test_server,run_test_case_eval1,6,
             [{file,"test_server.erl"},{line,1291}]},
           {test_server,run_test_case_eval,9,
             [{file,"test_server.erl"},{line,1223}]}]}}]},
   [{mongoose_helper,do_wait_until,2,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,371}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


mssql_mnesia_25 / odbc_mssql_mnesia / 2afb39b
Reports root/ big
OK: 4530 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

Base automatically changed from update-npm-for-docs to master December 8, 2022 21:41
Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@arcusfelis
Copy link
Contributor

Still draft?

@chrzaszcz chrzaszcz marked this pull request as ready for review December 9, 2022 07:45
@chrzaszcz
Copy link
Member Author

Still draft?

It was because the target was a branch that got merged. Now it is ready.

@Premwoik Premwoik merged commit d9a5c46 into master Dec 9, 2022
@Premwoik Premwoik deleted the egrep-is-obsolescent branch December 9, 2022 14:13
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants