Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify filter_room_packet #3913

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Conversation

NelsonVides
Copy link
Collaborator

This handler is (in open-source) used only by mod_mam_muc, which only looks at the event_data key, so we can instead pass such event data as the hook params, it is a map that already contains all that is needed.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 2, 2023

small_tests_24 / small_tests / fb2af0d
Reports root / small


small_tests_25 / small_tests / fb2af0d
Reports root / small


riak_mnesia_24 / riak_mnesia / fb2af0d
Reports root/ big
OK: 1168 / Failed: 18 / User-skipped: 357 / Auto-skipped: 1545

graphql_server_SUITE:admin_http:clustering_http_tests:remove_dead_from_cluster_http
{error,{{badrpc,nodedown},
    [{distributed_helper,rpc,
               [#{node => mongooseim3@localhost,
                timeout => 60000},
                mongoose_cluster,join,
                [mongooseim@localhost]],
               [{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
                {line,121}]},
     {graphql_server_SUITE,remove_dead_from_cluster_http,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
                {line,247}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

graphql_server_SUITE:admin_http:clustering_http_tests:remove_alive_from_cluster_http
{error,{{badrpc,nodedown},
    [{distributed_helper,rpc,
               [#{node => mongooseim3@localhost,
                timeout => 60000},
                mongoose_cluster,join,
                [mongooseim@localhost]],
               [{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
                {line,121}]},
     {graphql_server_SUITE,remove_alive_from_cluster_http,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
                {line,267}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

graphql_server_SUITE:admin_http:clustering_http_tests:remove_node_test
{error,{{badrpc,nodedown},
    [{distributed_helper,rpc,
               [#{node => mongooseim3@localhost},
                mongoose_config,get_opt,
                [listen]],
               [{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
                {line,121}]},
     {graphql_helper,get_listener_config,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,143}]},
     {graphql_helper,get_listener_port,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,138}]},
     {graphql_helper,build_request,4,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,24}]},
     {graphql_helper,execute,4,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,20}]},
     {graphql_server_SUITE,remove_node_test,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
                {line,210}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]}]}}

Report log

graphql_server_SUITE:admin_http:clustering_http_tests:stop_node_test
{error,{{badrpc,nodedown},
    [{distributed_helper,rpc,
               [#{node => mongooseim3@localhost},
                mongoose_config,get_opt,
                [listen]],
               [{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
                {line,121}]},
     {graphql_helper,get_listener_config,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,143}]},
     {graphql_helper,get_listener_port,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,138}]},
     {graphql_helper,build_request,4,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,24}]},
     {graphql_helper,execute,4,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,20}]},
     {graphql_server_SUITE,stop_node_test,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
                {line,215}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]}]}}

Report log

graphql_server_SUITE:admin_cli:clustering_tests:join_successful
{error,{#{expected_type => ok,
      response_code => {exit_status,3},
      what => invalid_response_code},
    [{graphql_helper,assert_response_code,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,256}]},
     {graphql_helper,get_ok_value,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,239}]},
     {graphql_server_SUITE,join_successful,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
                {line,144}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

graphql_server_SUITE:admin_cli:clustering_tests:leave_successful
{error,{#{expected_type => ok,
      response_code => {exit_status,3},
      what => invalid_response_code},
    [{graphql_helper,assert_response_code,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,256}]},
     {graphql_helper,get_ok_value,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,239}]},
     {graphql_server_SUITE,leave_successful,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
                {line,150}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

graphql_server_SUITE:admin_cli:clustering_tests:join_unsuccessful
{error,{{verify_result,[],
             [{times,20,
                 [{#{node => mongooseim2@localhost},[],true},
                {#{node => mongooseim@localhost},[],true}]}]},
    [{mongoose_helper,do_wait_until,2,
              [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
               {line,371}]},
     {distributed_helper,verify_result,2,
               [{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
                {line,53}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

graphql_server_SUITE:admin_cli:clustering_tests:leave_but_no_cluster
{error,
  {function_clause,
    [{graphql_helper,get_error,
       [1,
        {{exit_status,3},
         "Failed RPC connection to the node mongooseim@localhost: {'EXIT',\n                             {badarg,\n                              [{persistent_term,\n                              get,\n                              [mongoose_graphql_commands],\n                              [{error_info,\n                                #{module =>\n                                 erl_erts_errors}}]},\n                               {mongoose_graphql_commands,\n                              get_specs,0,\n                              [{file,\n                                \"/home/circleci/project/src/graphql/mongoose_graphql_commands.erl\"},\n                               {line,86}]},\n                               {mongoose_graphql_commands,\n                              find_category,1,\n                              [{file,\n                                \"/home/circleci/project/src/graphql/mongoose_graphql_commands.erl\"},\n                               {line,97}]},\n                               {lists,foldl,3,\n                              [{file,\n                                \"lists.erl\"},\n                               {line,1267}]},\n                               {ejabberd_ctl,\n                              process,1,\n                              [{file,\n                                \"/home/circleci/project/src/ejabberd_ctl.erl\"},\n               ...

Report log

graphql_server_SUITE:admin_cli:clustering_tests:join_twice
{error,{#{expected_type => ok,
      response_code => {exit_status,3},
      what => invalid_response_code},
    [{graphql_helper,assert_response_code,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,256}]},
     {graphql_helper,get_ok_value,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,239}]},
     {graphql_server_SUITE,join_twice,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
                {line,165}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

graphql_server_SUITE:admin_cli:clustering_tests:remove_dead_from_cluster
{error,
  {{badrpc,
     {'EXIT',
       {#{cluster_member => mongooseim@localhost,
        reason => set_extra_db_nodes_failed,
        result => {ok,[]}},
        [{mongoose_cluster,set_extra_db_nodes,1,
           [{file,"/home/circleci/project/src/mongoose_cluster.erl"},
          {line,132}]},
         {mongoose_cluster,unsafe_join,2,
           [{file,"/home/circleci/project/src/mongoose_cluster.erl"},
          {line,116}]},
         {mongoose_cluster,with_app_stopped,2,
           [{file,"/home/circleci/project/src/mongoose_cluster.erl"},
          {line,221}]},
         {global,trans,4,[{file,"global.erl"},{line,463}]},
         {mongoose_cluster,join,1,[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim2@localhost,timeout => 60000},
       mongoose_cluster,join,
       [mongooseim@localhost]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,121}]},
    {graphql_server_SUITE,remove_dead_from_cluster,1,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
       {line,175}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

graphql_server_SUITE:admin_cli:clustering_tests:remove_alive_from_cluster
{error,
  {{badrpc,
     {'EXIT',
       {#{cluster_member => mongooseim@localhost,
        reason => set_extra_db_nodes_failed,
        result => {ok,[]}},
        [{mongoose_cluster,set_extra_db_nodes,1,
           [{file,"/home/circleci/project/src/mongoose_cluster.erl"},
          {line,132}]},
         {mongoose_cluster,unsafe_join,2,
           [{file,"/home/circleci/project/src/mongoose_cluster.erl"},
          {line,116}]},
         {mongoose_cluster,with_app_stopped,2,
           [{file,"/home/circleci/project/src/mongoose_cluster.erl"},
          {line,221}]},
         {global,trans,4,[{file,"global.erl"},{line,463}]},
         {mongoose_cluster,join,1,[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim2@localhost,timeout => 60000},
       mongoose_cluster,join,
       [mongooseim@localhost]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,121}]},
    {graphql_server_SUITE,remove_alive_from_cluster,1,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
       {line,198}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

graphql_server_SUITE:admin_cli:clustering_tests:remove_node_test
{error,{#{expected_type => ok,
      response_code => {exit_status,3},
      what => invalid_response_code},
    [{graphql_helper,assert_response_code,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,256}]},
     {graphql_helper,get_ok_value,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,239}]},
     {graphql_server_SUITE,remove_node_test,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
                {line,210}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

graphql_server_SUITE:admin_cli:clustering_tests:stop_node_test
{error,{#{expected_type => ok,
      response_code => {exit_status,3},
      what => invalid_response_code},
    [{graphql_helper,assert_response_code,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,256}]},
     {graphql_helper,get_ok_value,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,239}]},
     {graphql_server_SUITE,stop_node_test,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
                {line,215}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

graphql_server_SUITE:end_per_suite
{error,
  {{badrpc,
     {'EXIT',
       {badarg,
         [{persistent_term,get,
            [{mongoose_config,{modules,<<"localhost">>}}],
            [{error_info,#{module => erl_erts_errors}}]},
          {mongoose_config,get_opt,1,
            [{file,
               "/home/circleci/project/src/config/mongoose_config.erl"},
             {line,118}]},
          {gen_mod,loaded_modules_with_opts,1,[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       gen_mod,loaded_modules_with_opts,
       [<<"localhost">>]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,121}]},
    {dynamic_modules,restore_modules,3,
      [{file,"/home/circleci/project/big_tests/tests/dynamic_modules.erl"},
       {line,50}]},
    {dynamic_modules,'-restore_modules/2-lc$^0/1-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/dynamic_modules.erl"},
       {line,45}]},
    {dynamic_modules,restore_modules,2,
      [{file,"/home/circleci/project/big_tests/tests/dynamic_modules.erl"},
       {line,46}]},
    {graphql_server_SUITE,end_per_suite,1,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
       {line,76}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1380}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

graphql_metric_SUITE:metrics_http:init_per_group
{'EXIT',
  {{badrpc,
     {'EXIT',
       {badarg,
         [{persistent_term,get,
            [{mongoose_config,listen}],
            [{error_info,#{module => erl_erts_errors}}]},
          {mongoose_config,get_opt,1,
            [{file,
               "/home/circleci/project/src/config/mongoose_config.erl"},
             {line,118}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},mongoose_config,get_opt,[listen]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,121}]},
    {graphql_helper,get_listener_config,2,
      [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
       {line,143}]},
    {graphql_helper,get_listener_opts,1,
      [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
       {line,198}]},
    {graphql_helper,init_admin_handler,1,
      [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
       {line,150}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1380}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

graphql_metric_SUITE:metrics_cli:init_per_group
{'EXIT',
  {{badrpc,
     {'EXIT',
       {noproc,{gen_server,call,[admin_schema_ep,get_endpoint_ctx]}}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_graphql_commands,build_specs,
       [admin]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,121}]},
    {graphql_helper,add_specs,1,
      [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
       {line,181}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1380}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

graphql_metric_SUITE:domain_admin_metrics:init_per_group
{'EXIT',
  {{badrpc,
     {'EXIT',
       {badarg,
         [{ets,lookup,
            [mongoose_wpool,{rdbms,<<"localhost">>,default}],
            [{error_info,
               #{cause => id,module => erl_stdlib_errors}}]},
          {mongoose_wpool,get_pool,3,
            [{file,
               "/home/circleci/project/src/wpool/mongoose_wpool.erl"},
             {line,394}]},
          {mongoose_wpool,call,4,
            [{file,
               "/home/circleci/project/src/wpool/mongoose_wpool.erl"},
             {line,258}]},
          {mongoose_rdbms,sql_transaction,2,[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_rdbms,sql_transaction,
       [<<"localhost">>,fun erlang:yield/0]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,121}]},
    {mongoose_helper,is_rdbms_enabled,1,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,60}]},
    {graphql_helper,init_domain_admin_handler,2,
      [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
       {line,169}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1380}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

:error_in_suite
{error,'inbox_SUITE:all/0 failed'}

Report log

:error_in_suite
{error,'inbox_extensions_SUITE:all/0 failed'}

Report log

jingle_SUITE:init_per_suite
{'EXIT',
  {{badrpc,
     {'EXIT',
       {#{cluster_member => mongooseim@localhost,
        reason => set_extra_db_nodes_failed,
        result => {ok,[]}},
        [{mongoose_cluster,set_extra_db_nodes,1,
           [{file,"/home/circleci/project/src/mongoose_cluster.erl"},
          {line,132}]},
         {mongoose_cluster,unsafe_join,2,
           [{file,"/home/circleci/project/src/mongoose_cluster.erl"},
          {line,116}]},
         {mongoose_cluster,with_app_stopped,2,
           [{file,"/home/circleci/project/src/mongoose_cluster.erl"},
          {line,221}]},
         {global,trans,4,[{file,"global.erl"},{line,463}]},
         {mongoose_cluster,join,1,[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim2@localhost,timeout => 30000},
       mongoose_cluster,join,
       [mongooseim@localhost]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,121}]},
    {distributed_helper,add_node_to_cluster,2,
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,29}]},
    {jingle_SUITE,init_per_suite,1,
      [{file,"/home/circleci/project/big_tests/tests/jingle_SUITE.erl"},
       {line,61}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1380}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

last_SUITE:init_per_suite
{'EXIT',
  {{badrpc,
     {'EXIT',
       {badarg,
         [{persistent_term,get,
            [{mongoose_config,{modules,<<"localhost">>}}],
            [{error_info,#{module => erl_erts_errors}}]},
          {mongoose_config,get_opt,1,
            [{file,
               "/home/circleci/project/src/config/mongoose_config.erl"},
             {line,118}]},
          {gen_mod,loaded_modules_with_opts,1,[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       gen_mod,loaded_modules_with_opts,
       [<<"localhost">>]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,121}]},
    {dynamic_modules,'-save_modules/3-fun-0-',4,
      [{file,"/home/circleci/project/big_tests/tests/dynamic_modules.erl"},
       {line,16}]},
    {lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
    {last_SUITE,init_per_suite,1,
      [{file,"/home/circleci/project/big_tests/tests/last_SUITE.erl"},
       {line,46}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1380}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

login_SUITE:login:init_per_group
{'EXIT',
  {{badrpc,
     {'EXIT',
       {badarg,
         [{persistent_term,get,
            [{mongoose_config,{auth,<<"localhost">>}}],
            [{error_info,#{module => erl_erts_errors}}]},
          {mongoose_config,get_opt,1,
            [{file,
               "/home/circleci/project/src/config/mongoose_config.erl"},
             {line,118}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_config,get_opt,
       [{auth,<<"localhost">>}]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,121}]},
    {mongoose_helper,auth_opts_with_password_format,1,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,481}]},
    {login_SUITE,backup_and_set_options,2,
      [{file,"/home/circleci/project/big_tests/tests/login_SUITE.erl"},
       {line,159}]},
    {login_SUITE,init_per_group,2,
      [{file,"/home/circleci/project/big_tests/tests/login_SUITE.erl"},
       {line,155}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1380}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

login_SUITE:login_digest:init_per_group
{'EXIT',
  {{badrpc,
     {'EXIT',
       {badarg,
         [{persistent_term,get,
            [{mongoose_config,{auth,<<"localhost">>}}],
            [{error_info,#{module => erl_erts_errors}}]},
          {mongoose_config,get_opt,1,
            [{file,
               "/home/circleci/project/src/config/mongoose_config.erl"},
             {line,118}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_config,get_opt,
       [{auth,<<"localhost">>}]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,121}]},
    {mongoose_helper,auth_opts_with_password_format,1,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,481}]},
    {login_SUITE,auth_opts,1,
      [{file,"/home/circleci/project/big_tests/tests/login_SUITE.erl"},
       {line,162}]},
    {login_SUITE,backup_and_set_options,2,
      [{file,"/home/circleci/project/big_tests/tests/login_SUITE.erl"},
       {line,159}]},
    {login_SUITE,init_per_group,2,
      [{file,"/home/circleci/project/big_tests/tests/login_SUITE.erl"},
       {line,114}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1380}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

login_SUITE:login_scram:init_per_group
{'EXIT',
  {{badrpc,
     {'EXIT',
       {badarg,
         [{persistent_term,get,
            [{mongoose_config,{auth,<<"localhost">>}}],
            [{error_info,#{module => erl_erts_errors}}]},
          {mongoose_config,get_opt,1,
            [{file,
               "/home/circleci/project/src/config/mongoose_config.erl"},
             {line,118}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_config,get_opt,
       [{auth,<<"localhost">>}]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,121}]},
    {mongoose_helper,auth_opts_with_password_format,1,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,481}]},
    {login_SUITE,backup_and_set_options,2,
      [{file,"/home/circleci/project/big_tests/tests/login_SUITE.erl"},
       {line,159}]},
    {login_SUITE,init_per_group,2,
      [{file,"/home/circleci/project/big_tests/tests/login_SUITE.erl"},
       {line,125}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1380}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

login_SUITE:login_scram_store_plain:init_per_group
{'EXIT',
  {{badrpc,
     {'EXIT',
       {badarg,
         [{persistent_term,get,
            [{mongoose_config,{auth,<<"localhost">>}}],
            [{error_info,#{module => erl_erts_errors}}]},
          {mongoose_config,get_opt,1,
            [{file,
               "/home/circleci/project/src/config/mongoose_config.erl"},
             {line,118}]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_config,get_opt,
       [{auth,<<"localhost">>}]],
      [{file,
         "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
       {line,121}]},
    {mongoose_helper,auth_opts_with_password_format,1,
      [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
       {line,481}]},
    {login_SUITE,backup_and_set_options,2,
      [{file,"/home/circleci/project/big_tests/tests/login_SUITE.erl"},
       {line,159}]},
    {login_SUITE,init_per_group,2,
      [{file,"/home/circleci/project/big_tests/tests/login_SUITE.erl"},
       {line,125}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1380}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

137 errors were truncated


ldap_mnesia_24 / ldap_mnesia / fb2af0d
Reports root/ big
OK: 2223 / Failed: 0 / User-skipped: 823 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / fb2af0d
Reports root/ big
OK: 4177 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / fb2af0d
Reports root/ big
OK: 4177 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / fb2af0d
Reports root/ big
OK: 4151 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / fb2af0d
Reports root/ big
OK: 2223 / Failed: 0 / User-skipped: 823 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / fb2af0d
Reports root/ big
OK: 4551 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / fb2af0d
Reports root/ big
OK: 4177 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / fb2af0d
Reports root/ big
OK: 2365 / Failed: 0 / User-skipped: 681 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / fb2af0d
Reports root/ big
OK: 2723 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / fb2af0d
Reports root/ big
OK: 4551 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / fb2af0d
Reports root/ big
OK: 4536 / Failed: 1 / User-skipped: 111 / Auto-skipped: 0

graphql_muc_SUITE:user:user_muc_configured:user_without_session_send_message_to_room
{error,
  {function_clause,
    [{graphql_helper,get_error,
       [1,
        {{<<"200">>,<<"OK">>},
         #{<<"data">> =>
           #{<<"muc">> =>
               #{<<"sendMessageToRoom">> =>
                 <<"Message sent successfully">>}}}}],
       []},
     {graphql_helper,get_err_msg,2,
       [{file,
          "/home/circleci/project/big_tests/tests/graphql_helper.erl"},
        {line,227}]},
     {graphql_muc_SUITE,user_without_session_send_message_to_room_story,
       2,
       [{file,
          "/home/circleci/project/big_tests/tests/graphql_muc_SUITE.erl"},
        {line,1276}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {muc_helper,story_with_room,4,
       [{file,"/home/circleci/project/big_tests/tests/muc_helper.erl"},
        {line,303}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log


mssql_mnesia_25 / odbc_mssql_mnesia / fb2af0d
Reports root/ big
OK: 4546 / Failed: 5 / User-skipped: 97 / Auto-skipped: 0

smart_markers_SUITE:regular:one2one:repeated_markers_produce_no_warnings
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_repeated_markers_produce_no_warnings_3179@localhost/res1">>,
          escalus_tcp,<0.9938.3>,
          [{event_manager,<0.9918.3>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_repeated_markers_produce_no_warnings_3179">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.9918.3>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_repeated_markers_produce_no_warnings_3179">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_repeated_markers_produce_no_warnings_3179">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_repeated_markers_produce_no_warnings_3179">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"b56855a8938de21c">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {smart_markers_SUITE,
       '-repeated_markers_produce_no_warnings/1-fun-1-',2,
       [{file,
          "/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
        {...

Report log

smart_markers_SUITE:regular:one2one:marker_after_timestamp_can_be_fetched
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_marker_after_timestamp_can_be_fetched_3176@localhost/res1">>,
          escalus_tcp,<0.9937.3>,
          [{event_manager,<0.9897.3>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_marker_after_timestamp_can_be_fetched_3176">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.9897.3>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_marker_after_timestamp_can_be_fetched_3176">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_marker_after_timestamp_can_be_fetched_3176">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_marker_after_timestamp_can_be_fetched_3176">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"e54ceb433bf6dedd">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {smart_markers_SUITE,
       '-marker_after_timestamp_can_be_fetched/1-fun-0-',2,
       [{file,
          "/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
   ...

Report log

smart_markers_SUITE:regular:one2one:marker_for_thread_can_be_fetched
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_marker_for_thread_can_be_fetched_3175@localhost/res1">>,
          escalus_tcp,<0.9949.3>,
          [{event_manager,<0.9890.3>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_marker_for_thread_can_be_fetched_3175">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.9890.3>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_marker_for_thread_can_be_fetched_3175">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_marker_for_thread_can_be_fetched_3175">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_marker_for_thread_can_be_fetched_3175">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"0e06735f82577e97">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {smart_markers_SUITE,'-marker_for_thread_can_be_fetched/1-fun-0-',2,
       [{file,
          "/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
        {line,209}]},
     {escalus_story...

Report log

smart_markers_SUITE:regular:one2one:marker_after_timestamp_for_threadid_can_be_fetched
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_marker_after_timestamp_for_threadid_can_be_fetched_3177@localhost/res1">>,
          escalus_tcp,<0.9947.3>,
          [{event_manager,<0.9904.3>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_marker_after_timestamp_for_threadid_can_be_fetched_3177">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.9904.3>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_marker_after_timestamp_for_threadid_can_be_fetched_3177">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_marker_after_timestamp_for_threadid_can_be_fetched_3177">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_marker_after_timestamp_for_threadid_can_be_fetched_3177">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"f5810833de185157">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {smart_markers_SUITE,
       '-marker_after_timestamp_for_threadid_can_be_fetched/1-fun-0-',2,
       [{file,
  ...

Report log

smart_markers_SUITE:regular:one2one:remove_markers_when_removed_user
{error,
  {{timeout,true,
     [{times,1,
        {error,
          {badrpc,timeout},
          [{distributed_helper,rpc,
             [#{node => mongooseim@localhost},
            mod_smart_markers_backend,get_chat_markers,
            [<<"localhost">>,
             {jid,
               <<"alice_remove_markers_when_removed_user_3178">>,
               <<"localhost">>,<<"res1">>},
             undefined,0]],
             [{file,
              "/home/circleci/project/big_tests/tests/distributed_helper.erl"},
            {line,121}]},
           {smart_markers_SUITE,fetch_markers_for_users,2,
             [{file,
              "/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
            {line,326}]},
           {smart_markers_SUITE,
             '-remove_markers_when_removed_user/1-fun-0-',2,
             [{file,
              "/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
            {line,244}]},
           {mongoose_helper,do_wait_until,2,
             [{file,
              "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
            {line,374}]},
           {smart_markers_SUITE,
             '-remove_markers_when_removed_user/1-fun-2-',2,
             [{file,
              "/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
            {line,244}]},
           {escalus_story,story,4,
             [{file,
              "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
     ...

Report log


mysql_redis_25 / mysql_redis / fb2af0d
Reports root/ big
OK: 4537 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / fb2af0d
Reports root/ big
OK: 2561 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / fb2af0d
Reports root/ big
OK: 4551 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 83.15% // Head: 83.16% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fb2af0d) compared to base (5523359).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3913   +/-   ##
=======================================
  Coverage   83.15%   83.16%           
=======================================
  Files         535      535           
  Lines       34110    34109    -1     
=======================================
+ Hits        28364    28366    +2     
+ Misses       5746     5743    -3     
Impacted Files Coverage Δ
src/mam/mod_mam_muc.erl 74.88% <ø> (ø)
src/mongoose_hooks.erl 95.42% <100.00%> (-0.02%) ⬇️
src/mongoose_cleaner.erl 60.00% <0.00%> (-10.00%) ⬇️
src/global_distrib/mod_global_distrib_receiver.erl 79.51% <0.00%> (-1.21%) ⬇️
src/domain/mongoose_domain_loader.erl 89.28% <0.00%> (-0.90%) ⬇️
src/mod_muc_room.erl 78.45% <0.00%> (-0.23%) ⬇️
src/mod_roster.erl 79.37% <0.00%> (+0.23%) ⬆️
src/ejabberd_c2s.erl 89.32% <0.00%> (+0.29%) ⬆️
src/rdbms/mongoose_rdbms.erl 67.01% <0.00%> (+0.70%) ⬆️
src/inbox/mod_inbox_rdbms_async.erl 73.52% <0.00%> (+2.94%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pawlooss1 pawlooss1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@pawlooss1 pawlooss1 merged commit f811db6 into master Jan 2, 2023
@pawlooss1 pawlooss1 deleted the hooks/simplify_filter_room_packet branch January 2, 2023 12:09
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants