Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disco test for push notifications #3926

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Conversation

jacekwegr
Copy link
Contributor

Previously, disco was tested only for one type of host; now it's tested for real and virtual hosts.

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 83.15% // Head: 83.15% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7d25220) compared to base (759b64a).
Patch has no changes to coverable lines.

❗ Current head 7d25220 differs from pull request most recent head af62463. Consider uploading reports for the commit af62463 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3926   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files         535      535           
  Lines       34110    34110           
=======================================
+ Hits        28364    28365    +1     
+ Misses       5746     5745    -1     
Impacted Files Coverage Δ
src/mongoose_cleaner.erl 60.00% <0.00%> (-10.00%) ⬇️
src/inbox/mod_inbox_rdbms_async.erl 70.58% <0.00%> (-2.95%) ⬇️
src/mod_bosh_socket.erl 77.95% <0.00%> (-0.63%) ⬇️
src/ejabberd_c2s.erl 88.95% <0.00%> (-0.08%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 73.08% <0.00%> (+0.18%) ⬆️
src/pubsub/mod_pubsub_db_rdbms.erl 95.34% <0.00%> (+0.25%) ⬆️
src/auth/ejabberd_auth.erl 85.27% <0.00%> (+1.52%) ⬆️
src/ejabberd.erl 55.00% <0.00%> (+10.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jacekwegr jacekwegr force-pushed the disco-tests-push-notifications branch from 2f0a0fb to 0c66f7a Compare January 11, 2023 08:24
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr marked this pull request as ready for review January 11, 2023 09:27
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

big_tests/tests/push_integration_SUITE.erl Outdated Show resolved Hide resolved
big_tests/tests/push_integration_SUITE.erl Outdated Show resolved Hide resolved
Previously, disco was tested only for one type of host; now it's tested for real and virtual hosts.
@jacekwegr jacekwegr force-pushed the disco-tests-push-notifications branch from 7d25220 to af62463 Compare January 12, 2023 11:35
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 12, 2023

small_tests_24 / small_tests / af62463
Reports root / small


small_tests_25 / small_tests / af62463
Reports root / small


ldap_mnesia_24 / ldap_mnesia / af62463
Reports root/ big
OK: 2225 / Failed: 0 / User-skipped: 823 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / af62463
Reports root/ big
OK: 4177 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / af62463
Reports root/ big
OK: 4177 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / af62463
Reports root/ big
OK: 2225 / Failed: 0 / User-skipped: 823 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / af62463
Reports root/ big
OK: 4151 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / af62463
Reports root/ big
OK: 4553 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / af62463
Reports root/ big
OK: 2367 / Failed: 0 / User-skipped: 681 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / af62463
Reports root/ big
OK: 4176 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive
{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / af62463
Reports root/ big
OK: 2725 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / af62463
Reports root/ big
OK: 2562 / Failed: 1 / User-skipped: 654 / Auto-skipped: 0

muc_http_api_SUITE:negative:kick_user_errors
{error,{{timeout,ok,[{times,50,not_yet}]},
    [{mongoose_helper,do_wait_until,2,
              [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
               {line,371}]},
     {muc_http_api_SUITE,kick_user_errors,1,
               [{file,"/home/circleci/project/big_tests/tests/muc_http_api_SUITE.erl"},
                {line,325}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log


pgsql_mnesia_25 / pgsql_mnesia / af62463
Reports root/ big
OK: 4553 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / af62463
Reports root/ big
OK: 4539 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / af62463
Reports root/ big
OK: 4553 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / af62463
Reports root/ big
OK: 4177 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / af62463
Reports root/ big
OK: 2563 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

@chrzaszcz chrzaszcz merged commit ef6be9a into master Jan 12, 2023
@chrzaszcz chrzaszcz deleted the disco-tests-push-notifications branch January 12, 2023 15:46
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants