Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C2S/enable jingle tests #3932

Merged
merged 2 commits into from
Jan 16, 2023
Merged

C2S/enable jingle tests #3932

merged 2 commits into from
Jan 16, 2023

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Jan 16, 2023

The goal is to make mod_jingle_sip work, and jingle_SUITE pass with mongoose_c2s.

To do so, nkpacket needs to be updated - see esl/nkpacket#1

@chrzaszcz chrzaszcz changed the base branch from master to feature/mongoose_c2s January 16, 2023 09:57
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 16, 2023

small_tests_24 / small_tests / 2bde522
Reports root / small


small_tests_25 / small_tests / 2bde522
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 2bde522
Reports root/ big
OK: 2141 / Failed: 0 / User-skipped: 803 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 2bde522
Reports root/ big
OK: 4163 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 2bde522
Reports root/ big
OK: 2141 / Failed: 0 / User-skipped: 803 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 2bde522
Reports root/ big
OK: 4163 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 2bde522
Reports root/ big
OK: 4137 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 2bde522
Reports root/ big
OK: 2497 / Failed: 1 / User-skipped: 634 / Auto-skipped: 0

pubsub_SUITE:tree+basic:request_all_items_test
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,491}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,481}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,471}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 2bde522
Reports root/ big
OK: 4163 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 2bde522
Reports root/ big
OK: 2283 / Failed: 0 / User-skipped: 661 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 2bde522
Reports root/ big
OK: 4449 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 2bde522
Reports root/ big
OK: 4449 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 2bde522
Reports root/ big
OK: 4435 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 80.43% // Head: 82.11% // Increases project coverage by +1.68% 🎉

Coverage data is based on head (89f2b85) compared to base (7f34b4c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/mongoose_c2s    #3932      +/-   ##
========================================================
+ Coverage                 80.43%   82.11%   +1.68%     
========================================================
  Files                       540      540              
  Lines                     34198    34198              
========================================================
+ Hits                      27507    28082     +575     
+ Misses                     6691     6116     -575     
Impacted Files Coverage Δ
src/event_pusher/mod_event_pusher_sns.erl 82.19% <0.00%> (-15.07%) ⬇️
src/domain/service_domain_db.erl 83.33% <0.00%> (-2.09%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 67.28% <0.00%> (+0.24%) ⬆️
src/stream_management/mod_stream_management.erl 89.55% <0.00%> (+1.19%) ⬆️
src/pubsub/node_pep.erl 75.92% <0.00%> (+1.85%) ⬆️
src/ejabberd.erl 55.00% <0.00%> (+10.00%) ⬆️
src/jingle_sip/jingle_sip_helper.erl 70.58% <0.00%> (+70.58%) ⬆️
src/jingle_sip/jingle_to_sdp.erl 76.40% <0.00%> (+76.40%) ⬆️
src/jingle_sip/mod_jingle_sip.erl 80.07% <0.00%> (+78.90%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 16, 2023

small_tests_24 / small_tests / 89f2b85
Reports root / small


small_tests_25 / small_tests / 89f2b85
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 89f2b85
Reports root/ big
OK: 2141 / Failed: 0 / User-skipped: 803 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 89f2b85
Reports root/ big
OK: 2141 / Failed: 0 / User-skipped: 803 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 89f2b85
Reports root/ big
OK: 4163 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 89f2b85
Reports root/ big
OK: 4163 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 89f2b85
Reports root/ big
OK: 4137 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 89f2b85
Reports root/ big
OK: 4162 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

graphql_last_SUITE:user:user_last:user_get_other_user_last
{error,{{badmatch,null},
    [{graphql_last_SUITE,user_get_other_user_last_story,3,
               [{file,"/home/circleci/project/big_tests/tests/graphql_last_SUITE.erl"},
                {line,544}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log


pgsql_mnesia_24 / pgsql_mnesia / 89f2b85
Reports root/ big
OK: 4449 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 89f2b85
Reports root/ big
OK: 2641 / Failed: 0 / User-skipped: 642 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 89f2b85
Reports root/ big
OK: 2283 / Failed: 0 / User-skipped: 661 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 89f2b85
Reports root/ big
OK: 2479 / Failed: 0 / User-skipped: 634 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 89f2b85
Reports root/ big
OK: 4435 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 89f2b85
Reports root/ big
OK: 4449 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 89f2b85
Reports root/ big
OK: 4449 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 89f2b85
Reports root/ big
OK: 4163 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

@chrzaszcz chrzaszcz marked this pull request as ready for review January 16, 2023 13:00
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👌🏽

@NelsonVides NelsonVides merged commit 1424476 into feature/mongoose_c2s Jan 16, 2023
@NelsonVides NelsonVides deleted the c2s/enable-jingle branch January 16, 2023 13:26
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants