Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing flaky test remove_dead_from_cluster_http #3968

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

JanuszJakubiec
Copy link
Contributor

@JanuszJakubiec JanuszJakubiec commented Feb 20, 2023

Fixing flaky test remove_dead_from_cluster_http.
Removing join_unsuccessful_http test, because it was not testing anything(just receiving ok from GraphQL), and caused problems wit remove_dead_from_cluster_http.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 20, 2023

small_tests_24 / small_tests / 8332528
Reports root / small


small_tests_25 / small_tests / 8332528
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 8332528
Reports root/ big
OK: 2218 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8332528
Reports root/ big
OK: 4168 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 8332528
Reports root/ big
OK: 2218 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 8332528
Reports root/ big
OK: 4142 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8332528
Reports root/ big
OK: 4168 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8332528
Reports root/ big
OK: 4165 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 8332528
Reports root/ big
OK: 4548 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 8332528
Reports root/ big
OK: 2360 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8332528
Reports root/ big
OK: 2720 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 8332528
Reports root/ big
OK: 4548 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 8332528
Reports root/ big
OK: 2558 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 8332528
Reports root/ big
OK: 4545 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 8332528
Reports root/ big
OK: 4534 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 83.54% // Head: 83.54% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8332528) compared to base (25757b1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3968   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files         538      538           
  Lines       34003    34003           
=======================================
+ Hits        28408    28409    +1     
+ Misses       5595     5594    -1     
Impacted Files Coverage Δ
src/pubsub/mod_pubsub_db.erl 57.14% <0.00%> (-28.58%) ⬇️
src/domain/service_domain_db.erl 83.33% <0.00%> (-2.09%) ⬇️
src/pubsub/mod_pubsub_db_mnesia.erl 92.40% <0.00%> (-1.27%) ⬇️
src/ejabberd_s2s_out.erl 62.53% <0.00%> (-0.75%) ⬇️
src/rdbms/mongoose_rdbms.erl 66.31% <0.00%> (-0.71%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 73.48% <0.00%> (ø)
src/inbox/mod_inbox_rdbms_async.erl 72.05% <0.00%> (ø)
src/pubsub/mod_pubsub_db_rdbms.erl 95.34% <0.00%> (+0.25%) ⬆️
src/domain/mongoose_domain_loader.erl 90.17% <0.00%> (+0.89%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JanuszJakubiec JanuszJakubiec marked this pull request as ready for review February 20, 2023 14:03
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@chrzaszcz chrzaszcz merged commit 094c6ab into master Feb 21, 2023
@chrzaszcz chrzaszcz deleted the remove-dead-from-cluster-test-fix branch February 21, 2023 08:14
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants