Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple things that are wrong with that admin API
Access-Control-Allow-*
headers, also we do not support it for GraphQL nor client REST API.Removing them for now, if we want to add CORS support in the future it must be done properly and for GraphQL and
client REST API as well admin REST API.
Issue can be easily demonstrated with curl, below is the corresponding part of the config:
and here are 2 curl commands:
curl -v --http1.1 --insecure -X OPTIONS https://localhost:8088/api/users/localhost
curl -v --http2 --insecure -X OPTIONS https://localhost:8088/api/users/localhost
Notice that HTTP2 query fails with existing CORS headers.