Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable codecov with the new uploader #4013

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Enable codecov with the new uploader #4013

merged 1 commit into from
Apr 18, 2023

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Apr 17, 2023

The python uploader is now phased out.

The new uploader is a binary executable for x86-64 (amd64), so there is no simple way of running it for arm64. However, the arm64 build for small tests shouldn't affect coverage anyway (the tests are exactly the same as for amd64), so it is just
skipped for now until the uploader supports this arch, see codecov/uploader#523

CODECOV_TOKEN needs to be used now because of a known issue.

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 93.75% and project coverage change: -0.01 ⚠️

Comparison is base (f3ab672) 82.17% compared to head (67dd4b0) 82.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4013      +/-   ##
==========================================
- Coverage   82.17%   82.16%   -0.01%     
==========================================
  Files         535      535              
  Lines       33844    33850       +6     
==========================================
+ Hits        27811    27813       +2     
- Misses       6033     6037       +4     
Impacted Files Coverage Δ
src/rdbms/mongoose_rdbms.erl 68.79% <88.88%> (+2.12%) ⬆️
src/mam/mod_mam_muc_rdbms_arch_async.erl 71.79% <100.00%> (-7.16%) ⬇️
src/mam/mod_mam_rdbms_arch_async.erl 83.67% <100.00%> (+0.34%) ⬆️
src/mongoose_admin_api/mongoose_admin_api.erl 91.37% <100.00%> (-0.43%) ⬇️

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im

This comment was marked as outdated.

@chrzaszcz chrzaszcz changed the title Update codecov Enable codecov with the new uploader Apr 17, 2023
@chrzaszcz chrzaszcz force-pushed the update-codecov branch 2 times, most recently from a4c1da7 to d5027ed Compare April 17, 2023 16:02
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Apr 17, 2023

small_tests_24 / small_tests / d5027ed
Reports root / small


small_tests_25_arm64 / small_tests / d5027ed
Reports root / small


small_tests_25 / small_tests / d5027ed
Reports root / small


ldap_mnesia_24 / ldap_mnesia / d5027ed
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d5027ed
Reports root/ big
OK: 4184 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / d5027ed
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d5027ed
Reports root/ big
OK: 4184 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / d5027ed
Reports root/ big
OK: 4557 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / d5027ed
Reports root/ big
OK: 4158 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / d5027ed
Reports root/ big
OK: 4180 / Failed: 1 / User-skipped: 91 / Auto-skipped: 0

muc_SUITE:register:user_submits_registration_form
{error,
  {{assertion_failed,assert,is_iq_result,
     [{xmlel,<<"iq">>,
        [{<<"type">>,<<"set">>},
         {<<"id">>,<<"14467d5f18241444fd2956c42b2f6dae">>},
         {<<"to">>,<<"groupchats.domain.example.com">>}],
        [{xmlel,<<"query">>,
           [{<<"xmlns">>,<<"jabber:iq:register">>}],
           [{xmlel,<<"x">>,
            [{<<"xmlns">>,<<"jabber:x:data">>},
             {<<"type">>,<<"submit">>}],
            [{xmlel,<<"field">>,
               [{<<"type">>,<<"hidden">>},
                {<<"var">>,<<"FORM_TYPE">>}],
               [{xmlel,<<"value">>,[],
                  [{xmlcdata,<<"jabber:iq:register">>}]}]},
             {xmlel,<<"field">>,
               [{<<"type">>,<<"text-single">>},
                {<<"var">>,<<"nick">>}],
               [{xmlel,<<"value">>,[],
                  [{xmlcdata,
                     <<"thirdwitchroom-62f8a05731">>}]}]}]}]}]}],
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"groupchats.domain.example.com">>},
        {<<"to">>,
         <<"alice_user_submits_registration_form_2520@domain.example.com/res1">>},
        {<<"type">>,<<"error">>},
        {<<"id">>,<<"14467d5f18241444fd2956c42b2f6dae">>}],
       [{xmlel,<<"query">>,
          [{<<"xmlns">>,<<"jabber:iq:register">>}],
          [{xmlel,<<"x">>,
             [{<<"xmlns">>,<<"jabber:x:data">>},
            {<<"type">>,<<"submit">>}],
             [{xmlel,<<"field">>,
              [{<<"type">>,<<"hidden">>},
               {<<"var">>,<<"FORM_TYPE">>}],
      ...

Report log


internal_mnesia_25 / internal_mnesia / d5027ed
Reports root/ big
OK: 2361 / Failed: 0 / User-skipped: 689 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / d5027ed
Reports root/ big
OK: 4557 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / d5027ed
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 668 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / d5027ed
Reports root/ big
OK: 4543 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / d5027ed
Reports root/ big
OK: 4554 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / d5027ed
Reports root/ big
OK: 4181 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

The python uploader is now phased out [1]

The new uploader is a binary executable for x86-64 (amd64),
so there is no simple way of running it for arm64.
However, the arm64 build for small tests shouldn't affect coverage
anyway (the tests are exactly the same as for amd64), so it is just
skipped for now until the uploader supports this arch, see issue [2]

CODECOV_TOKEN needs to be used now because of issue [3]

1. https://docs.codecov.com/docs/deprecated-uploader-migration-guide#python-uploader
2. codecov/uploader#523
3. https://community.codecov.com/t/commit-sha-does-not-match-circle-build/4266
@mongoose-im
Copy link
Collaborator

mongoose-im commented Apr 18, 2023

small_tests_24 / small_tests / 67dd4b0
Reports root / small


small_tests_25_arm64 / small_tests / 67dd4b0
Reports root / small


small_tests_25 / small_tests / 67dd4b0
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 67dd4b0
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 67dd4b0
Reports root/ big
OK: 4184 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 67dd4b0
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 67dd4b0
Reports root/ big
OK: 4184 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 67dd4b0
Reports root/ big
OK: 4158 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 67dd4b0
Reports root/ big
OK: 4557 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 67dd4b0
Reports root/ big
OK: 4181 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 67dd4b0
Reports root/ big
OK: 2361 / Failed: 0 / User-skipped: 689 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 67dd4b0
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 668 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 67dd4b0
Reports root/ big
OK: 4543 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 67dd4b0
Reports root/ big
OK: 4554 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

@chrzaszcz chrzaszcz marked this pull request as ready for review April 18, 2023 07:13
Copy link
Member

@pawlooss1 pawlooss1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for handling this

@pawlooss1 pawlooss1 merged commit ccb3eb4 into master Apr 18, 2023
4 checks passed
@pawlooss1 pawlooss1 deleted the update-codecov branch April 18, 2023 07:26
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants