Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of XEP-0030: Service Discovery #4039

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

jacekwegr
Copy link
Contributor

@jacekwegr jacekwegr commented Jun 15, 2023

This PR changes version of XEP-0016: Privacy Lists from 2.4 to 2.5rc3.

The changes between these versions included clarifications of the existing conditions, fixing some examples, and the removal of the order restriction in the XML schema used to validate XMPP traffic.

These changes did not require any modification of the existing implementation, so only the version number has changed.

https://xmpp.org/extensions/xep-0030.html#appendix-revs

Update version of XEP-0030: Service Discovery from 2.4 to 2.5rc3
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 15, 2023

small_tests_24 / small_tests / adb57cd
Reports root / small


small_tests_25_arm64 / small_tests / adb57cd
Reports root / small


small_tests_25 / small_tests / adb57cd
Reports root / small


ldap_mnesia_24 / ldap_mnesia / adb57cd
Reports root/ big
OK: 2222 / Failed: 0 / User-skipped: 834 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / adb57cd
Reports root/ big
OK: 4194 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / adb57cd
Reports root/ big
OK: 2222 / Failed: 0 / User-skipped: 834 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / adb57cd
Reports root/ big
OK: 4168 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / adb57cd
Reports root/ big
OK: 4194 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / adb57cd
Reports root/ big
OK: 4567 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / adb57cd
Reports root/ big
OK: 4191 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / adb57cd
Reports root/ big
OK: 2728 / Failed: 0 / User-skipped: 667 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / adb57cd
Reports root/ big
OK: 2368 / Failed: 0 / User-skipped: 688 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / adb57cd
Reports root/ big
OK: 4564 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / adb57cd
Reports root/ big
OK: 4567 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / adb57cd
Reports root/ big
OK: 4553 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (a47d5b5) 82.21% compared to head (adb57cd) 82.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4039      +/-   ##
==========================================
- Coverage   82.21%   82.20%   -0.02%     
==========================================
  Files         536      536              
  Lines       33782    33782              
==========================================
- Hits        27774    27769       -5     
- Misses       6008     6013       +5     
Impacted Files Coverage Δ
src/mod_disco.erl 87.50% <ø> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jacekwegr jacekwegr marked this pull request as ready for review June 15, 2023 11:27
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

@chrzaszcz chrzaszcz merged commit 4149087 into master Jun 15, 2023
4 checks passed
@chrzaszcz chrzaszcz deleted the update-service-discovery branch June 15, 2023 11:41
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants