-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating mod_http_upload #4053
Updating mod_http_upload #4053
Conversation
2ab39f0
to
8bde1a2
Compare
8bde1a2
to
8f0bae8
Compare
small_tests_24 / small_tests / 19273a2 small_tests_25 / small_tests / 19273a2 ldap_mnesia_24 / ldap_mnesia / 19273a2 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 19273a2 ldap_mnesia_25 / ldap_mnesia / 19273a2 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 19273a2 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 19273a2 internal_mnesia_25 / internal_mnesia / 19273a2 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 19273a2 pgsql_mnesia_25 / pgsql_mnesia / 19273a2 mysql_redis_25 / mysql_redis / 19273a2 dynamic_domains_mysql_redis_25 / mysql_redis / 19273a2 pgsql_mnesia_24 / pgsql_mnesia / 19273a2 mssql_mnesia_25 / odbc_mssql_mnesia / 19273a2 |
small_tests_24 / small_tests / 2ab39f0 small_tests_25_arm64 / small_tests / 2ab39f0 small_tests_25 / small_tests / 2ab39f0 ldap_mnesia_24 / ldap_mnesia / 2ab39f0 pubsub_SUITE:tree+basic:subscribe_options_separate_request_test{error,{{badmatch,{{<<"pubsub#deliver">>,<<"boolean">>,[]},
<<"pubsub#deliver">>}},
[{pubsub_tools,'-verify_form_values/2-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,606}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{pubsub_SUITE,'-subscribe_options_separate_request_test/1-lc$^1/1-1-',
2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,427}]},
{pubsub_SUITE,'-subscribe_options_separate_request_test/1-fun-2-',2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,429}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 2ab39f0 ldap_mnesia_25 / ldap_mnesia / 2ab39f0 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 2ab39f0 dynamic_domains_mysql_redis_25 / mysql_redis / 2ab39f0 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 2ab39f0 pgsql_mnesia_24 / pgsql_mnesia / 2ab39f0 internal_mnesia_25 / internal_mnesia / 2ab39f0 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 2ab39f0 mysql_redis_25 / mysql_redis / 2ab39f0 pgsql_mnesia_25 / pgsql_mnesia / 2ab39f0 mssql_mnesia_25 / odbc_mssql_mnesia / 2ab39f0 |
small_tests_24 / small_tests / 8bde1a2 small_tests_25_arm64 / small_tests / 8bde1a2 small_tests_25 / small_tests / 8bde1a2 ldap_mnesia_24 / ldap_mnesia / 8bde1a2 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8bde1a2 dynamic_domains_mysql_redis_25 / mysql_redis / 8bde1a2 ldap_mnesia_25 / ldap_mnesia / 8bde1a2 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8bde1a2 pgsql_mnesia_24 / pgsql_mnesia / 8bde1a2 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8bde1a2 internal_mnesia_25 / internal_mnesia / 8bde1a2 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8bde1a2 pgsql_mnesia_25 / pgsql_mnesia / 8bde1a2 mysql_redis_25 / mysql_redis / 8bde1a2 mssql_mnesia_25 / odbc_mssql_mnesia / 8bde1a2 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #4053 +/- ##
=======================================
Coverage 83.83% 83.83%
=======================================
Files 526 526
Lines 33133 33133
=======================================
+ Hits 27776 27778 +2
+ Misses 5357 5355 -2
☔ View full report in Codecov by Sentry. |
small_tests_24 / small_tests / 8f0bae8 small_tests_25 / small_tests / 8f0bae8 small_tests_25_arm64 / small_tests / 8f0bae8 ldap_mnesia_24 / ldap_mnesia / 8f0bae8 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8f0bae8 ldap_mnesia_25 / ldap_mnesia / 8f0bae8 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8f0bae8 dynamic_domains_mysql_redis_25 / mysql_redis / 8f0bae8 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8f0bae8 pgsql_mnesia_24 / pgsql_mnesia / 8f0bae8 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8f0bae8 mysql_redis_25 / mysql_redis / 8f0bae8 internal_mnesia_25 / internal_mnesia / 8f0bae8 pgsql_mnesia_25 / pgsql_mnesia / 8f0bae8 mssql_mnesia_25 / odbc_mssql_mnesia / 8f0bae8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Updating the version of mod_http_upload
Adding the test to ensure, that filenames with unicode characters are supported.