Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating mod_http_upload #4053

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Updating mod_http_upload #4053

merged 1 commit into from
Jul 6, 2023

Conversation

JanuszJakubiec
Copy link
Contributor

Updating the version of mod_http_upload

Adding the test to ensure, that filenames with unicode characters are supported.

@JanuszJakubiec JanuszJakubiec force-pushed the http-upload-update branch 2 times, most recently from 2ab39f0 to 8bde1a2 Compare July 4, 2023 08:26
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 4, 2023

small_tests_24 / small_tests / 19273a2
Reports root / small


small_tests_25 / small_tests / 19273a2
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 19273a2
Reports root/ big
OK: 2250 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 19273a2
Reports root/ big
OK: 4212 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 19273a2
Reports root/ big
OK: 2250 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 19273a2
Reports root/ big
OK: 4212 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 19273a2
Reports root/ big
OK: 4209 / Failed: 0 / User-skipped: 85 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 19273a2
Reports root/ big
OK: 2396 / Failed: 0 / User-skipped: 680 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 19273a2
Reports root/ big
OK: 2756 / Failed: 0 / User-skipped: 659 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 19273a2
Reports root/ big
OK: 4595 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 19273a2
Reports root/ big
OK: 4581 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 19273a2
Reports root/ big
OK: 4186 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 19273a2
Reports root/ big
OK: 4595 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 19273a2
Reports root/ big
OK: 4592 / Failed: 0 / User-skipped: 92 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 4, 2023

small_tests_24 / small_tests / 2ab39f0
Reports root / small


small_tests_25_arm64 / small_tests / 2ab39f0
Reports root / small


small_tests_25 / small_tests / 2ab39f0
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 2ab39f0
Reports root/ big
OK: 2249 / Failed: 1 / User-skipped: 826 / Auto-skipped: 0

pubsub_SUITE:tree+basic:subscribe_options_separate_request_test
{error,{{badmatch,{{<<"pubsub#deliver">>,<<"boolean">>,[]},
           <<"pubsub#deliver">>}},
    [{pubsub_tools,'-verify_form_values/2-fun-0-',2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,606}]},
     {lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
     {pubsub_SUITE,'-subscribe_options_separate_request_test/1-lc$^1/1-1-',
             2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
            {line,427}]},
     {pubsub_SUITE,'-subscribe_options_separate_request_test/1-fun-2-',2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
            {line,429}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 2ab39f0
Reports root/ big
OK: 4212 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 2ab39f0
Reports root/ big
OK: 2250 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 2ab39f0
Reports root/ big
OK: 4212 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 2ab39f0
Reports root/ big
OK: 4186 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 2ab39f0
Reports root/ big
OK: 4209 / Failed: 0 / User-skipped: 85 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 2ab39f0
Reports root/ big
OK: 4595 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 2ab39f0
Reports root/ big
OK: 2396 / Failed: 0 / User-skipped: 680 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 2ab39f0
Reports root/ big
OK: 2756 / Failed: 0 / User-skipped: 659 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 2ab39f0
Reports root/ big
OK: 4581 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 2ab39f0
Reports root/ big
OK: 4595 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 2ab39f0
Reports root/ big
OK: 4592 / Failed: 0 / User-skipped: 92 / Auto-skipped: 0

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 4, 2023

small_tests_24 / small_tests / 8bde1a2
Reports root / small


small_tests_25_arm64 / small_tests / 8bde1a2
Reports root / small


small_tests_25 / small_tests / 8bde1a2
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 8bde1a2
Reports root/ big
OK: 2250 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8bde1a2
Reports root/ big
OK: 4212 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 8bde1a2
Reports root/ big
OK: 4186 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 8bde1a2
Reports root/ big
OK: 2250 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8bde1a2
Reports root/ big
OK: 4212 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 8bde1a2
Reports root/ big
OK: 4595 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8bde1a2
Reports root/ big
OK: 4209 / Failed: 0 / User-skipped: 85 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 8bde1a2
Reports root/ big
OK: 2396 / Failed: 0 / User-skipped: 680 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8bde1a2
Reports root/ big
OK: 2756 / Failed: 0 / User-skipped: 659 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 8bde1a2
Reports root/ big
OK: 4595 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 8bde1a2
Reports root/ big
OK: 4581 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 8bde1a2
Reports root/ big
OK: 4592 / Failed: 0 / User-skipped: 92 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9b6ac71) 83.83% compared to head (8f0bae8) 83.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4053   +/-   ##
=======================================
  Coverage   83.83%   83.83%           
=======================================
  Files         526      526           
  Lines       33133    33133           
=======================================
+ Hits        27776    27778    +2     
+ Misses       5357     5355    -2     
Impacted Files Coverage Δ
src/http_upload/mod_http_upload.erl 97.61% <ø> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 4, 2023

small_tests_24 / small_tests / 8f0bae8
Reports root / small


small_tests_25 / small_tests / 8f0bae8
Reports root / small


small_tests_25_arm64 / small_tests / 8f0bae8
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 8f0bae8
Reports root/ big
OK: 2250 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8f0bae8
Reports root/ big
OK: 4212 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 8f0bae8
Reports root/ big
OK: 2250 / Failed: 0 / User-skipped: 826 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8f0bae8
Reports root/ big
OK: 4212 / Failed: 0 / User-skipped: 82 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 8f0bae8
Reports root/ big
OK: 4186 / Failed: 0 / User-skipped: 108 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8f0bae8
Reports root/ big
OK: 4209 / Failed: 0 / User-skipped: 85 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 8f0bae8
Reports root/ big
OK: 4595 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8f0bae8
Reports root/ big
OK: 2756 / Failed: 0 / User-skipped: 659 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 8f0bae8
Reports root/ big
OK: 4581 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 8f0bae8
Reports root/ big
OK: 2396 / Failed: 0 / User-skipped: 680 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 8f0bae8
Reports root/ big
OK: 4595 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 8f0bae8
Reports root/ big
OK: 4592 / Failed: 0 / User-skipped: 92 / Auto-skipped: 0

@JanuszJakubiec JanuszJakubiec marked this pull request as ready for review July 4, 2023 08:54
@pawlooss1 pawlooss1 self-requested a review July 6, 2023 09:13
Copy link
Member

@pawlooss1 pawlooss1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@pawlooss1 pawlooss1 merged commit 563f592 into master Jul 6, 2023
4 checks passed
@pawlooss1 pawlooss1 deleted the http-upload-update branch July 6, 2023 10:05
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants