Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for the correct number of stanzas in mongooseimctl_SUITE roster tests #4098

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Aug 13, 2023

This PR addresses "Slowest tests in insights" MIM-2002.

Proposed changes include:

  • Fixes unneeded wait_for_stanzas (which would block for 5 seconds).
  • It is particular painful, because these tests are not parallel.
  • ctl commands are still painfully slow on its own (300ms to load VM just to make RPC), but would not be addressed here.
  • Tests should be faster by around 35 seconds (skips 7 calls, that block for 5000 milliseconds).

Before:
before

After:
after

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 13, 2023

small_tests_24 / small_tests / b92b56b
Reports root / small


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b92b56b
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_25 / small_tests / b92b56b
Reports root / small


small_tests_25_arm64 / small_tests / b92b56b
Reports root / small


ldap_mnesia_24 / ldap_mnesia / b92b56b
Reports root/ big
OK: 2270 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b92b56b
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0

mam_SUITE:rdbms_async_pool_muc_all:muc06:muc_message_with_stanzaid
{failed,
  {mam_SUITE,end_per_testcase,
    {'EXIT',
      {{room_archive_size,0,[{times,200,1}],ok},
       [{mongoose_helper,do_wait_until,2,
          [{file,
             "/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
           {line,358}]},
        {mam_helper,wait_for_room_archive_size,3,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,789}]},
        {mam_helper,clean_room_archive,1,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,733}]},
        {mam_helper,destroy_room,1,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_helper.erl"},
           {line,726}]},
        {mam_SUITE,end_per_testcase,2,
          [{file,
             "/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
           {line,954}]},
        {test_server,do_end_per_testcase,4,
          [{file,"test_server.erl"},{line,1627}]},
        {test_server,run_test_case_eval1,6,
          [{file,"test_server.erl"},{line,1335}]},
        {test_server,run_test_case_eval,9,
          [{file,"test_server.erl"},{line,1224}]}]}}}}

Report log


ldap_mnesia_25 / ldap_mnesia / b92b56b
Reports root/ big
OK: 2270 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / b92b56b
Reports root/ big
OK: 4201 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b92b56b
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / b92b56b
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / b92b56b
Reports root/ big
OK: 2416 / Failed: 0 / User-skipped: 685 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b92b56b
Reports root/ big
OK: 4230 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0

muc_light_http_api_SUITE:end_per_suite
{error,
 {{unregistering_failed,
   {amount,1},
   {unregistered_items,
  [{{<<"_invite_to_room_errors_2559">>,
     [{escalus_event_mgr,<0.917.2>},
    {tc_name,invite_to_room_errors},
    {escalus_cleaner,<0.916.2>},
    {watchdog,<0.915.2>},
    {preset,"odbc_mssql_mnesia"},
    {mim_data_dir,
     "/home/circleci/project/big_tests/tests/muc_light_http_api_SUITE_data"},
    {tc_logfile,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4098/187176/odbc_mssql_mnesia.25.3-amd64/big/ct_run.test%40f1bece9a68be.2023-08-13_14.44.10/big_tests.tests.muc_light_http_api_SUITE.logs/run.2023-08-13_14.56.30/muc_light_http_api_suite.invite_to_room_errors.38917.html"},
    {tc_group_properties,[{name,negative},parallel]},
    {tc_group_path,[]},
    {data_dir,
     "/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/muc_light_http_api_SUITE_data/"},
    {priv_dir,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4098/187176/odbc_mssql_mnesia.25.3-amd64/big/ct_run.test%40f1bece9a68be.2023-08-13_14.44.10/big_tests.tests.muc_light_http_api_SUITE.logs/run.2023-08-13_14.56.30/log_private/"},
    {{saved_modules,mongooseim@localhost,<<"test type">>},
     #{mod_adhoc => #{iqdisc => one_queue,report_commands_node => false},
       mod_amp => #{},
       mod_bosh =>
      #{backend => mnesia,inactivity => 30,max_pause => 120,
        max_wait => infinity,server_acks => false},
       mod_cache_users =>
      #{number_of_segments => 5,strategy => fifo,time_to_live => 2},
       mod_carboncopy => #{iqdisc => no_queue},
       mod_disco =>
      #{extra_domains => [],iqd...

Report log


mysql_redis_25 / mysql_redis / b92b56b
Reports root/ big
OK: 4598 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


pgsql_cets_25 / pgsql_cets / b92b56b
Reports root/ big
OK: 4588 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / b92b56b
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / b92b56b
Reports root/ big
OK: 4615 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (4704292) 83.84% compared to head (b92b56b) 83.87%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4098      +/-   ##
==========================================
+ Coverage   83.84%   83.87%   +0.02%     
==========================================
  Files         551      551              
  Lines       33557    33557              
==========================================
+ Hits        28135    28145      +10     
+ Misses       5422     5412      -10     

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arcusfelis arcusfelis marked this pull request as ready for review August 13, 2023 15:41
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👌🏽

@NelsonVides NelsonVides merged commit b035623 into master Aug 14, 2023
4 checks passed
@NelsonVides NelsonVides deleted the fix-slow-mongooseimctl-tests branch August 14, 2023 06:28
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants