Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for when a bad resource is provided #4107

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

NelsonVides
Copy link
Collaborator

Simply increasing test coverage for a case that wasn't covered: https://app.codecov.io/gh/esl/MongooseIM/blob/master/src%2Fc2s%2Fmongoose_c2s.erl#L469

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 22, 2023

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / d7a88d7
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_24 / small_tests / d7a88d7
Reports root / small


small_tests_25 / small_tests / d7a88d7
Reports root / small


small_tests_25_arm64 / small_tests / d7a88d7
Reports root / small


ldap_mnesia_24 / ldap_mnesia / d7a88d7
Reports root/ big
OK: 2275 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / d7a88d7
Reports root/ big
OK: 4202 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d7a88d7
Reports root/ big
OK: 4234 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / d7a88d7
Reports root/ big
OK: 2274 / Failed: 1 / User-skipped: 831 / Auto-skipped: 0

pubsub_SUITE:tree+basic:create_delete_node_test
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,444}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,434}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,424}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d7a88d7
Reports root/ big
OK: 4234 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / d7a88d7
Reports root/ big
OK: 4231 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / d7a88d7
Reports root/ big
OK: 2421 / Failed: 0 / User-skipped: 685 / Auto-skipped: 0


pgsql_cets_25 / pgsql_cets / d7a88d7
Reports root/ big
OK: 4593 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / d7a88d7
Reports root/ big
OK: 4603 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / d7a88d7
Reports root/ big
OK: 4623 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / d7a88d7
Reports root/ big
OK: 4620 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / d7a88d7
Reports root/ big
OK: 4623 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / d7a88d7
Reports root/ big
OK: 2275 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (162df78) 83.93% compared to head (d7a88d7) 83.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4107   +/-   ##
=======================================
  Coverage   83.93%   83.93%           
=======================================
  Files         551      551           
  Lines       33589    33589           
=======================================
+ Hits        28192    28193    +1     
+ Misses       5397     5396    -1     

see 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NelsonVides NelsonVides marked this pull request as ready for review August 22, 2023 16:58
Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@arcusfelis arcusfelis merged commit 3e5d8a2 into master Aug 22, 2023
4 checks passed
@arcusfelis arcusfelis deleted the c2s/add_bad_resource_test branch August 22, 2023 17:21
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants