Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean jid make bare and includes #4109

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

NelsonVides
Copy link
Collaborator

@NelsonVides NelsonVides commented Aug 24, 2023

Mostly use make_bare when appropriate to skip prepping an empty binary. Not a big difference but heh, saves a cpu cycle or two :)

@mongoose-im
Copy link
Collaborator

mongoose-im commented Aug 24, 2023

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 30d9e05
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_24 / small_tests / 30d9e05
Reports root / small


small_tests_25 / small_tests / 30d9e05
Reports root / small


small_tests_25_arm64 / small_tests / 30d9e05
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 30d9e05
Reports root/ big
OK: 2275 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 30d9e05
Reports root/ big
OK: 4202 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 30d9e05
Reports root/ big
OK: 2275 / Failed: 0 / User-skipped: 831 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 30d9e05
Reports root/ big
OK: 4234 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0


pgsql_cets_25 / pgsql_cets / 30d9e05
Reports root/ big
OK: 4593 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 30d9e05
Reports root/ big
OK: 4231 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 30d9e05
Reports root/ big
OK: 4234 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 30d9e05
Reports root/ big
OK: 2421 / Failed: 0 / User-skipped: 685 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 30d9e05
Reports root/ big
OK: 4603 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 30d9e05
Reports root/ big
OK: 4623 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 30d9e05
Reports root/ big
OK: 4623 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 30d9e05
Reports root/ big
OK: 4620 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 92.50% and project coverage change: -0.03% ⚠️

Comparison is base (0133bc9) 83.92% compared to head (30d9e05) 83.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4109      +/-   ##
==========================================
- Coverage   83.92%   83.89%   -0.03%     
==========================================
  Files         551      551              
  Lines       33596    33596              
==========================================
- Hits        28195    28187       -8     
- Misses       5401     5409       +8     
Files Changed Coverage Δ
src/ejabberd_commands.erl 28.37% <0.00%> (ø)
src/ejabberd_sm.erl 88.44% <0.00%> (-0.37%) ⬇️
src/mod_muc_room.erl 78.84% <ø> (-0.12%) ⬇️
src/offline/mod_offline_chatmarkers.erl 93.10% <0.00%> (ø)
src/pubsub/mod_pubsub.erl 75.82% <ø> (ø)
src/admin_extra/service_admin_extra_private.erl 66.66% <100.00%> (ø)
src/admin_extra/service_admin_extra_roster.erl 87.91% <100.00%> (ø)
src/admin_extra/service_admin_extra_sessions.erl 97.05% <100.00%> (ø)
src/admin_extra/service_admin_extra_vcard.erl 93.93% <100.00%> (ø)
src/auth/ejabberd_auth.erl 84.31% <100.00%> (ø)
... and 12 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NelsonVides NelsonVides marked this pull request as ready for review August 24, 2023 12:55
@arcusfelis arcusfelis merged commit 2a85ea0 into master Aug 24, 2023
4 checks passed
@arcusfelis arcusfelis deleted the clean_jid_make_bare_and_includes branch August 24, 2023 14:55
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants