Unify auth_module and info #4110
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4110 +/- ##
==========================================
+ Coverage 83.69% 83.90% +0.21%
==========================================
Files 551 551
Lines 33596 33596
==========================================
+ Hits 28118 28190 +72
+ Misses 5478 5406 -72
☔ View full report in Codecov by Sentry. |
|
elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 1fc212f small_tests_24 / small_tests / 1fc212f small_tests_25 / small_tests / 1fc212f small_tests_25_arm64 / small_tests / 1fc212f ldap_mnesia_24 / ldap_mnesia / 1fc212f ldap_mnesia_25 / ldap_mnesia / 1fc212f dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 1fc212f dynamic_domains_mysql_redis_25 / mysql_redis / 1fc212f dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 1fc212f muc_SUITE:register:user_submits_registration_form_twice{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"c54c0dee5f4c9461d2f9aeab5314b0cb">>},
{<<"to">>,<<"groupchats.domain.example.com">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitchroom-e0cb49207b">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"groupchats.domain.example.com">>},
{<<"to">>,
<<"alice_user_submits_registration_form_twice_2569@domain.example.com/res1">>},
{<<"type">>,<<"error">>},
{<<"id">>,<<"c54c0dee5f4c9461d2f9aeab5314b0cb">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
...internal_mnesia_25 / internal_mnesia / 1fc212f dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 1fc212f pgsql_cets_25 / pgsql_cets / 1fc212f mysql_redis_25 / mysql_redis / 1fc212f pgsql_mnesia_24 / pgsql_mnesia / 1fc212f pgsql_mnesia_25 / pgsql_mnesia / 1fc212f mssql_mnesia_25 / odbc_mssql_mnesia / 1fc212f dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 1fc212f muc_SUITE:register:user_changes_nick{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"fde8776e4ba187259d5f507645c01559">>},
{<<"to">>,<<"groupchats.domain.example.com">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitch1room-9347f2a720">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"groupchats.domain.example.com">>},
{<<"to">>,
<<"alice_user_changes_nick_2551@domain.example.com/res1">>},
{<<"type">>,<<"error">>},
{<<"id">>,<<"fde8776e4ba187259d5f507645c01559">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xm...dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 1fc212f |
Just a tiny change, this field is only used in the context of the session info so really we can make the c2s_data record one field smaller.