Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the test-runner process if any of parallel subtasks fail #4115

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

arcusfelis
Copy link
Contributor

This PR addresses "If there is a compilation error, test runner keeps going".

Proposed changes include:

  • Gather a list of pids to wait.
  • Wait for the pids and handle the exit code.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (c140a5b) 83.93% compared to head (bbffef6) 83.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4115      +/-   ##
==========================================
- Coverage   83.93%   83.91%   -0.03%     
==========================================
  Files         552      552              
  Lines       33624    33624              
==========================================
- Hits        28223    28214       -9     
- Misses       5401     5410       +9     

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 4, 2023

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / bbffef6
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_24 / small_tests / bbffef6
Reports root / small


small_tests_25 / small_tests / bbffef6
Reports root / small


small_tests_25_arm64 / small_tests / bbffef6
Reports root / small


ldap_mnesia_24 / ldap_mnesia / bbffef6
Reports root/ big
OK: 2275 / Failed: 0 / User-skipped: 833 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / bbffef6
Reports root/ big
OK: 2275 / Failed: 0 / User-skipped: 833 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / bbffef6
Reports root/ big
OK: 4204 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / bbffef6
Reports root/ big
OK: 4236 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / bbffef6
Reports root/ big
OK: 4236 / Failed: 0 / User-skipped: 84 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / bbffef6
Reports root/ big
OK: 2421 / Failed: 0 / User-skipped: 687 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / bbffef6
Reports root/ big
OK: 4605 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / bbffef6
Reports root/ big
OK: 4233 / Failed: 0 / User-skipped: 87 / Auto-skipped: 0


pgsql_cets_25 / pgsql_cets / bbffef6
Reports root/ big
OK: 4595 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / bbffef6
Reports root/ big
OK: 4625 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / bbffef6
Reports root/ big
OK: 4622 / Failed: 0 / User-skipped: 94 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / bbffef6
Reports root/ big
OK: 4625 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

@arcusfelis arcusfelis marked this pull request as ready for review September 4, 2023 22:58
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally in linux and macos, works 👌🏽

@NelsonVides NelsonVides merged commit a09755a into master Sep 5, 2023
4 checks passed
@NelsonVides NelsonVides deleted the handle-errors-when-test-runner-is-parallel branch September 5, 2023 07:28
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants