Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CETS backend for mod_keystore #4140

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Add CETS backend for mod_keystore #4140

merged 4 commits into from
Oct 9, 2023

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Oct 5, 2023 •
edited

This PR addresses "MIM-2051 mod_keystore needs CETS backend"

Proposed changes include:

@mongoose-im

This comment was marked as outdated.

Sign in to view
@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9bbbbe2) 84.07% compared to head (e2d18e1) 84.07%.
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4140   +/-   ##
=======================================
  Coverage   84.07%   84.07%           
=======================================
  Files         559      560    +1     
  Lines       34038    34057   +19     
=======================================
+ Hits        28617    28635   +18     
- Misses       5421     5422    +1
Files Coverage Δ
src/mod_keystore.erl 90.24% <100.00%> (+0.24%) ⬆️
src/mod_keystore_backend.erl 100.00% <100.00%> (ø)
src/mod_keystore_mnesia.erl 86.66% <100.00%> (+0.95%) ⬆️
src/mod_keystore_cets.erl 93.33% <93.33%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mongoose-im

This comment was marked as outdated.

Sign in to view
@mongoose-im

This comment was marked as outdated.

Sign in to view
@mongoose-im

This comment was marked as outdated.

Sign in to view
@arcusfelis
Add CETS backend for mod_keystore
31e7bde
@arcusfelis
Use a separate table for each HostType in mod_keystore
2ae5835 
Remove CETS table for mod_keystore, once testing is done
Trying to solve this command failing:
./tools/test-runner.sh --skip-small-tests --db redis pgsql --preset pgsql_cets --skip-cover  --skip-stop-nodes oauth graphql_cets
@arcusfelis
Simplify mod_keystore_cets:init_ram_key/1
a0d3e22 
Use cets:insert_new_or_lookup/2
@mongoose-im

This comment was marked as outdated.

Sign in to view
@arcusfelis arcusfelis marked this pull request as ready for review October 6, 2023 16:53
chrzaszcz
chrzaszcz reviewed Oct 9, 2023
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Only minor comments from me.

big_tests/tests/graphql_token_SUITE.erl Outdated Show resolved Hide resolved
rebar.config Outdated Show resolved Hide resolved
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 9, 2023 •
edited

small_tests_26_arm64 / small_tests / e2d18e1
Reports root / small

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / e2d18e1
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

small_tests_25 / small_tests / e2d18e1
Reports root / small

small_tests_26 / small_tests / e2d18e1
Reports root / small

ldap_mnesia_25 / ldap_mnesia / e2d18e1
Reports root/ big
OK: 2303 / Failed: 0 / User-skipped: 865 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / e2d18e1
Reports root/ big
OK: 4268 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

ldap_mnesia_26 / ldap_mnesia / e2d18e1
Reports root/ big
OK: 2303 / Failed: 0 / User-skipped: 865 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / e2d18e1
Reports root/ big
OK: 4268 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / e2d18e1
Reports root/ big
OK: 4657 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0

dynamic_domains_mysql_redis_26 / mysql_redis / e2d18e1
Reports root/ big
OK: 4236 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0

internal_mnesia_26 / internal_mnesia / e2d18e1
Reports root/ big
OK: 2453 / Failed: 0 / User-skipped: 715 / Auto-skipped: 0

pgsql_cets_26 / pgsql_cets / e2d18e1
Reports root/ big
OK: 4655 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / e2d18e1
Reports root/ big
OK: 4265 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0

pgsql_mnesia_26 / pgsql_mnesia / e2d18e1
Reports root/ big
OK: 4657 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0

mysql_redis_26 / mysql_redis / e2d18e1
Reports root/ big
OK: 4637 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0

mssql_mnesia_26 / odbc_mssql_mnesia / e2d18e1
Reports root/ big
OK: 4654 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

chrzaszcz
chrzaszcz approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chrzaszcz chrzaszcz merged commit 6b46e5c into master Oct 9, 2023
4 checks passed
@chrzaszcz chrzaszcz deleted the mod-keystore-for-cets branch October 9, 2023 11:36
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arcusfelis @mongoose-im @chrzaszcz