Use arm docker executor instead of running docker manually #4145
Conversation
chrzaszcz
force-pushed
the
use-arm-docker-executor
branch
from
fa580ca
to
d1a8f9a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4145 +/- ##
==========================================
- Coverage 84.05% 84.02% -0.03%
==========================================
Files 561 561
Lines 34050 34050
==========================================
- Hits 28621 28612 -9
- Misses 5429 5438 +9 ☔ View full report in Codecov by Sentry. |
chrzaszcz
force-pushed
the
use-arm-docker-executor
branch
2 times, most recently
from
20e7c8b
to
26a48ee
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
chrzaszcz
force-pushed
the
use-arm-docker-executor
branch
from
e51966a
to
191c841
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
chrzaszcz
force-pushed
the
use-arm-docker-executor
branch
from
8407bf5
to
ef89c87
Compare
This comment was marked as outdated.
This comment was marked as outdated.
chrzaszcz
force-pushed
the
use-arm-docker-executor
branch
from
ef89c87
to
514bd83
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
chrzaszcz
force-pushed
the
use-arm-docker-executor
branch
from
f16093b
to
0c0d317
Compare
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 0c0d317 small_tests_25 / small_tests / 0c0d317 small_tests_26 / small_tests / 0c0d317 small_tests_26_arm64 / small_tests / 0c0d317 ldap_mnesia_25 / ldap_mnesia / 0c0d317 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 0c0d317 ldap_mnesia_26 / ldap_mnesia / 0c0d317 dynamic_domains_mysql_redis_26 / mysql_redis / 0c0d317 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 0c0d317 internal_mnesia_26 / internal_mnesia / 0c0d317 pgsql_mnesia_25 / pgsql_mnesia / 0c0d317 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 0c0d317 pgsql_cets_26 / pgsql_cets / 0c0d317 mysql_redis_26 / mysql_redis / 0c0d317 mssql_mnesia_26 / odbc_mssql_mnesia / 0c0d317 pgsql_mnesia_26 / pgsql_mnesia / 0c0d317 |
chrzaszcz
force-pushed
the
use-arm-docker-executor
branch
from
0c0d317
to
6e6a7a7
Compare
Previously there were no docker executors for arm, so we had to use the machine ones. Now the same jobs can be reused for both architectures.
The machine executor was apparently able to run x86_64 images as well.
The machine arm executor was able to run the x86_64 code, while the docker one is not.
chrzaszcz
force-pushed
the
use-arm-docker-executor
branch
from
6e6a7a7
to
5c8a61c
Compare
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 5c8a61c small_tests_25 / small_tests / 5c8a61c small_tests_26 / small_tests / 5c8a61c small_tests_26_arm64 / small_tests / 5c8a61c ldap_mnesia_25 / ldap_mnesia / 5c8a61c dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 5c8a61c ldap_mnesia_26 / ldap_mnesia / 5c8a61c dynamic_domains_mysql_redis_26 / mysql_redis / 5c8a61c dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 5c8a61c internal_mnesia_26 / internal_mnesia / 5c8a61c pgsql_cets_26 / pgsql_cets / 5c8a61c pgsql_mnesia_25 / pgsql_mnesia / 5c8a61c dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 5c8a61c mssql_mnesia_26 / odbc_mssql_mnesia / 5c8a61c muc_SUITE:register:user_changes_nick{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"8ce47f21a0f2d278366ab4fa59979328">>},
{<<"to">>,<<"muc.localhost">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitch1room-bf6ef92a13">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"muc.localhost">>},
{<<"to">>,<<"alice_user_changes_nick_2672@localhost/res1">>},
{<<"type">>,<<"error">>},
{<<"id">>,<<"8ce47f21a0f2d278366ab4fa59979328">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"...mysql_redis_26 / mysql_redis / 5c8a61c carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_575@localhost">>},
{<<"to">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_575@localhost/res2">>},
{<<"xmlns">>,<<"jabber:client">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"sent">>,
[{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
[{xmlel,<<"forwarded">>,
[{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_575@localhost/res1">>},
{<<"type">>,<<"chat">>},
{<<"to">>,
<<"bob_dropped_client_doesnt_create_duplicate_carbons_575@localhost/res1">>},
{<<"xmlns">>,<<"jabber:client">>}],
[{xmlel,<<"body">>,[],
[{xmlcdata,
<<"And pious action">>}]}]}]}]}]}]},
[{carboncopy_SUITE,
'-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
[{file,
"/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
{line,189}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_serv...pgsql_mnesia_26 / pgsql_mnesia / 5c8a61c mysql_redis_26 / mysql_redis / 5c8a61c mssql_mnesia_26 / odbc_mssql_mnesia / 5c8a61c |
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / c075882 small_tests_25 / small_tests / c075882 small_tests_26 / small_tests / c075882 small_tests_26_arm64 / small_tests / c075882 ldap_mnesia_25 / ldap_mnesia / c075882 ldap_mnesia_26 / ldap_mnesia / c075882 dynamic_domains_mysql_redis_26 / mysql_redis / c075882 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c075882 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / c075882 pgsql_mnesia_25 / pgsql_mnesia / c075882 internal_mnesia_26 / internal_mnesia / c075882 mysql_redis_26 / mysql_redis / c075882 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / c075882 pgsql_cets_26 / pgsql_cets / c075882 pgsql_mnesia_26 / pgsql_mnesia / c075882 mssql_mnesia_26 / odbc_mssql_mnesia / c075882 |
CircleCI supports Docker Arm executors now, and this PR makes use of them.
Previously there were separate jobs for Arm, because Docker was run manually on a machine executor.
New se can reuse the
build_in_docker,small_tests_in_dockeranddocker_smoke_testjobs.It turned out that the machine Arm executor was capable of running
x86_64code, while the new Docker executor is not, so correct binaries are downloaded now.The next step would be to enable a big test preset for Arm, but we will do it separately.