Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sm_SUITE compilation #4164

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fix sm_SUITE compilation #4164

merged 1 commit into from
Nov 9, 2023

Conversation

arcusfelis
Copy link
Contributor

Fix:

build-tests:    ===> Compiling tests/sm_SUITE.erl failed
build-tests:    tests/sm_SUITE.erl:173:49: function required_modules/3 undefined

(happened because of merging two PRs changing the same file)

@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 9, 2023

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / fa72aa9
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_25 / small_tests / fa72aa9
Reports root / small


small_tests_26 / small_tests / fa72aa9
Reports root / small


small_tests_26_arm64 / small_tests / fa72aa9
Reports root / small


ldap_mnesia_25 / ldap_mnesia / fa72aa9
Reports root/ big
OK: 2310 / Failed: 0 / User-skipped: 865 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / fa72aa9
Reports root/ big
OK: 4275 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / fa72aa9
Reports root/ big
OK: 2310 / Failed: 0 / User-skipped: 865 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / fa72aa9
Reports root/ big
OK: 4243 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / fa72aa9
Reports root/ big
OK: 4275 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / fa72aa9
Reports root/ big
OK: 4272 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / fa72aa9
Reports root/ big
OK: 2460 / Failed: 0 / User-skipped: 715 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / fa72aa9
Reports root/ big
OK: 4662 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / fa72aa9
Reports root/ big
OK: 4664 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / fa72aa9
Reports root/ big
OK: 4644 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / fa72aa9
Reports root/ big
OK: 4664 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / fa72aa9
Reports root/ big
OK: 4661 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0f3cd4) 84.04% compared to head (fa72aa9) 84.06%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4164      +/-   ##
==========================================
+ Coverage   84.04%   84.06%   +0.01%     
==========================================
  Files         564      564              
  Lines       34067    34067              
==========================================
+ Hits        28633    28639       +6     
+ Misses       5434     5428       -6     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arcusfelis arcusfelis marked this pull request as ready for review November 9, 2023 13:38
Copy link
Contributor

@jacekwegr jacekwegr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Thank you for the fix!

@jacekwegr jacekwegr merged commit f9ba894 into master Nov 9, 2023
4 checks passed
@jacekwegr jacekwegr deleted the fix-sm-suite-compilation branch November 9, 2023 14:03
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants