If MAM lookup code crashes, user gets an empty result set instead of an error #4191
Conversation
In case there is an error when querying Currently debugging case when one message in archive is encoded by other format (i.e. expected XML, but gets erlang term)
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4191 +/- ##
==========================================
+ Coverage 84.27% 84.33% +0.06%
==========================================
Files 551 551
Lines 33467 33473 +6
==========================================
+ Hits 28204 28231 +27
+ Misses 5263 5242 -21 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
Move fix into mam_message module
arcusfelis
force-pushed
the
mam-fails-to-decode-message-fix
branch
from
f31d3ee
to
87d01ac
Compare
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 87d01ac small_tests_25 / small_tests / 87d01ac small_tests_26 / small_tests / 87d01ac small_tests_26_arm64 / small_tests / 87d01ac ldap_mnesia_25 / ldap_mnesia / 87d01ac dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 87d01ac ldap_mnesia_26 / ldap_mnesia / 87d01ac dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 87d01ac internal_mnesia_26 / internal_mnesia / 87d01ac pgsql_cets_26 / pgsql_cets / 87d01ac dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 87d01ac pgsql_mnesia_25 / pgsql_mnesia / 87d01ac mysql_redis_26 / mysql_redis / 87d01ac pgsql_mnesia_26 / pgsql_mnesia / 87d01ac mssql_mnesia_26 / odbc_mssql_mnesia / 87d01ac |
| @@ -538,7 +542,8 @@ prefs_cases() -> | |||
| run_set_and_get_prefs_cases]. | |||
|
|
|||
| impl_specific() -> | |||
| [check_user_exist]. | |||
| [check_user_exist, | |||
| pm_failed_to_decode_message_in_database]. | |||
There was a problem hiding this comment.
Why in this group and not in some regular pm one? Just asking 🤔
There was a problem hiding this comment.
cannot be run in parallel. because it changes module config in the middle of the test.
This PR addresses MIM-2101
Proposed changes include: