Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SM features request in MAM for local archives #4194

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

arcusfelis
Copy link
Contributor

This PR addresses "Disco for MAM in more XEP friendly way".

Proposed changes include:

  • handle disco requests for both SM and local hooks.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b29ab06) 84.29% compared to head (dab2b42) 84.28%.
Report is 4 commits behind head on master.

Files Patch % Lines
src/mam/mod_mam_pm.erl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4194      +/-   ##
==========================================
- Coverage   84.29%   84.28%   -0.01%     
==========================================
  Files         551      551              
  Lines       33473    33475       +2     
==========================================
  Hits        28215    28215              
- Misses       5258     5260       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 20, 2023

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / dab2b42
Reports root/ big
OK: 376 / Failed: 0 / User-skipped: 40 / Auto-skipped: 0


small_tests_25 / small_tests / dab2b42
Reports root / small


small_tests_26 / small_tests / dab2b42
Reports root / small


small_tests_26_arm64 / small_tests / dab2b42
Reports root / small


ldap_mnesia_25 / ldap_mnesia / dab2b42
Reports root/ big
OK: 2268 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / dab2b42
Reports root/ big
OK: 4227 / Failed: 0 / User-skipped: 135 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / dab2b42
Reports root/ big
OK: 4260 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / dab2b42
Reports root/ big
OK: 2268 / Failed: 0 / User-skipped: 847 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / dab2b42
Reports root/ big
OK: 4260 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / dab2b42
Reports root/ big
OK: 4257 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / dab2b42
Reports root/ big
OK: 4298 / Failed: 0 / User-skipped: 110 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / dab2b42
Reports root/ big
OK: 4649 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / dab2b42
Reports root/ big
OK: 4628 / Failed: 0 / User-skipped: 130 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / dab2b42
Reports root/ big
OK: 4649 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / dab2b42
Reports root/ big
OK: 4646 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

@arcusfelis arcusfelis marked this pull request as ready for review December 29, 2023 13:10
Copy link
Contributor

@JanuszJakubiec JanuszJakubiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JanuszJakubiec JanuszJakubiec merged commit 112e3a6 into master Dec 29, 2023
3 of 4 checks passed
@JanuszJakubiec JanuszJakubiec deleted the mam-disco-sm-features branch December 29, 2023 13:12
@jacekwegr jacekwegr added this to the 6.2.1 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants