Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CETS: Do not log pause_owner_crashed when the pause owner exits normally #4205

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

arcusfelis
Copy link
Contributor

This PR addresses MIM-2144

Proposed changes include:

  • Do not log pause_owner_crashed when the pause owner exits normally in CETS

Do not log pause_owner_crashed when the pause owner exits normally
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 5, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 26657d7
Reports root/ big
OK: 382 / Failed: 0 / User-skipped: 40 / Auto-skipped: 0


small_tests_25 / small_tests / 26657d7
Reports root / small


small_tests_26 / small_tests / 26657d7
Reports root / small


small_tests_26_arm64 / small_tests / 26657d7
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 26657d7
Reports root/ big
OK: 2275 / Failed: 0 / User-skipped: 856 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 26657d7
Reports root/ big
OK: 4288 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 26657d7
Reports root/ big
OK: 2275 / Failed: 0 / User-skipped: 856 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 26657d7
Reports root/ big
OK: 4255 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 26657d7
Reports root/ big
OK: 4288 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 26657d7
Reports root/ big
OK: 4284 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

graphql_muc_light_SUITE:admin_cli:admin_muc_light:end_per_group
{error,
 {{unregistering_failed,
   {amount,1},
   {unregistered_items,
  [{{<<"_admin_invite_user_1072">>,
     [{escalus_event_mgr,<0.24281.0>},
    {tc_name,admin_invite_user},
    {escalus_cleaner,<0.24280.0>},
    {watchdog,<0.24279.0>},
    {muc_light_host,<<"muclight.domain.example.com">>},
    {secondary_muc_light_host,<<"muclight.domain.example.org">>},
    {protocol,cli},
    {schema_endpoint,admin},
    {{ejabberd_cwd,mongooseim@localhost},
     "/home/circleci/project/_build/mim1/rel/mongooseim"},
    {preset,"odbc_mssql_mnesia"},
    {mim_data_dir,
     "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
    {tc_logfile,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4205/205180/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40c16caa77d862.2024-01-05_15.59.47/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-01-05_16.03.59/graphql_muc_light_suite.admin_invite_user.57218.html"},
    {tc_group_properties,[{name,admin_muc_light}]},
    {tc_group_path,[[{name,admin_cli}]]},
    {data_dir,
     "/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
    {priv_dir,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4205/205180/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40c16caa77d862.2024-01-05_15.59.47/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-01-05_16.03.59/log_private/"},
    {{saved_modules,mongooseim@localhost,<<"test type">>},
     #{mod_vcard =>
      #{matches => 30,
        host => {prefix,<<"vjud.">>},
        search => true,backend => rdbms,iqdisc => parallel},
    ...

Report log

graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:admin_create_room_with_unprepped_id
{error,
  {{badmatch,null},
   [{graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
       {line,1155}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1302}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log


pgsql_cets_26 / pgsql_cets / 26657d7
Reports root/ big
OK: 4262 / Failed: 0 / User-skipped: 177 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 26657d7
Reports root/ big
OK: 2415 / Failed: 0 / User-skipped: 716 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 26657d7
Reports root/ big
OK: 4656 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 26657d7
Reports root/ big
OK: 4677 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 26657d7
Reports root/ big
OK: 4677 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 26657d7
Reports root/ big
OK: 4673 / Failed: 1 / User-skipped: 121 / Auto-skipped: 0

graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:admin_create_room_with_unprepped_id
{error,
  {{badmatch,null},
   [{graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
       {line,1155}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1302}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 26657d7
Reports root/ big
OK: 4285 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

graphql_muc_light_SUITE:admin_http:admin_muc_light:end_per_group
{error,
 {{unregistering_failed,
   {amount,1},
   {unregistered_items,
  [{{<<"_admin_create_room_with_custom_fields_1047">>,
     [{escalus_event_mgr,<0.23610.0>},
    {tc_name,admin_create_room_with_custom_fields},
    {escalus_cleaner,<0.23609.0>},
    {watchdog,<0.23608.0>},
    {muc_light_host,<<"muclight.domain.example.com">>},
    {secondary_muc_light_host,<<"muclight.domain.example.org">>},
    {protocol,http},
    {schema_endpoint,admin},
    {listener_opts,
     #{module => mongoose_graphql_handler,path => "/api/graphql",
       host => "localhost",username => <<"admin">>,
       password => <<"secret">>,sse_idle_timeout => 3600000,
       schema_endpoint => admin}},
    {{ejabberd_cwd,mongooseim@localhost},
     "/home/circleci/project/_build/mim1/rel/mongooseim"},
    {preset,"odbc_mssql_mnesia"},
    {mim_data_dir,
     "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
    {tc_logfile,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4205/205190/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40c4167013f3f7.2024-01-05_16.29.45/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-01-05_16.34.12/graphql_muc_light_suite.admin_create_room_with_custom_fields.html"},
    {tc_group_properties,[{name,admin_muc_light}]},
    {tc_group_path,[[{name,admin_http}]]},
    {data_dir,
     "/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
    {priv_dir,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4205/205190/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40c4167013f3f7.2024-01-05_16.29.45/big...

Report log


mssql_mnesia_26 / odbc_mssql_mnesia / 26657d7
Reports root/ big
OK: 4674 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (882bf45) 84.30% compared to head (26657d7) 84.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4205      +/-   ##
==========================================
+ Coverage   84.30%   84.34%   +0.03%     
==========================================
  Files         549      549              
  Lines       33432    33432              
==========================================
+ Hits        28186    28198      +12     
+ Misses       5246     5234      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arcusfelis arcusfelis marked this pull request as ready for review January 5, 2024 17:19
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit 07a168e into master Jan 8, 2024
4 checks passed
@chrzaszcz chrzaszcz deleted the cets-ignore-pause_owner_crashed-exiting-normally branch January 8, 2024 07:00
@jacekwegr jacekwegr added this to the 6.2.1 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants