Dist blocker #4234
Dist blocker #4234
Conversation
Dist_blocker would block the remote node from reconnecting until we finish the cleaning
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 665c903 small_tests_25 / small_tests / 665c903 small_tests_26_arm64 / small_tests / 665c903 small_tests_26 / small_tests / 665c903 ldap_mnesia_26 / ldap_mnesia / 665c903 ldap_mnesia_25 / ldap_mnesia / 665c903 dynamic_domains_mysql_redis_26 / mysql_redis / 665c903 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 665c903 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 665c903 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 665c903 graphql_muc_light_SUITE:admin_http:admin_muc_light:end_per_group{error,
{{unregistering_failed,
{amount,1},
{unregistered_items,
[{{<<"_admin_create_identified_room_1027">>,
[{escalus_event_mgr,<0.23365.0>},
{tc_name,admin_create_identified_room},
{escalus_cleaner,<0.23364.0>},
{watchdog,<0.23363.0>},
{muc_light_host,<<"muclight.domain.example.com">>},
{secondary_muc_light_host,<<"muclight.domain.example.org">>},
{protocol,http},
{schema_endpoint,admin},
{listener_opts,
#{module => mongoose_graphql_handler,path => "/api/graphql",
host => "localhost",username => <<"admin">>,
password => <<"secret">>,schema_endpoint => admin,
sse_idle_timeout => 3600000}},
{{ejabberd_cwd,mongooseim@localhost},
"/home/circleci/project/_build/mim1/rel/mongooseim"},
{preset,"odbc_mssql_mnesia"},
{mim_data_dir,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
{tc_logfile,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4234/210289/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%4024823fdf8bf3.2024-03-05_12.18.22/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-03-05_12.22.56/graphql_muc_light_suite.admin_create_identified_room.html"},
{tc_group_properties,[{name,admin_muc_light}]},
{tc_group_path,[[{name,admin_http}]]},
{data_dir,
"/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
{priv_dir,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4234/210289/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%4024823fdf8bf3.2024-03-05_12.18.22/big_tests.tests.graphql_muc...pgsql_cets_26 / pgsql_cets / 665c903 internal_mnesia_26 / internal_mnesia / 665c903 pgsql_mnesia_25 / pgsql_mnesia / 665c903 mysql_redis_26 / mysql_redis / 665c903 pgsql_mnesia_26 / pgsql_mnesia / 665c903 mssql_mnesia_26 / odbc_mssql_mnesia / 665c903 graphql_muc_light_SUITE:admin_cli:admin_muc_light:admin_create_room_with_unprepped_id{error,
{#{what => invalid_response_code,expected_type => ok,
response_code => {exit_status,1}},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
{line,1156}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:admin_create_room_with_unprepped_id{error,
{{badmatch,null},
[{graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
{line,1155}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4234 +/- ##
==========================================
+ Coverage 84.00% 84.37% +0.36%
==========================================
Files 552 552
Lines 33531 33534 +3
==========================================
+ Hits 28169 28295 +126
+ Misses 5362 5239 -123 ☔ View full report in Codecov by Sentry. |
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 0777597 small_tests_25 / small_tests / 0777597 small_tests_26 / small_tests / 0777597 small_tests_26_arm64 / small_tests / 0777597 ldap_mnesia_25 / ldap_mnesia / 0777597 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 0777597 dynamic_domains_mysql_redis_26 / mysql_redis / 0777597 ldap_mnesia_26 / ldap_mnesia / 0777597 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 0777597 internal_mnesia_26 / internal_mnesia / 0777597 pgsql_cets_26 / pgsql_cets / 0777597 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 0777597 pgsql_mnesia_25 / pgsql_mnesia / 0777597 pgsql_mnesia_26 / pgsql_mnesia / 0777597 mssql_mnesia_26 / odbc_mssql_mnesia / 0777597 graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:end_per_group{error,
{{unregistering_failed,
{amount,1},
{unregistered_items,
[{{<<"_admin_invite_user_1109">>,
[{escalus_event_mgr,<0.25008.0>},
{tc_name,admin_invite_user},
{escalus_cleaner,<0.25007.0>},
{watchdog,<0.25006.0>},
{muc_light_host,<<"muclight.localhost">>},
{secondary_muc_light_host,<<"muclight.localhost.bis">>},
{protocol,http},
{domain_admin,{<<"admin@localhost">>,<<"f06f1ce2d3731ef6">>}},
{schema_endpoint,domain_admin},
{{ejabberd_cwd,mongooseim@localhost},
"/home/circleci/project/_build/mim1/rel/mongooseim"},
{preset,"odbc_mssql_mnesia"},
{mim_data_dir,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
{tc_logfile,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4234/210309/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%409deb1f3a6359.2024-03-05_12.41.10/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-03-05_12.45.00/graphql_muc_light_suite.admin_invite_user.35715.html"},
{tc_group_properties,[{name,domain_admin_muc_light}]},
{tc_group_path,[[{name,domain_admin}]]},
{data_dir,
"/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
{priv_dir,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4234/210309/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%409deb1f3a6359.2024-03-05_12.41.10/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-03-05_12.45.00/log_private/"},
{{saved_modules,mongooseim@localhost,<<"localhost">>},
#{mod_vcard =>
#{matches => 30,
host => {prefix,<<"vjud....mysql_redis_26 / mysql_redis / 0777597 |
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / db689ba small_tests_25 / small_tests / db689ba small_tests_26 / small_tests / db689ba small_tests_26_arm64 / small_tests / db689ba ldap_mnesia_26 / ldap_mnesia / db689ba dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / db689ba ldap_mnesia_25 / ldap_mnesia / db689ba dynamic_domains_mysql_redis_26 / mysql_redis / db689ba dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / db689ba pgsql_mnesia_25 / pgsql_mnesia / db689ba internal_mnesia_26 / internal_mnesia / db689ba pgsql_cets_26 / pgsql_cets / db689ba dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / db689ba mssql_mnesia_26 / odbc_mssql_mnesia / db689ba mysql_redis_26 / mysql_redis / db689ba pgsql_mnesia_26 / pgsql_mnesia / db689ba |
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 543f761 small_tests_25 / small_tests / 543f761 small_tests_26 / small_tests / 543f761 small_tests_26_arm64 / small_tests / 543f761 ldap_mnesia_25 / ldap_mnesia / 543f761 ldap_mnesia_26 / ldap_mnesia / 543f761 dynamic_domains_mysql_redis_26 / mysql_redis / 543f761 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 543f761 internal_mnesia_26 / internal_mnesia / 543f761 pubsub_SUITE:tree+basic:subscribe_options_separate_request_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 543f761 pgsql_cets_26 / pgsql_cets / 543f761 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 543f761 pgsql_mnesia_25 / pgsql_mnesia / 543f761 mysql_redis_26 / mysql_redis / 543f761 pgsql_mnesia_26 / pgsql_mnesia / 543f761 mssql_mnesia_26 / odbc_mssql_mnesia / 543f761 graphql_muc_light_SUITE:user:user_muc_light:end_per_group{error,
{{unregistering_failed,
{amount,1},
{unregistered_items,
[{{<<"_user_blocking_list_1031">>,
[{escalus_event_mgr,<0.23340.0>},
{tc_name,user_blocking_list},
{escalus_cleaner,<0.23339.0>},
{watchdog,<0.23338.0>},
{muc_light_host,<<"muclight.localhost">>},
{secondary_muc_light_host,<<"muclight.localhost.bis">>},
{schema_endpoint,user},
{{ejabberd_cwd,mongooseim@localhost},
"/home/circleci/project/_build/mim1/rel/mongooseim"},
{preset,"odbc_mssql_mnesia"},
{mim_data_dir,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
{tc_logfile,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4234/210449/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40525790f79d90.2024-03-05_19.53.57/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-03-05_19.58.42/graphql_muc_light_suite.user_blocking_list.29188.html"},
{tc_group_properties,[{name,user_muc_light},parallel]},
{tc_group_path,[[{name,user}]]},
{data_dir,
"/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
{priv_dir,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4234/210449/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40525790f79d90.2024-03-05_19.53.57/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-03-05_19.58.42/log_private/"},
{{saved_modules,mongooseim@localhost,<<"localhost">>},
#{mod_vcard =>
#{matches => 30,
host => {prefix,<<"vjud.">>},
search => true,iqdisc => parallel,backend => rdbms},
mod_roster =>
#{iqdi...graphql_muc_light_SUITE:admin_http:admin_muc_light:end_per_group{error,
{{unregistering_failed,
{amount,2},
{unregistered_items,
[{{<<"_admin_blocking_list_1070">>,
[{escalus_event_mgr,<0.24188.0>},
{tc_name,admin_blocking_list},
{escalus_cleaner,<0.24187.0>},
{watchdog,<0.24186.0>},
{muc_light_host,<<"muclight.localhost">>},
{secondary_muc_light_host,<<"muclight.localhost.bis">>},
{protocol,http},
{schema_endpoint,admin},
{listener_opts,
#{module => mongoose_graphql_handler,path => "/api/graphql",
host => "localhost",username => <<"admin">>,
password => <<"secret">>,sse_idle_timeout => 3600000,
schema_endpoint => admin}},
{{ejabberd_cwd,mongooseim@localhost},
"/home/circleci/project/_build/mim1/rel/mongooseim"},
{preset,"odbc_mssql_mnesia"},
{mim_data_dir,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
{tc_logfile,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4234/210449/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40525790f79d90.2024-03-05_19.53.57/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-03-05_19.58.42/graphql_muc_light_suite.admin_blocking_list.html"},
{tc_group_properties,[{name,admin_muc_light}]},
{tc_group_path,[[{name,admin_http}]]},
{data_dir,
"/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
{priv_dir,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4234/210449/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40525790f79d90.2024-03-05_19.53.57/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-03-05_19.58.42...graphql_muc_light_SUITE:admin_cli:admin_muc_light:admin_create_room_with_unprepped_id{error,
{#{what => invalid_response_code,expected_type => ok,
response_code => {exit_status,1}},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
{line,1156}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:admin_create_room_with_unprepped_id{error,
{{badmatch,null},
[{graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
{line,1155}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:end_per_group{error,
{{unregistering_failed,
{amount,3},
{unregistered_items,
[{{<<"_domain_admin_kick_user_no_permission_1138">>,
[{escalus_event_mgr,<0.25264.0>},
{tc_name,domain_admin_kick_user_no_permission},
{escalus_cleaner,<0.25263.0>},
{watchdog,<0.25262.0>},
{muc_light_host,<<"muclight.localhost">>},
{secondary_muc_light_host,<<"muclight.localhost.bis">>},
{protocol,http},
{domain_admin,{<<"admin@localhost">>,<<"df9b6297725c1597">>}},
{schema_endpoint,domain_admin},
{{ejabberd_cwd,mongooseim@localhost},
"/home/circleci/project/_build/mim1/rel/mongooseim"},
{preset,"odbc_mssql_mnesia"},
{mim_data_dir,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
{tc_logfile,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4234/210449/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40525790f79d90.2024-03-05_19.53.57/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-03-05_19.58.42/graphql_muc_light_suite.domain_admin_kick_user_no_permission.html"},
{tc_group_properties,[{name,domain_admin_muc_light}]},
{tc_group_path,[[{name,domain_admin}]]},
{data_dir,
"/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
{priv_dir,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4234/210449/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40525790f79d90.2024-03-05_19.53.57/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-03-05_19.58.42/log_private/"},
{{saved_modules,mongooseim@localhost,<<"localhost">>},
#{mod_vcard =>
...internal_mnesia_26 / internal_mnesia / 543f761 mssql_mnesia_26 / odbc_mssql_mnesia / 543f761 |
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / c862c8a small_tests_25 / small_tests / c862c8a small_tests_26 / small_tests / c862c8a small_tests_26_arm64 / small_tests / c862c8a ldap_mnesia_25 / ldap_mnesia / c862c8a ldap_mnesia_26 / ldap_mnesia / c862c8a dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c862c8a dynamic_domains_mysql_redis_26 / mysql_redis / c862c8a dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / c862c8a pgsql_cets_26 / pgsql_cets / c862c8a internal_mnesia_26 / internal_mnesia / c862c8a pgsql_mnesia_25 / pgsql_mnesia / c862c8a dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / c862c8a graphql_muc_light_SUITE:admin_cli:admin_muc_light:end_per_group{error,
{{unregistering_failed,
{amount,2},
{unregistered_items,
[{{<<"_admin_invite_user_1074">>,
[{escalus_event_mgr,<0.24294.0>},
{tc_name,admin_invite_user},
{escalus_cleaner,<0.24293.0>},
{watchdog,<0.24292.0>},
{muc_light_host,<<"muclight.domain.example.com">>},
{secondary_muc_light_host,<<"muclight.domain.example.org">>},
{protocol,cli},
{schema_endpoint,admin},
{{ejabberd_cwd,mongooseim@localhost},
"/home/circleci/project/_build/mim1/rel/mongooseim"},
{preset,"odbc_mssql_mnesia"},
{mim_data_dir,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
{tc_logfile,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4234/210713/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%401eb197021f67.2024-03-06_12.05.53/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-03-06_12.10.04/graphql_muc_light_suite.admin_invite_user.50306.html"},
{tc_group_properties,[{name,admin_muc_light}]},
{tc_group_path,[[{name,admin_cli}]]},
{data_dir,
"/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
{priv_dir,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4234/210713/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%401eb197021f67.2024-03-06_12.05.53/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-03-06_12.10.04/log_private/"},
{{saved_modules,mongooseim@localhost,<<"test type">>},
#{mod_vcard =>
#{matches => 30,
host => {prefix,<<"vjud.">>},
search => true,iqdisc => parallel,backend => rdbms},
...graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:admin_create_room_with_unprepped_id{error,
{{badmatch,null},
[{graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
{line,1155}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}pgsql_mnesia_26 / pgsql_mnesia / c862c8a mysql_redis_26 / mysql_redis / c862c8a mssql_mnesia_26 / odbc_mssql_mnesia / c862c8a dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / c862c8a graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:admin_create_room_with_unprepped_id{error,
{{badmatch,null},
[{graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
{line,1155}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / c862c8a |
src/mongoose_cleaner.erl
Outdated
| lock_key => LockKey}), | ||
| %% Wait and retry | ||
| timer:sleep(rand:uniform(1000)), | ||
| cleanup_modules(Node); |
There was a problem hiding this comment.
What if it loops infinitely? The node would never connect, right?
There was a problem hiding this comment.
should not happen, unless other node stuck performing cleaning indefinitely (so, not releasing the lock).
Just giving up does not make sense.
I could retry limited amount of times and do cleaning without any transaction, if I fail to get lock - could make a spike of load from several cleaners running at once, but otherwise should be safe (at least safer than keeping garbage in the tables).
arcusfelis
force-pushed
the
dist-blocker
branch
from
c862c8a
to
79d301a
Compare
Run cleaning anyway if failed to get a lock
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 79d301a small_tests_25 / small_tests / 79d301a small_tests_26 / small_tests / 79d301a small_tests_26_arm64 / small_tests / 79d301a dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 79d301a ldap_mnesia_25 / ldap_mnesia / 79d301a dynamic_domains_mysql_redis_26 / mysql_redis / 79d301a ldap_mnesia_26 / ldap_mnesia / 79d301a dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 79d301a internal_mnesia_26 / internal_mnesia / 79d301a pgsql_mnesia_25 / pgsql_mnesia / 79d301a dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 79d301a graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:admin_create_room_with_unprepped_id{error,
{{badmatch,null},
[{graphql_muc_light_SUITE,admin_create_room_with_unprepped_id,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE.erl"},
{line,1155}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}pgsql_cets_26 / pgsql_cets / 79d301a pgsql_mnesia_26 / pgsql_mnesia / 79d301a mysql_redis_26 / mysql_redis / 79d301a mssql_mnesia_26 / odbc_mssql_mnesia / 79d301a |
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 0c5cdae small_tests_25 / small_tests / 0c5cdae small_tests_26 / small_tests / 0c5cdae small_tests_26_arm64 / small_tests / 0c5cdae ldap_mnesia_25 / ldap_mnesia / 0c5cdae dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 0c5cdae ldap_mnesia_26 / ldap_mnesia / 0c5cdae dynamic_domains_mysql_redis_26 / mysql_redis / 0c5cdae dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 0c5cdae dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 0c5cdae internal_mnesia_26 / internal_mnesia / 0c5cdae pgsql_cets_26 / pgsql_cets / 0c5cdae pgsql_mnesia_25 / pgsql_mnesia / 0c5cdae mssql_mnesia_26 / odbc_mssql_mnesia / 0c5cdae mysql_redis_26 / mysql_redis / 0c5cdae pgsql_mnesia_26 / pgsql_mnesia / 0c5cdae |
Let global:trans do retries, retry outside transaction anyway if getting lock is not possible
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / fd73bb2 small_tests_25 / small_tests / fd73bb2 small_tests_26 / small_tests / fd73bb2 small_tests_26_arm64 / small_tests / fd73bb2 ldap_mnesia_25 / ldap_mnesia / fd73bb2 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / fd73bb2 ldap_mnesia_26 / ldap_mnesia / fd73bb2 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / fd73bb2 internal_mnesia_26 / internal_mnesia / fd73bb2 dynamic_domains_mysql_redis_26 / mysql_redis / fd73bb2 pgsql_cets_26 / pgsql_cets / fd73bb2 pgsql_mnesia_25 / pgsql_mnesia / fd73bb2 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / fd73bb2 mysql_redis_26 / mysql_redis / fd73bb2 pgsql_mnesia_26 / pgsql_mnesia / fd73bb2 mssql_mnesia_26 / odbc_mssql_mnesia / fd73bb2 |
src/mongoose_cleaner.erl
Outdated
| text => <<"mongoose_cleaner failed to get global lock">>, | ||
| lock_key => LockKey}), | ||
| {ok, aborted}; | ||
| ?LOG_ERROR(#{what => cleaner_trans_aborted, |
There was a problem hiding this comment.
Maybe a warning would be better, as with many nodes IMO this is quite likely to happen, and it doesn't have any immediate bad consequences, like lost data, lack of functionality etc.
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 5ff7b15 small_tests_25 / small_tests / 5ff7b15 small_tests_26 / small_tests / 5ff7b15 small_tests_26_arm64 / small_tests / 5ff7b15 ldap_mnesia_25 / ldap_mnesia / 5ff7b15 ldap_mnesia_26 / ldap_mnesia / 5ff7b15 pubsub_SUITE:dag+basic:create_delete_node_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}pubsub_SUITE:dag+basic:create_node_errors_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{pubsub_SUITE,'-create_node_errors_test/1-fun-0-',1,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,329}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 5ff7b15 dynamic_domains_mysql_redis_26 / mysql_redis / 5ff7b15 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 5ff7b15 pgsql_mnesia_25 / pgsql_mnesia / 5ff7b15 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 5ff7b15 graphql_muc_light_SUITE:admin_http:admin_muc_light:end_per_group{error,
{{unregistering_failed,
{amount,1},
{unregistered_items,
[{{<<"_admin_create_identified_room_1038">>,
[{escalus_event_mgr,<0.23509.0>},
{tc_name,admin_create_identified_room},
{escalus_cleaner,<0.23508.0>},
{watchdog,<0.23507.0>},
{muc_light_host,<<"muclight.domain.example.com">>},
{secondary_muc_light_host,<<"muclight.domain.example.org">>},
{protocol,http},
{schema_endpoint,admin},
{listener_opts,
#{module => mongoose_graphql_handler,path => "/api/graphql",
host => "localhost",username => <<"admin">>,
password => <<"secret">>,sse_idle_timeout => 3600000,
schema_endpoint => admin}},
{{ejabberd_cwd,mongooseim@localhost},
"/home/circleci/project/_build/mim1/rel/mongooseim"},
{preset,"odbc_mssql_mnesia"},
{mim_data_dir,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
{tc_logfile,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4234/211647/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%404c93efb416db.2024-03-12_08.49.52/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-03-12_08.54.13/graphql_muc_light_suite.admin_create_identified_room.html"},
{tc_group_properties,[{name,admin_muc_light}]},
{tc_group_path,[[{name,admin_http}]]},
{data_dir,
"/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
{priv_dir,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4234/211647/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%404c93efb416db.2024-03-12_08.49.52/big_tests.tests.graphql_muc...muc_SUITE:register:user_changes_nick{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"c46ea81c7888ef52efc6b3b1c4b69d45">>},
{<<"to">>,<<"groupchats.domain.example.com">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitch1room-dc8bb7ba8b">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"groupchats.domain.example.com">>},
{<<"to">>,
<<"alice_user_changes_nick_2867@domain.example.com/res1">>},
{<<"type">>,<<"error">>},
{<<"id">>,<<"c46ea81c7888ef52efc6b3b1c4b69d45">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xm...internal_mnesia_26 / internal_mnesia / 5ff7b15 pgsql_cets_26 / pgsql_cets / 5ff7b15 pgsql_mnesia_26 / pgsql_mnesia / 5ff7b15 mysql_redis_26 / mysql_redis / 5ff7b15 mssql_mnesia_26 / odbc_mssql_mnesia / 5ff7b15 ldap_mnesia_26 / ldap_mnesia / 5ff7b15 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 5ff7b15 |
This PR addresses "sessionCount is incorrect during upgrades".
Proposed changes include: