Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare log_helper for parallel tests #4243

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Prepare log_helper for parallel tests #4243

merged 2 commits into from
Mar 13, 2024

Conversation

chrzaszcz
Copy link
Member

This PR prepares log_helper for being used in parallel tests.

Logger does adding/removing handlers asynchronously, which leads to race conditions, and some handlers may fail to get registered.

This is why log_helper is now reimplemented with only one log handler, and an ETS table for receiver Pids.

Additionally, ets_helper is added, which is currently used only once, but in feature/instrument it will be used again.

@chrzaszcz
Add a helper for an ETS table with a process
702de86 
The goal is to have common code for all helpers using ETS tables,
which can survive for the entire test suite/group.
@chrzaszcz
Make log_helper reliable in parallel tests
4e94a99 
Unfortunately logger does adding/removing handlers asynchronously,
which leads to race conditions, and some handlers may fail to get
registered.

This is why log_helper is now reimplemented with only one log handler,
and an ETS table for receiver Pids.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 13, 2024 •
edited

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 4e94a99
Reports root/ big
OK: 429 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0

small_tests_25 / small_tests / 4e94a99
Reports root / small

small_tests_26 / small_tests / 4e94a99
Reports root / small

small_tests_26_arm64 / small_tests / 4e94a99
Reports root / small

ldap_mnesia_25 / ldap_mnesia / 4e94a99
Reports root/ big
OK: 2275 / Failed: 0 / User-skipped: 895 / Auto-skipped: 0

ldap_mnesia_26 / ldap_mnesia / 4e94a99
Reports root/ big
OK: 2275 / Failed: 0 / User-skipped: 895 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 4e94a99
Reports root/ big
OK: 4502 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 4e94a99
Reports root/ big
OK: 4502 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

internal_mnesia_26 / internal_mnesia / 4e94a99
Reports root/ big
OK: 2415 / Failed: 0 / User-skipped: 755 / Auto-skipped: 0

pgsql_cets_26 / pgsql_cets / 4e94a99
Reports root/ big
OK: 4425 / Failed: 0 / User-skipped: 178 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 4e94a99
Reports root/ big
OK: 4499 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_mysql_redis_26 / mysql_redis / 4e94a99
Reports root/ big
OK: 4469 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 4e94a99
Reports root/ big
OK: 4891 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0

pgsql_mnesia_26 / pgsql_mnesia / 4e94a99
Reports root/ big
OK: 4891 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0

mysql_redis_26 / mysql_redis / 4e94a99
Reports root/ big
OK: 4853 / Failed: 17 / User-skipped: 139 / Auto-skipped: 0

amp_big_SUITE:offline:offline_failure:notify_deliver_to_online_user_recipient_privacy_test 
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"bOb_notify_deliver_to_online_user_recipient_privacy_test_314">>,
            <<"localhost">>,<<"makrolika">>],
             3000,mongooseim],
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach_1,2,[{file,"lists.erl"},{line,1686}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {escalus_fresh,story,3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,27}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log

amp_big_SUITE:offline:offline_failure:error_deliver_to_online_user_test 
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"bOb_error_deliver_to_online_user_test_338">>,
            <<"localhost">>,<<"makrolika">>],
             3000,mongooseim],
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach_1,2,[{file,"lists.erl"},{line,1686}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {escalus_fresh,story,3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,27}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log

amp_big_SUITE:offline:offline_failure:notify_deliver_to_offline_user_test 
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"bOb_notify_deliver_to_offline_user_test_318">>,
            <<"localhost">>,<<"makrolika">>],
             3000,mongooseim],
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach_1,2,[{file,"lists.erl"},{line,1686}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {amp_big_SUITE,notify_deliver_to_offline_user_test,1,
            [{file,"/home/circleci/project/big_tests/tests/amp_big_SUITE.erl"},
             {line,365}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log

amp_big_SUITE:offline:offline_failure:notify_deliver_to_offline_user_recipient_privacy_test 
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"bOb_notify_deliver_to_offline_user_recipient_privacy_test_323">>,
            <<"localhost">>,<<"makrolika">>],
             3000,mongooseim],
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach_1,2,[{file,"lists.erl"},{line,1686}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {amp_big_SUITE,do_notify_deliver_to_offline_user_recipient_privacy_test,
            1,
            [{file,"/home/circleci/project/big_tests/tests/amp_big_SUITE.erl"},
             {line,408}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log

amp_big_SUITE:offline:offline_failure:error_deliver_to_online_user_test 
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"bOb_error_deliver_to_online_user_test_336">>,
            <<"localhost">>,<<"makrolika">>],
             3000,mongooseim],
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach_1,2,[{file,"lists.erl"},{line,1686}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {escalus_fresh,story,3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,27}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log

amp_big_SUITE:offline:offline_failure:drop_deliver_to_offline_user_test 
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"bOb_drop_deliver_to_offline_user_test_355">>,
            <<"localhost">>,<<"makrolika">>],
             3000,mongooseim],
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach_1,2,[{file,"lists.erl"},{line,1686}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {amp_big_SUITE,drop_deliver_to_offline_user_test,1,
            [{file,"/home/circleci/project/big_tests/tests/amp_big_SUITE.erl"},
             {line,654}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log

amp_big_SUITE:offline:offline_failure:drop_deliver_to_online_user_test 
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"bOb_drop_deliver_to_online_user_test_349">>,
            <<"localhost">>,<<"makrolika">>],
             3000,mongooseim],
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach_1,2,[{file,"lists.erl"},{line,1686}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {escalus_fresh,story,3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,27}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log

amp_big_SUITE:offline:offline_failure:error_deliver_to_offline_user_test 
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"bOb_error_deliver_to_offline_user_test_341">>,
            <<"localhost">>,<<"makrolika">>],
             3000,mongooseim],
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach_1,2,[{file,"lists.erl"},{line,1686}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {amp_big_SUITE,error_deliver_to_offline_user_test,1,
            [{file,"/home/circleci/project/big_tests/tests/amp_big_SUITE.erl"},
             {line,572}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log

amp_big_SUITE:offline:offline_failure:error_deliver_to_online_user_test 
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"bOb_error_deliver_to_online_user_test_340">>,
            <<"localhost">>,<<"makrolika">>],
             3000,mongooseim],
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach_1,2,[{file,"lists.erl"},{line,1686}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {escalus_fresh,story,3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,27}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log

amp_big_SUITE:offline:offline_failure:drop_deliver_to_offline_user_test 
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"bOb_drop_deliver_to_offline_user_test_354">>,
            <<"localhost">>,<<"makrolika">>],
             3000,mongooseim],
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach_1,2,[{file,"lists.erl"},{line,1686}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {amp_big_SUITE,drop_deliver_to_offline_user_test,1,
            [{file,"/home/circleci/project/big_tests/tests/amp_big_SUITE.erl"},
             {line,654}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log

amp_big_SUITE:offline:offline_failure:drop_deliver_to_online_user_test 
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"bOb_drop_deliver_to_online_user_test_350">>,
            <<"localhost">>,<<"makrolika">>],
             3000,mongooseim],
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach_1,2,[{file,"lists.erl"},{line,1686}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {escalus_fresh,story,3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,27}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log

graphql_account_SUITE:admin_account_http:admin_register_user_limit_error 
{error,
  {{badmap,null},
   [{erlang,map_get,
      [<<"message">>,null],
      [{error_info,#{module => erl_erts_errors}}]},
    {graphql_helper,get_value,2,
      [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
       {line,292}]},
    {graphql_account_SUITE,admin_register_user_limit_error,1,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_account_SUITE.erl"},
       {line,385}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1302}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log

graphql_account_SUITE:admin_account_cli:admin_register_user_limit_error 
{error,
  {#{what => invalid_response_code,expected_type => ok,
     response_code => {exit_status,1}},
   [{graphql_helper,assert_response_code,2,
      [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
       {line,256}]},
    {graphql_helper,get_ok_value,2,
      [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
       {line,239}]},
    {graphql_account_SUITE,admin_register_user_limit_error,1,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_account_SUITE.erl"},
       {line,385}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1302}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log

graphql_account_SUITE:domain_admin_account:admin_register_user_limit_error 
{error,
  {{badmap,null},
   [{erlang,map_get,
      [<<"message">>,null],
      [{error_info,#{module => erl_erts_errors}}]},
    {graphql_helper,get_value,2,
      [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
       {line,292}]},
    {graphql_account_SUITE,admin_register_user_limit_error,1,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_account_SUITE.erl"},
       {line,385}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1302}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log

graphql_last_SUITE:admin_http:admin_last_configured:admin_old_users:admin_list_old_users_domain 
{error,{{badmatch,[#{<<"jid">> =>
             <<"alice_drop_deliver_to_offline_user_test_354@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_drop_deliver_to_offline_user_test_355@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_drop_deliver_to_online_user_test_349@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_drop_deliver_to_online_user_test_350@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_error_deliver_to_offline_user_test_341@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_error_deliver_to_online_user_test_336@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_error_deliver_to_online_user_test_338@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_error_deliver_to_online_user_test_340@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_notify_deliver_to_offline_user_recipient_privacy_test_323@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_notify_deliver_to_offline_user_test_318@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_notify_deliver_to_online_user_recipient_privacy_test_...

Report log

graphql_last_SUITE:admin_http:admin_last_configured:admin_old_users:admin_list_old_users_global 
{error,{{badmatch,[#{<<"jid">> => <<"alice@localhost.bis">>,
           <<"timestamp">> => <<"2024-03-13T08:23:41.000000Z">>},
           #{<<"jid">> =>
             <<"alice_drop_deliver_to_offline_user_test_354@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_drop_deliver_to_offline_user_test_355@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_drop_deliver_to_online_user_test_349@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_drop_deliver_to_online_user_test_350@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_error_deliver_to_offline_user_test_341@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_error_deliver_to_online_user_test_336@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_error_deliver_to_online_user_test_338@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_error_deliver_to_online_user_test_340@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_notify_deliver_to_offline_user_recipient_privacy_test_323@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_notify_deliver_to_offline_user_test_318@localhost">>,
           <<"times...

Report log

graphql_last_SUITE:admin_http:admin_last_configured:admin_old_users:admin_remove_old_users_domain 
{error,{{badmatch,[#{<<"jid">> =>
             <<"alice_drop_deliver_to_offline_user_test_354@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_drop_deliver_to_offline_user_test_355@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_drop_deliver_to_online_user_test_349@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_drop_deliver_to_online_user_test_350@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_error_deliver_to_offline_user_test_341@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_error_deliver_to_online_user_test_336@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_error_deliver_to_online_user_test_338@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_error_deliver_to_online_user_test_340@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_notify_deliver_to_offline_user_recipient_privacy_test_323@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_notify_deliver_to_offline_user_test_318@localhost">>,
           <<"timestamp">> => null},
           #{<<"jid">> =>
             <<"alice_notify_deliver_to_online_user_recipient_privacy_test_...

Report log

mssql_mnesia_26 / odbc_mssql_mnesia / 4e94a99
Reports root/ big
OK: 4888 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

mysql_redis_26 / mysql_redis / 4e94a99
Reports root/ big
OK: 4870 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0

@codecov Codecov
Copy link

codecov bot commented Mar 13, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.41%. Comparing base (468b1df) to head (4e94a99).
Report is 10 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4243   +/-   ##
=======================================
  Coverage   84.40%   84.41%           
=======================================
  Files         552      552           
  Lines       33538    33538           
=======================================
+ Hits        28308    28310    +2     
+ Misses       5230     5228    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrzaszcz chrzaszcz marked this pull request as ready for review March 13, 2024 09:29
jacekwegr
jacekwegr approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@jacekwegr jacekwegr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@jacekwegr jacekwegr merged commit 23a4f06 into master Mar 13, 2024
4 checks passed
@jacekwegr jacekwegr deleted the log-helper-parallel branch March 13, 2024 10:26
@jacekwegr jacekwegr added this to the 6.2.1 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacekwegr jacekwegr jacekwegr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrzaszcz @mongoose-im @jacekwegr