Make commit hash in system status fail-safe #4262
Conversation
This hotfix is needed to make the build for the 6.2.1 release pass. The tests were failing only for GH tags, because the commit hash was not available. For now - default to an empty string (as binary, to avoid '[]' output). We could make the field optional in the future to clean this up.
chrzaszcz
force-pushed
the
hotfix-commit-hash
branch
from
8796d69
to
1978e2d
Compare
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 8796d69 small_tests_25 / small_tests / 8796d69 small_tests_26 / small_tests / 8796d69 small_tests_26_arm64 / small_tests / 8796d69 ldap_mnesia_25 / ldap_mnesia / 8796d69 dynamic_domains_mysql_redis_26 / mysql_redis / 8796d69 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8796d69 ldap_mnesia_26 / ldap_mnesia / 8796d69 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 8796d69 internal_mnesia_26 / internal_mnesia / 8796d69 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 8796d69 pgsql_mnesia_25 / pgsql_mnesia / 8796d69 pgsql_cets_26 / pgsql_cets / 8796d69 pgsql_mnesia_26 / pgsql_mnesia / 8796d69 mysql_redis_26 / mysql_redis / 8796d69 mssql_mnesia_26 / odbc_mssql_mnesia / 8796d69 |
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 1978e2d small_tests_25 / small_tests / 1978e2d small_tests_26 / small_tests / 1978e2d small_tests_26_arm64 / small_tests / 1978e2d ldap_mnesia_25 / ldap_mnesia / 1978e2d dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 1978e2d dynamic_domains_mysql_redis_26 / mysql_redis / 1978e2d ldap_mnesia_26 / ldap_mnesia / 1978e2d dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 1978e2d internal_mnesia_26 / internal_mnesia / 1978e2d dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 1978e2d pgsql_cets_26 / pgsql_cets / 1978e2d graphql_SUITE:tls_enabled:tls_connect_admin_unknown_certificate{error,{{assertMatch,[{module,graphql_SUITE},
{line,253},
{expression,"Result"},
{pattern,"{ error , { tls_alert , { unknown_ca , _ } } }"},
{value,{error,connection_closed}}]},
[{graphql_SUITE,tls_connect_admin_unknown_certificate,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_SUITE.erl"},
{line,253}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}pgsql_mnesia_25 / pgsql_mnesia / 1978e2d mysql_redis_26 / mysql_redis / 1978e2d pgsql_mnesia_26 / pgsql_mnesia / 1978e2d mssql_mnesia_26 / odbc_mssql_mnesia / 1978e2d pgsql_cets_26 / pgsql_cets / 1978e2d graphql_roster_SUITE:user_roster:user_decline_subscription_ask{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"bob_user_decline_subscription_ask_1168@localhost/res1">>,
escalus_tcp,<0.26408.0>,
[{event_manager,<0.26406.0>},
{server,<<"localhost">>},
{username,<<"bOb_user_decline_subscription_ask_1168">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.26406.0>},
{server,<<"localhost">>},
{username,
<<"bOb_user_decline_subscription_ask_1168">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_user_decline_subscription_ask_1168">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_user_decline_subscription_ask_1168">>},
{server,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"74d0a9c3fb93771d">>}]},
1],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{graphql_roster_SUITE,user_decline_subscription_ask_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_roster_SUITE.erl"},
{line,524}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_buil...pgsql_cets_26 / pgsql_cets / 1978e2d |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4262 +/- ##
==========================================
+ Coverage 84.40% 84.42% +0.01%
==========================================
Files 552 552
Lines 33551 33554 +3
==========================================
+ Hits 28319 28327 +8
+ Misses 5232 5227 -5 ☔ View full report in Codecov by Sentry. |
This hotfix is needed to make the build for the 6.2.1 release pass. The tests were failing only for GH tags, because the commit hash was not available.
For now - default to an empty string. We could make the field optional in the future to clean this up.
Big tests checked manually with and without the commit hash.