Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use cowboy middleware and cowboy router #64

Closed
wants to merge 1 commit into from

Conversation

l4u
Copy link
Contributor

@l4u l4u commented Feb 4, 2013

Follow the new env tuple standard for cowboy middleware
Fix #62

@erszcz
Copy link
Member

erszcz commented Feb 15, 2013

Something isn't quite right here. On a clean checkout from this branch I get the following server error when running websockets_SUITE:

(ejabberd@localhost)1> 2013-02-15 13:32:53.770 [error] emulator Error in process <0.679.0> on node 'ejabberd@localhost' with exit value: {{badmatch,false},[{cowboy_router,execute,2,[{file,"src/cowboy_router.erl"},{line,171}]},{cowboy_protocol,execute,4,[{file,"src/cowboy_protocol.erl"},{line,500}]}]}

2013-02-15 13:32:53.829 [error] <0.411.0> Supervisor ranch_conns_sup had child ranch_conns_sup started with {ranch_conns_sup,start_protocol,undefined} at <0.679.0> exit with reason no match of right hand value false in cowboy_router:execute/2 line 171 in context child_terminated
2013-02-15 13:32:57.021 [error] emulator Error in process <0.683.0> on node 'ejabberd@localhost' with exit value: {{badmatch,false},[{cowboy_router,execute,2,[{file,"src/cowboy_router.erl"},{line,171}]},{cowboy_protocol,execute,4,[{file,"src/cowboy_protocol.erl"},{line,500}]}]}

2013-02-15 13:32:57.021 [error] <0.411.0> Supervisor ranch_conns_sup had child ranch_conns_sup started with {ranch_conns_sup,start_protocol,undefined} at <0.683.0> exit with reason no match of right hand value false in cowboy_router:execute/2 line 171 in context child_terminated
2013-02-15 13:33:02.026 [error] emulator Error in process <0.693.0> on node 'ejabberd@localhost' with exit value: {{badmatch,false},[{cowboy_router,execute,2,[{file,"src/cowboy_router.erl"},{line,171}]},{cowboy_protocol,execute,4,[{file,"src/cowboy_protocol.erl"},{line,500}]}]}

2013-02-15 13:33:02.026 [error] <0.411.0> Supervisor ranch_conns_sup had child ranch_conns_sup started with {ranch_conns_sup,start_protocol,undefined} at <0.693.0> exit with reason no match of right hand value false in cowboy_router:execute/2 line 171 in context child_terminated

I can't look into it right now, so am leaving the pull request open till the issue gets resolved.

- follow the new env tuple standard for middleware
@l4u
Copy link
Contributor Author

l4u commented Feb 20, 2013

rebased.
Are the errors coming from make cover_test ?

@erszcz
Copy link
Member

erszcz commented Feb 21, 2013

Solved as of 7995f94. Fresh clone with ranch and cowboy fetched by rebar passes websockets_SUITE (after a little configuration tweak or using a fix commited in af9cdff).

@erszcz erszcz closed this Feb 21, 2013
erszcz added a commit that referenced this pull request Aug 7, 2015
NelsonVides pushed a commit that referenced this pull request Jul 23, 2021
FUL-26272: Add Jenkins DB migration support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An error happened while running websocket example with latest version of cowboy
2 participants