Xep 0352 csi #703
Merged
Xep 0352 csi #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -857,13 +859,25 @@ session_established({xmlstreamelement, | |||
| stream_mgmt_handle_ack(session_established, El, StateData); | |||
|
|
|||
| session_established({xmlstreamelement, | |||
| #xmlel{name = <<"r">>} = El}, StateData) -> | |||
| #xmlel{name = <<"r">>} = El}, | |||
| #state{csi_state = active} = StateData) -> | |||
|
Does it make sense to buffer the incoming stanzas as well?
I think that the main problem is that the XEP specifies almost nothing, especially not what should with stanzas sent by the client when it is inactive. |
|
Also, I believe that buffer size should be configurable from the config file. |
|
I've sent a message to xmpp standards mailing list. Here's the thread: http://mail.jabber.org/pipermail/standards/2016-March/031012.html. My personal opinion after re-thinking is that the server should discard the stanza and reply with an error to the client. |
|
Based on the conversation on the standrads mailing list I decided not to buffer incoming stanzas, but pass as usual. |
| @@ -870,6 +870,7 @@ do_open_session_common(JID, #state{user = U, resource = R} = NewStateData0) -> | |||
| privacy_list = PrivList}, | |||
| fsm_next_state_pack(session_established, | |||
| NewStateData). | |||
| -define(xmlel(Name), #xmlel{name = Name}). | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #680
Proposed changes include:
inactiveandactivestatesxep_0352_csi_SUITETODO: