Muc test fix #835
Muc test fix #835
Conversation
| %{mod_muc_log, [ | ||
| %{outdir, "/tmp/muclogs"}, | ||
| %{access_log, muc} | ||
| %]}, |
There was a problem hiding this comment.
I would move those comment characters to the beginning of each line but this is minor issue.
For me the PR is ready to merge
| % {mod_muc_light, [ | ||
| % {host, "muclight.@HOST@"} | ||
| % ]}, | ||
| {mod_muc, [ |
There was a problem hiding this comment.
Do we really want to disable mod_muc by default? I know one can enable it in config file, but most users who just want to try it will probably never touch config file.
There was a problem hiding this comment.
Did XSF obsolete MUC? We can say it's obsolete, I'm fine with it but then we should enable by default mod_muc_light.
There was a problem hiding this comment.
Wouldn't it be simpler to check if these two can peacefully coexist on separate subdomains?
There was a problem hiding this comment.
That's exactly my point.
There was a problem hiding this comment.
The market says MUC is obsolete, the XSF won't say it, or until MIX is widely deployed.
Indeed: MUC, MUC light, and MIX can co-exist.
As it was, if muc_light_legacy_SUITE was run before muc_SUITE then the latter failed. The reason was that muc was loaded statically at startup, and registered itself under muc.localhost in local routing table. muc_light was loaded dynamically, registered itself under the same domain, and then was unloaded.