Apply suggestions from code review

esl · Jul 2, 2020 · 4212e3b · 4212e3b
1 parent 92ef1bb
commit 4212e3b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/guides/docker.md b/guides/docker.md
@@ -49,4 +49,4 @@ The docker image that you have just built, exposes the port `8443` for the HTTP
 
 ## Configuration (basic)
 
-The docker image of MongoosePush contains common, basic configuration that is generated from `config/prod.exs`. All useful options may be overridden via environment variables. Below there's a full list of the variables you may set while running docker (via `docker -e`), but if there's something you feel you need to change other then that, then you need to prepare your own `config/prod.exs` before image build.
+The docker image of MongoosePush contains common, basic configuration that is generated from `config/prod.exs`. All useful options may be overridden via [environment variables](https://esl.github.io/MongoosePush/v2.1.0-alpha.1/configuration.html#environmental-variables). However, if there's something you feel you need to change other than that, then you need to prepare your own `config/prod.exs` before image build.
diff --git a/guides/metrics.md b/guides/metrics.md
@@ -91,8 +91,8 @@ Please, mind the `HTTPS` protocol, metrics are hosted on the same port than all
 ## Prometheus configuration
 
 When configuring Prometheus, it's important to:
-* set the `scheme` to `https` since MongoosePush exposes `/metrics` path encrypted endpoint (HTTPS)
-* set the `insecure_skip_verify` to `true` if the default self-signed certificates are used
+* set the `scheme` to `https`,
+* set the `insecure_skip_verify` to `true` if the default self-signed certificates are used.
 
 ```yaml
 scrape_configs:

diff --git a/guides/test.md b/guides/test.md
@@ -43,7 +43,7 @@ All Mix commands need to be invoked in the `MIX_ENV=integration` environment:
 ```bash
 # We start the mocks AND MongoosePush docker container.
 # This may take a few minutes on the first run, as the MongoosePush docker image needs
-# to build from scratch. Subsequent runs should be much faster.
+# to be built from scratch. Subsequent runs should be much faster.
 # You need to rerun this command each time you make changes in the app code,
 # as MongoosePush needs to be rebuilt and redeployed!
 MIX_ENV=integration mix test.env.up