apply PR review comments

esl · Jul 20, 2020 · 55b9e77 · 55b9e77
1 parent 4ceefbc
commit 55b9e77
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/Makefile b/Makefile
@@ -5,3 +5,6 @@ update-dashboards:
 	./test/docker/grafana/update-dashboards.sh
 
 .PHONY: run update-dashboards
+
+clean-dashboards:
+	docker-compose -f test/docker/docker-compose.dashboard.yml down
diff --git a/guides/metrics.md b/guides/metrics.md
@@ -9,20 +9,26 @@ This may mean that a freshly started MongoosePush node will not have all the pos
 
 ## Default dashboard
 
-MongoosePush 2.1.1 provides default Grafana dashboard where we can see some of the available metrics.
+MongoosePush 2.1.1 provides default Grafana dashboards where we can see some of the available metrics.
 You can create the dashboards using following command:
 
 ```bash
 make dashboards
 ```
 
 This starts and configures two containers:
-* `mongoose-push-grafana` - running Grafana, available at http://127.0.0.1:3000/
-* `mongoose-push-prometheus` - running Prometheus that is scraping the metrics from the `/metrics` endpoint, available at http://127.0.0.1:9090/
+* `mpush-grafana` - running Grafana, available at http://127.0.0.1:3000/
+* `mpush-prometheus` - running Prometheus, which scraps the metrics from the `/metrics` endpoint, available at http://127.0.0.1:9090/
 
-Once we login to the Grafana with the default (login: admin, password: admin) credentials we can see two dashboards:
+Once we login to Grafana container with the default (login: admin, password: admin) credentials we can see two dashboards:
 * MongoosePush Metrics - displaying metrics related to notification send times and successful/failed connections.
-* MongoosePush VM - this dashboard contains graphs related to the VM like memory allocations or lengths of the run queues.
+* MongoosePush VM - this dashboard contains metrics related to the VM like memory allocations or lengths of the run queues.
+
+You can stop the docker containers that are running Grafana and Prometheus using following command:
+
+```bash
+make clean-dashboards
+```
 
 ## Available metrics
 

diff --git a/test/docker/grafana/provisioning/dashboards/all.yml b/test/docker/grafana/provisioning/dashboards/all.yml
@@ -2,5 +2,7 @@
   org_id: 1
   folder: ''
   type: 'file'
+  editable: true
+  allowUiUpdates: true
   options:
     folder: '/var/lib/grafana/dashboards'