Scenario upload rework #123
Conversation
updated using the next commands:
rm rebar3
wget https://rebar3.s3.amazonaws.com/rebar3
chmod a+x rebar3
There was a problem hiding this comment.
Looks good and it seems much more convenient to upload the file now. Just to clarify:
- Why do we need to change the method from POST to PUT? PUT seems better as file upload is idempotent and it's the default method in
curl -T. Was this the reason? - I see that there is a new path
/uploadneeded to handle the new content type, right? Why do we needapplication/jsonfor/scenariosthough as there is only GET there now?
|
|
||
| post_scenarios_returns_200_and_when_scenario_valid(_Config) -> |
| echo "Installing scenario: 'dummy_scenario.erl' on node amoc-1 (port ${PORT1})" | ||
|
|
||
| SCEN_POST=$( (echo '{"scenario":"dummy_scenario","module_source":'; echo ${SCEN_SOURCE} ; echo '}' ) | curl \ |
There was a problem hiding this comment.
Maybe name it SCEN_PUT just to avoid confusion.
There was a problem hiding this comment.
The old way was painful to use, the simple text/plain approach is much more convenient. When it comes to commits history, I think they could be squashed to 3:
- Rebar3 upgrade
- The change the PR is about
- Erlang/OTP update
I hope the subsequent PR with documentation changes comes soon :)
Also, I noticed the PR does some extra change related to upgrading of rebar3 and used Erlang/OTP versions, ideally, it'd good to have that in a separate PR but I'm not going to reject this one because of that.
|
Oh, and I just noticed, that dialyzer returns some errors after these changes. |
yes, PUT is more appropriate for these purposes. |
|
I was still waiting for the answer for this question:
|
|
Because that is declaration of response type for this GET request. |
I still don't think I got the answer. Let me rephrase the question then: Why use a separate path |
|
I prefer to have different paths for different functionality. it's easier to keep codebase clean, and easier to explain in docs. |
|
It just came to my mind that, maybe path like |
This PR reworks scenario (module) uploading to amoc cluster. Now the PUT HTTP method is used instead of POST, so JSON encoding of erlang code is not required any more.
Please note that there is no support for file uploading using PUT method in the current swagger 2.0 user interface.
REST API documentation will be updated in a subsequent PR.