REST API for scenario execution #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality allows modifying scenario parameters
while it is running.
- The whole 'amoc_dist' module is untested.
This needs to be solved. It is not possible to test it easily
as the whole cluster needs to be running.
There is an integration test, but it has a significant overhead
and does not generate coverage reports.
- Fixed some broken specs
Follows the API definition: https://github.com/esl/amoc_rest/blob/1d615924/openapi.yaml
- Removed tests for the obsolete 'scenario' endpoints
- Add tests for the new 'execution' endpoints
- 'amoc_dist' requires mocking as otherwise several nodes
would need to be started
- Test layout simplified for more brevity and readability
- Intentionally not checking for invoked mocked functions
- test effects, not calls
DenysGonchar
reviewed
Aug 4, 2020
| @@ -6,7 +6,7 @@ | |||
| {exometer_core, {git, "https://github.com/esl/exometer_core.git", {branch, "master"}}}, | |||
| {exometer_report_graphite, {git, "https://github.com/esl/exometer_report_graphite.git", {branch, "master"}}}, | |||
| %% when updating amoc_rest version, don't forget to update it at ./doc/http-api.md as well. | |||
| {amoc_rest, {git, "https://github.com/esl/amoc_rest.git", {ref, "7a46d9f"}}}, | |||
| {amoc_rest, {git, "https://github.com/esl/amoc_rest.git", {ref, "1d615924"}}}, | |||
There was a problem hiding this comment.
please update the link in ./doc/http-api.md
it should be https://esl.github.io/amoc_rest/?v=1d615924
NelsonVides
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the API definition: https://github.com/esl/amoc_rest/blob/1d615924/openapi.yaml
update_settingsinamoc_distThere is an increasing need to add tests for
amoc_dist- this module is untested. This should be done in a separate issue.See the commit messages below for more details.