Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching from TravisCI to GH Actions #135

Merged
merged 3 commits into from
Nov 27, 2020
Merged

switching from TravisCI to GH Actions #135

merged 3 commits into from
Nov 27, 2020

Conversation

DenysGonchar
Copy link
Collaborator

@DenysGonchar DenysGonchar commented Nov 24, 2020

this PR fixes the following issues with GH Actions environment:

  • missing TRAVIS_OTP_RELEASE env variable
  • by default checkout action fetches just one exact commit, since amoc uses 'git' version (see rebar.config) rebar3 searches for the latest git tag and so requires the whole repo
  • 8084 port is used by GH actions environment, so for integration testing amoc REST API ports are mapped at 888x range
  • GH actions environment has no tty device

@DenysGonchar DenysGonchar force-pushed the reworking-ci branch 13 times, most recently from f1b8ee9 to 28d31cd Compare November 25, 2020 02:41
this commit fixes the following issues with GH Actions environment:
* missing TRAVIS_OTP_RELEASE env variable
* by default checkout action fetches just one exact commit, since amoc uses 'git' version (see rebar.config) rebar3 searches for the latest git tag and so requires the whole repo
* 8084 port is used by GH actions environment, so for integration testing amoc REST API ports are mapped at 888x range
* GH actions environment has no tty device
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the GH actions in action :-)
I have a few comments, could you answer?

integration_test/helper.sh Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@chrzaszcz chrzaszcz merged commit a83947b into master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants