Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let amoc user processes exit normally #144

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

NelsonVides
Copy link
Collaborator

As discussed in the internal communication channel, trying to report normal_user_stop still results in an abnormal exit, so this is buggy code, and altogether makes processes promoted to OTP gen processes to die with terrible crash reports. Logic is “call start, if it crashes, crash too”, so it makes sense to replace the throw in that amoc_user:stop/1 function with exit(shutdown) and not have any try ... catch.

@NelsonVides NelsonVides marked this pull request as ready for review May 15, 2023 13:30
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit badc0c9 into master May 16, 2023
4 checks passed
@NelsonVides NelsonVides deleted the amoc_user_exit_reason branch May 26, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants