Let amoc user processes exit normally #144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the internal communication channel, trying to report
normal_user_stop
still results in an abnormal exit, so this is buggy code, and altogether makes processes promoted to OTPgen
processes to die with terrible crash reports. Logic is “call start, if it crashes, crash too”, so it makes sense to replace thethrow
in thatamoc_user:stop/1
function withexit(shutdown)
and not have anytry ... catch
.