Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amoc core #145

Merged
merged 11 commits into from
Jun 20, 2023
Merged

Amoc core #145

merged 11 commits into from
Jun 20, 2023

Conversation

NelsonVides
Copy link
Collaborator

@NelsonVides NelsonVides commented May 26, 2023

This PR is a proposal for a big change in how amoc works. Here, we separate metrics and APIs from what is actually the load-testing tooling, so that amoc itself can be a bare-bones dependency to be added to any project that wants to do load-testing.

  • Amoc remain simply instrumented with telemetry, so that users can choose their own favourite metrics and logging systems by simply subscribing to the exposed telemetry events, without imposing graphite or prometheus.
  • Likewise the API is removed, so that the user can write his own, be it REST or GraphQL (which we can write on our own as well and add them all as dependencies as desired.

TODOs so that this proposal is comprehensive and makes sense:

  • Move all removed REST code into amoc-arsenal-xmpp and have it possible to install amoc and amoc_rest and have just exactly the same functionality.
  • Move all removed exometer code into amoc-arsenal-xmpp and have it possible to install exometer and exometer_report_graphite and have just exactly the same functionality.

@NelsonVides NelsonVides marked this pull request as ready for review June 19, 2023 07:06
@NelsonVides NelsonVides removed the WIP Work In Progress label Jun 19, 2023
@NelsonVides NelsonVides mentioned this pull request Jun 19, 2023
2 tasks
@NelsonVides NelsonVides force-pushed the amoc_core branch 2 times, most recently from fd5ec2f to f723b26 Compare June 19, 2023 14:06
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, I added some minor comments.

doc/configuration.md Show resolved Hide resolved
doc/http-api.md Show resolved Hide resolved
doc/telemetry.md Show resolved Hide resolved
doc/telemetry.md Outdated Show resolved Hide resolved
elvis.config Show resolved Hide resolved
Remove empty lines, and elvis from rebar.config and Makefile. Elvis was removed
because the latest version introduces too many breaking changes and compilation
problems, it was too complicated to solve and for little benefit. It can be
leaved as a future task to install elvis.
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chrzaszcz chrzaszcz merged commit 66eb4d4 into master Jun 20, 2023
4 checks passed
@NelsonVides NelsonVides deleted the amoc_core branch June 20, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants