Add livebook guide example #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonVides
force-pushed
the
elixir/livebook
branch
from
d728697
to
2cf3181
Compare
NelsonVides
changed the base branch from
master
to
telemetry/timestamps_and_spans
DenysGonchar
approved these changes
Dec 11, 2023
NelsonVides
force-pushed
the
elixir/livebook
branch
from
2cf3181
to
23b8ada
Compare
NelsonVides
force-pushed
the
telemetry/timestamps_and_spans
branch
from
57620b4
to
b565018
Compare
NelsonVides
force-pushed
the
elixir/livebook
branch
from
23b8ada
to
8bedab7
Compare
NelsonVides
force-pushed
the
telemetry/timestamps_and_spans
branch
5 times, most recently
from
b834956
to
c494c65
Compare
NelsonVides
force-pushed
the
elixir/livebook
branch
from
8bedab7
to
e71cca1
Compare
NelsonVides
force-pushed
the
elixir/livebook
branch
from
e71cca1
to
c9433ea
Compare
NelsonVides
force-pushed
the
elixir/livebook
branch
from
c9433ea
to
64a308b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 33.23% 33.23%
=======================================
Files 23 23
Lines 975 975
=======================================
Hits 324 324
Misses 651 651 ☔ View full report in Codecov by Sentry. |
guides/amoc_livebook.livemd
Outdated
| {:jiffy, "~> 1.1"}, | ||
| {:gen_state_machine, "~> 2.0"}, | ||
| {:uuid, "~> 1.1"}, | ||
| {:amoc, git: "https://github.com/esl/amoc.git", branch: "master"} |
There was a problem hiding this comment.
comma is missing in the end of the line:
** (SyntaxError) #cell:setup:7:3: syntax error before: '{'
|
7 | {:kino, "~> 0.11.3"},
| ^
|
|
||
| ## The Instrumentation | ||
|
|
||
| ### Collect metrics |
There was a problem hiding this comment.
Telemetry event names are incorrect now, so metrics collection demo doesn't work at all.
DenysGonchar
requested changes
Dec 15, 2023
NelsonVides
force-pushed
the
elixir/livebook
branch
from
64a308b
to
7c3fc13
Compare
DenysGonchar
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after #162, as this guide uses some metrics defined there.
Once all is merged before this, the final 3.0.0 should be released an the hex install for amoc should be updated.