Throttles/rework run and sending logic #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonVides
force-pushed
the
throttles/rework_run_and_sending_logic
branch
from
f287c38
to
b5123e3
Compare
Notice that a normal send would spawn a local process, send a pid across distribution, have the local process receive an atom across distribution, and have the `Msg' be delivered to the requester locally. That is 1 pid and 1 atom across distribution and one local payload, plus one spawn that copies the payload. Doing a call instead will only send back and forth the payload, and already solve monitoring problems This is specially optimal when the payload is a literal, like an atom.
Note that in this case, the desired operation will never happen, and therefore the test has been deemed invalid.
NelsonVides
force-pushed
the
throttles/rework_run_and_sending_logic
branch
from
3d9d72f
to
443ca6b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 73.44% 73.80% +0.36%
==========================================
Files 29 30 +1
Lines 1043 1050 +7
==========================================
+ Hits 766 775 +9
+ Misses 277 275 -2 ☔ View full report in Codecov by Sentry. |
We here revert the changes of the previous commits and instead move the logic regarding the `async_runner` to a separate module. This way, the `amoc_throttle_process`'s only responsibility is to track runners and notify them that they can run; the `amoc_throttle_controller`'s only responsibility is to assign tasks to processes and control the rates; and `amoc_throttle_runner`'s only responsibility is to execute the actions.
With this, now `amoc_throttle_process` only tracks the runners and doesn't know about creating them nor about what operation is it running, and the controller now only controls the rate, and not the choosing of a worker.
With this, now `amoc_throttle_runner` optimises the different use-cases of the throttling API: executing arbitrary code, sending a payload, or blocking the caller.
NelsonVides
force-pushed
the
throttles/rework_run_and_sending_logic
branch
from
b9971d5
to
1e25a29
Compare
DenysGonchar
requested changes
Jan 18, 2024
| @@ -35,8 +37,8 @@ | |||
| interval = 0 :: amoc_throttle:interval(), %%ms | |||
| delay_between_executions = 0 :: non_neg_integer(), %%ms | |||
| tref :: timer:tref() | undefined, | |||
| schedule = [] :: [pid()], | |||
| schedule_reversed = [] :: [pid()]}). | |||
| schedule = [] :: [amoc_throttle_runner:runner()], | |||
There was a problem hiding this comment.
avoid introduction of unneeded types. it is pid(), it has to be pid() and it cannot be anything else. since we set up process monitoring with erlang:monitor/2 for the items in this list. if you want to highlight that it's a process created by amoc_trottle_runner, then the spec could look like [AmocTrottleRunnerProcess::pid()]
|
|
||
| -spec run(runner()) -> reference(). | ||
| run(RunnerPid) -> | ||
| Ref = erlang:monitor(process, RunnerPid), |
There was a problem hiding this comment.
by the time this function is executed, the monitoring is already set up. 2 monitors is definetly a bug, please remove this call.
since amoc_throttle_process relies on monitor messages I would expect it to explicitely create that monitors
NelsonVides
force-pushed
the
throttles/rework_run_and_sending_logic
branch
from
0798c8a
to
42050d5
Compare
test/throttle_SUITE.erl
Outdated
| wait_until_one_throttle_worker(?FUNCTION_NAME), | ||
| amoc_throttle:send(?FUNCTION_NAME, receive_this), | ||
| wait_until_one_async_runner(self(), OriginalLinks), | ||
| kill_throttle_workers(?FUNCTION_NAME), |
There was a problem hiding this comment.
we can just stop the trottle with amoc_trottle:stop/1
NelsonVides
force-pushed
the
throttles/rework_run_and_sending_logic
branch
from
42050d5
to
5060d89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to tackle the issue raised in #178 (comment)
Introduces a new API endpoint called
waitthat supersedessend_and_wait, as the latter was redundant and could possibly result in a deadlock was the throttling process to die.