Use unique names for fresh story users #249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some suites run the same testcase several times
This means a duplicate key error could occure when registering a new user
This also means some random stanzas would come from another cases
It is especially visible when two cases run in parallel (but it is not a requirement)
A collision example:
https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/3420/91739/pgsql_mnesia.23.1/big/ct_run.test@9111b0329547.2021-12-02_09.32.48/big_tests.tests.amp_big_SUITE.logs/run.2021-12-02_09.33.01/amp_big_suite.notify_deliver_to_online_user_recipient_privacy_test.13699.html
Error in the case:
You can think, wtf, we use escalus:fresh_story and there is only one story function in the case. Yeah, but amp suite implements a complex trick to run the same testcase several times with different configs. And apparently, circle CI reproduces a collision in suffixes very well (impossible to reproduce on my machine though...)
See in logs:
We also have two cases with the same fresh story suffix.
MongooseIM branch, configured with this PR esl/MongooseIM#3429