Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optimisations in the compiler #50

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Conversation

NelsonVides
Copy link

A funny miss from #46
馃槃

PD: If this one gets merged, we need to do the same in MIM, and also upgrade exml dependency there 馃檪

@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   87.94%   87.94%           
=======================================
  Files           4        4           
  Lines         141      141           
=======================================
  Hits          124      124           
  Misses         17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a307e83...064b4f1. Read the comment docs.

Copy link

@michalwski michalwski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I wander what's the performance impact.

@michalwski
Copy link

Also, let's give it a try in MongooseIM. Could you please create a PR to Mongoose with exml from this branch?

@NelsonVides
Copy link
Author

Also, let's give it a try in MongooseIM. Could you please create a PR to Mongoose with exml from this branch?

esl/MongooseIM#2604 :)

@michalwski michalwski merged commit 6ca4f88 into master Jan 23, 2020
@michalwski michalwski deleted the enable_optimisations branch January 23, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants