New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend APNS API #10

Merged

michalwski merged 2 commits into master from extend-APNS-API

Nov 9, 2018

Contributor

aleklisi commented Nov 8, 2018 •

edited

Loading

This PR extends APNS API to add options that were found in https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/generating_a_remote_notification
but were not listed in
https://developer.apple.com/library/archive/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/PayloadKeyReference.html#//apple_ref/doc/uid/TP40008194-CH17-SW1
some options were already implemented so it just fixes reaming.

Added changes:

for aps dictionary, sound option was extended, now it can be a dictionary too (previously could be String only); sound dictionary builder added
for aps dictionary, mutable-content option was added
add_subtitle_loc_args spec is fixed

aleklisi added 2 commits

November 8, 2018 12:23


          Add sound as dictionary to APNS notification

7d469af


          Add mutable-content to APNS notification

a395960

coveralls commented Nov 8, 2018

Pull Request Test Coverage Report for Build 42

4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 96.903%

Totals
Change from base Build 41:	0.02%
Covered Lines:	532
Relevant Lines:	549

💛 - Coveralls

michalwski reviewed

View reviewed changes

Contributor

michalwski left a comment

Looks good to me. I think it'd be beneficial to describe in short what was added in the PR desc.

michalwski merged commit baf650d into master

michalwski deleted the extend-APNS-API branch

November 9, 2018 09:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment