Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notifications with empty alerts #19

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Fix notifications with empty alerts #19

merged 1 commit into from
Jul 8, 2019

Conversation

kmakiela
Copy link
Contributor

@kmakiela kmakiela commented Jul 4, 2019

  • Change notification building to omit empty alerts
  • Update one test for compatibility with newer OTP
  • Add a test for empty alerts
  • Update one test previously blocking empty notifications but APNS does not specify that

@kmakiela kmakiela requested review from rslota and aleklisi July 4, 2019 10:52
@coveralls
Copy link

coveralls commented Jul 4, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 74

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 97.153%
Totals Coverage Status
Change from base Build 72: -0.03%
Covered Lines: 546
Relevant Lines: 562
💛 - Coveralls

aleklisi
aleklisi reviewed Jul 8, 2019
View reviewed changes
Copy link
Contributor

@aleklisi aleklisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good 👍

mix.exs Show resolved Hide resolved
test/h2_integration/certificate_rejected_test.exs Show resolved Hide resolved
test/apns_test.exs Show resolved Hide resolved
@kmakiela
Fix notifications with empty alerts
7ce2148 
* Change notification building to omit empty alerts
* Update one test for compatibility with newer OTP
* Add a test for empty alerts
* Update one test previously blocking empty notifications but APNS does not specify that
@aleklisi aleklisi merged commit b41ea2c into master Jul 8, 2019
@aleklisi aleklisi deleted the km/init_fix branch July 8, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleklisi aleklisi aleklisi left review comments

@rslota rslota Awaiting requested review from rslota

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmakiela @coveralls @aleklisi