fix: reporting location for no-unused-placeholders

eslint-community · Aug 4, 2022 · 909186e · 909186e
1 parent e2f3deb
commit 909186e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/lib/rules/no-unused-placeholders.js b/lib/rules/no-unused-placeholders.js
@@ -107,7 +107,7 @@ module.exports = {
                 const key = utils.getKeyName(prop);
                 if (!placeholdersInMessage.has(key)) {
                   context.report({
-                    node: message,
+                    node: prop,
                     messageId: 'placeholderUnused',
                     data: { unusedKey: key },
                   });

diff --git a/tests/lib/rules/no-unused-placeholders.js b/tests/lib/rules/no-unused-placeholders.js
@@ -17,8 +17,11 @@ const RuleTester = require('eslint').RuleTester;
  * @param {string} unusedKey The placeholder that is unused
  * @returns {object} An expected error
  */
-function error(unusedKey, type = 'Literal') {
-  return { type, message: `The placeholder {{${unusedKey}}} is unused.` };
+function error(unusedKey) {
+  return {
+    type: 'Property', // The property in the report's `data` object for the unused placeholder.
+    message: `The placeholder {{${unusedKey}}} is unused.`,
+  };
 }
 
 // ------------------------------------------------------------------------------
@@ -238,7 +241,7 @@ ruleTester.run('no-unused-placeholders', rule, {
           }
         };
       `,
-      errors: [error('bar', 'Identifier')],
+      errors: [error('bar')],
     },
     {
       code: `